[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: one more



On Thu, Sep 04, 2008 at 03:14:52PM -0500, Raphael Geissert wrote:
> Tag: maintainer-script-ignores-errors
> Type: warning
> Severity: normal
> Certainty: certain
> Ref: policy 3.9
> Info: The maintainer script doesn't seem to set the <tt>-e</tt> flag which
>  ensures that the script's execution is aborted when any executed command
> fails.

Hrm:
Running test on maintainer-scripts 7+dfsg-0.1: copying... building... testing... FAILED:
--- testset/tags.maintainer-scripts	2008-08-30 00:51:10.000000000 +0200
+++ debian/tests/tags.maintainer-scripts	2008-09-12 00:39:44.000000000 +0200
@@ -50,6 +50,10 @@
 W: maintainer-scripts: maintainer-script-calls-deprecated-wm-menu-config postinst:33
 W: maintainer-scripts: maintainer-script-empty config
 W: maintainer-scripts: maintainer-script-hides-init-failure postinst:57
+W: maintainer-scripts: maintainer-script-ignores-errors postinst
+W: maintainer-scripts: maintainer-script-ignores-errors postrm
+W: maintainer-scripts: maintainer-script-ignores-errors preinst
+W: maintainer-scripts: maintainer-script-ignores-errors prerm
 W: maintainer-scripts: maintainer-script-needs-depends-on-gconf2 postinst
 W: maintainer-scripts: maintainer-script-needs-depends-on-ucf postinst
 W: maintainer-scripts: maintainer-script-needs-depends-on-xml-core postinst

In the future please run the whole testsuite before submitting patches.

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/


Reply to: