Re: Fix and improve reference links (was: GSoC status: classification, output format and more)
On Tue, Aug 12, 2008 at 05:47:05PM +0200, Jordà Polo wrote:
> On Tue, Aug 12, 2008 at 03:33:12PM +0200, Frank Lichtenheld wrote:
> > I think using a hash instead (i.e. $linked_pages{$1}++) is more compact,
> > but maybe that's just me.
>
> Yes, that would be more compact, but I wanted the list sorted by order
> of appearance. It is probably not that important though, as long as it
> is sorted in some way (otherwise diffs after minor changes in manuals
> would be polluted), but I thought appearance order made more sense. If
> you still prefer the more compact version I don't mind changing it.
Hmm, hadn't thought about that. Makes sense.
> > > unless (-f $index) {
> > > print STDERR "Manual '$manual' not installed; not updating.\n";
> > > next;
> > > }
> >
> > Since the script doesn't use the old list anymore, wouldn't a "die" be more
> > appropriate here? AFAICT it will just loose all the refs to the skipped
> > manuals?
>
> True, it doesn't make sense to continue generating references for other
> manuals if one of them isn't there; changed it.
>
> (Note: that code was marked as added because a lot of things moved, but
> it was already there before the rewrite.)
True, but this time I noticed it ;)
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: