Bug#464026: [checks/scripts] Sync bashism tests with checkbashisms
On Mon, 2008-02-04 at 14:50 -0800, Russ Allbery wrote:
> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
>
> > As discussed recently, please find attached a patch (against lintian and
> > devscripts SVN) to checks/scripts that adds the bashism tests that
> > devscripts's checkbashisms performs but lintian does not.
>
> Thank you! You beat me to doing the merger. One question, though:
>
> > + 'echo\s+-[e]', # echo -e
> > + 'exec\s+-[acl]', # exec -c/-l/-a name
> > + '\blet\s', # let ...
>
> Shouldn't these be prefixed with (^|\s+) instead of \b or nothing to not
> catch things like "echo echo -e" (as odd as that might be)?
The first two certainly should be prefixed by something to avoid them
matching strings that happen to end in "echo -e". I've updated
checkbashisms to do so for all three.
As far as I can see that won't stop "echo echo -e" matching, however.
Adam
Reply to: