Bug#464026: [checks/scripts] Sync bashism tests with checkbashisms
"Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
> As discussed recently, please find attached a patch (against lintian and
> devscripts SVN) to checks/scripts that adds the bashism tests that
> devscripts's checkbashisms performs but lintian does not.
Thank you! You beat me to doing the merger. One question, though:
> + 'echo\s+-[e]', # echo -e
> + 'exec\s+-[acl]', # exec -c/-l/-a name
> + '\blet\s', # let ...
Shouldn't these be prefixed with (^|\s+) instead of \b or nothing to not
catch things like "echo echo -e" (as odd as that might be)? We do run the
risk of missing cases where people put the statement on the same line as
an if statement or the like, but I think it makes sense to err on the side
of conservatism.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: