[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1115 - in trunk: checks debian testset



Author: rra
Date: 2008-01-05 19:49:11 +0100 (Sat, 05 Jan 2008)
New Revision: 1115

Modified:
   trunk/checks/debconf
   trunk/checks/debconf.desc
   trunk/debian/changelog
   trunk/testset/tags.debconf
Log:
* checks/debconf{.desc,}:
  + Remove partially-translated-question at the request of Christian
    Perrier.  Only the translator could fix this, and debconf doesn't
    show the translation unless it's complete.  (Closes: #459293)

Modified: trunk/checks/debconf
===================================================================
--- trunk/checks/debconf	2008-01-05 06:04:27 UTC (rev 1114)
+++ trunk/checks/debconf	2008-01-05 18:49:11 UTC (rev 1115)
@@ -245,22 +245,6 @@
 	    tag "unknown-field-in-templates", "$template->{template} $field";
 	}
     }
-    if (exists $template->{choices}
-	&& $template->{choices} !~ m/^\s*\$\{\w+\}\s*$/) {
-	foreach my $lang (sort keys %languages) {
-	    # Choices-C is special. Normally, when it is present, the only
-	    # other Choices* field present will be Choices itself, and there
-	    # is not necessarily a Description-C. This is used by code that
-	    # wants to substitute into the untranslated choices and also
-	    # into all translated choices at once.
-	    # TODO: it's reasonable to have a full set of Choices-*, but
-	    # only Description-C and Description, for pretty much the same
-	    # reason as above. This shouldn't trigger this tag.
-	    if ($lang ne 'c' and $languages{$lang}{choices} and not $languages{$lang}{description}) {
-		tag "partially-translated-question", "$template->{template} $lang";
-	    }
-	}
-    }
 
     if ($template->{template} && $template->{type}) {
         $potential_db_abuse{$template->{template}} = 1

Modified: trunk/checks/debconf.desc
===================================================================
--- trunk/checks/debconf.desc	2008-01-05 06:04:27 UTC (rev 1114)
+++ trunk/checks/debconf.desc	2008-01-05 18:49:11 UTC (rev 1115)
@@ -87,11 +87,6 @@
  is a duplicate of the short description. If you cannot provide a good
  extended description, it is better to leave it blank.
 
-Tag: partially-translated-question
-Type: warning
-Info: If you translate the `Choices:' fields in a template, you should
- translate the 'Description:' field as well
-
 Tag: config-does-not-load-confmodule
 Type: warning
 Info: The config script must load one of the debconf libraries.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2008-01-05 06:04:27 UTC (rev 1114)
+++ trunk/debian/changelog	2008-01-05 18:49:11 UTC (rev 1115)
@@ -24,6 +24,10 @@
       or exemption.  Requested by Joerg Jaspert.  (Closes: #454238)
   * checks/cruft:
     + [RA] Ignore debian/config.cache.
+  * checks/debconf{.desc,}:
+    + Remove partially-translated-question at the request of Christian
+      Perrier.  Only the translator could fix this, and debconf doesn't
+      show the translation unless it's complete.  (Closes: #459293)
   * checks/debian-readme{.desc,}:
     + Combine readme-debian-{is,contains}-debmake-template and be less
       particular about the exact formatting of the dh-make template.

Modified: trunk/testset/tags.debconf
===================================================================
--- trunk/testset/tags.debconf	2008-01-05 06:04:27 UTC (rev 1114)
+++ trunk/testset/tags.debconf	2008-01-05 18:49:11 UTC (rev 1115)
@@ -35,8 +35,6 @@
 W: debconf-test: malformed-question-in-templates debconf/testboolean
 W: debconf-test: malformed-title-in-templates debconf/testnote
 W: debconf-test: old-fsf-address-in-copyright-file
-W: debconf-test: partially-translated-question debconf/testmulti de.utf-8
-W: debconf-test: partially-translated-question debconf/testmulti-escape de.utf-8
 W: debconf-test: possible-debconf-note-abuse config:19 debconf/test
 W: debconf-test: possible-debconf-note-abuse postinst:8 debconf/test
 W: debconf-test: postinst-uses-db-input


Reply to: