Re: menu enhancements

[Raphael Geissert <atomo64+debian@gmail.com>]

Adam D. Barratt wrote:

> On Thu, 2008-07-31 at 12:56 -0500, Raphael Geissert wrote:
>> +    if ($vals{'command'} =~ m,^(/(?:usr/)?s?bin/\w+),
>> +        || ($command && $command =~ m,^(/(?:usr/)?s?bin/\w+),)) {
> 
> Unless I'm missing something, that check's a little overzealous, as
> {/usr,}/sbin aren't on a normal user's default path.

Hmm, right :) 
s/s\?//g

> 
> (As a side note, two of the three sample menu files contained in the
> Menu System Documentation use fully qualified paths, for commands
> in /usr/bin and /usr/games respectively.)

none of the examples in menufile(5) use a full path; but of course games
in /usr/games do need a path (although one could argue that it isn't
necessary as non root users often have /usr/games in their $PATH).

> 
> Adam

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html