On Wednesday 30 July 2008 15:38:31 Adam D. Barratt wrote: > Personally I'd prefer a patch via e-mail (a bug report isn't necessary > imho) but that's partly laziness on my part as it means I don't have to > work out the required git-fu to create a diff myself. No problem, I've used git format-patch to generate five files which can be applied with "git am 000*" to your repository. Please note that this command will automatically commit the changes. Regards, Tobias -- Tobias Quathamer | Death has been proven to be 99% fatal in laboratory rats. Hamburg, Germany |
From 3354e1c8d923a40b019d6d80b3c591b2ea80998a Mon Sep 17 00:00:00 2001 From: Tobias Quathamer <toddy@debian.org> Date: Wed, 30 Jul 2008 13:02:59 +0200 Subject: [PATCH] Add test for debian-revision-not-well-formed --- testset/fields/debian/changelog | 6 ++++++ testset/fields/debian/control | 10 ++++++++++ testset/fields/debian/rules | 23 +++++++++++++++++++++++ testset/tags.fields | 10 ++++++++++ 4 files changed, 49 insertions(+), 0 deletions(-) create mode 100644 testset/fields/debian/changelog create mode 100644 testset/fields/debian/control create mode 100755 testset/fields/debian/rules create mode 100644 testset/tags.fields diff --git a/testset/fields/debian/changelog b/testset/fields/debian/changelog new file mode 100644 index 0000000..0d3fcf5 --- /dev/null +++ b/testset/fields/debian/changelog @@ -0,0 +1,6 @@ +fields (1.5-.3) unstable; urgency=low + + * This package adds tests for the following tags: + - debian-revision-not-well-formed + + -- Tobias Quathamer <toddy@debian.org> Wed, 30 Jul 2008 12:35:09 +0200 diff --git a/testset/fields/debian/control b/testset/fields/debian/control new file mode 100644 index 0000000..e7d1bfa --- /dev/null +++ b/testset/fields/debian/control @@ -0,0 +1,10 @@ +Source: fields +Section: does-not-exist +Priority: standard +Maintainer: Lintian Maintainers <lintian-maint@debian.org> +Standards-Version: 3.8.0 + +Package: fields +Architecture: all +Description: Generate some errors + Field testing is fun! diff --git a/testset/fields/debian/rules b/testset/fields/debian/rules new file mode 100755 index 0000000..9c3abac --- /dev/null +++ b/testset/fields/debian/rules @@ -0,0 +1,23 @@ +#!/usr/bin/make -f + +tmp=debian/tmp + +build: + +binary-arch: + +binary-indep: + install -d $(tmp)/usr/share/doc/fields + install -m 644 debian/changelog \ + $(tmp)/usr/share/doc/fields/changelog + gzip -9 $(tmp)/usr/share/doc/fields/changelog + dh_md5sums + dpkg-gencontrol + dpkg --build $(tmp) .. + +binary: binary-arch binary-indep + +clean: + rm -rf debian/files $(tmp) debian/substvars + +.PHONY: build binary-arch binary-indep binary clean diff --git a/testset/tags.fields b/testset/tags.fields new file mode 100644 index 0000000..13a28ba --- /dev/null +++ b/testset/tags.fields @@ -0,0 +1,10 @@ +E: fields source: package-uses-debhelper-but-lacks-build-depends +E: fields: debian-changelog-file-missing-or-wrong-name +E: fields: no-copyright-file +W: fields source: changelog-should-mention-nmu +W: fields source: debian-revision-not-well-formed 1.5-.3 +W: fields source: native-package-with-dash-version +W: fields source: package-uses-deprecated-debhelper-compat-version 1 +W: fields source: source-nmu-has-incorrect-version-number 1.5-.3 +W: fields: debian-revision-not-well-formed 1.5-.3 +W: fields: unknown-section does-not-exist -- 1.5.4.3
From 7ec33185d1891e6b5d0dbf499273afd557e86452 Mon Sep 17 00:00:00 2001
From: Tobias Quathamer <toddy@debian.org>
Date: Wed, 30 Jul 2008 13:08:04 +0200
Subject: [PATCH] Add test for depends-on-python-minimal
---
testset/fields/debian/changelog | 1 +
testset/fields/debian/control | 1 +
testset/tags.fields | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/testset/fields/debian/changelog b/testset/fields/debian/changelog
index 0d3fcf5..c544115 100644
--- a/testset/fields/debian/changelog
+++ b/testset/fields/debian/changelog
@@ -2,5 +2,6 @@ fields (1.5-.3) unstable; urgency=low
* This package adds tests for the following tags:
- debian-revision-not-well-formed
+ - depends-on-python-minimal
-- Tobias Quathamer <toddy@debian.org> Wed, 30 Jul 2008 12:35:09 +0200
diff --git a/testset/fields/debian/control b/testset/fields/debian/control
index e7d1bfa..747d4b8 100644
--- a/testset/fields/debian/control
+++ b/testset/fields/debian/control
@@ -6,5 +6,6 @@ Standards-Version: 3.8.0
Package: fields
Architecture: all
+Depends: python-minimal
Description: Generate some errors
Field testing is fun!
diff --git a/testset/tags.fields b/testset/tags.fields
index 13a28ba..8324b13 100644
--- a/testset/tags.fields
+++ b/testset/tags.fields
@@ -1,5 +1,6 @@
E: fields source: package-uses-debhelper-but-lacks-build-depends
E: fields: debian-changelog-file-missing-or-wrong-name
+E: fields: depends-on-python-minimal depends
E: fields: no-copyright-file
W: fields source: changelog-should-mention-nmu
W: fields source: debian-revision-not-well-formed 1.5-.3
--
1.5.4.3
From ca625270b9c0bf9b538ffc56e13230d862abb499 Mon Sep 17 00:00:00 2001
From: Tobias Quathamer <toddy@debian.org>
Date: Wed, 30 Jul 2008 13:12:47 +0200
Subject: [PATCH] Add test for essential-no-not-needed
---
testset/fields/debian/changelog | 1 +
testset/fields/debian/control | 1 +
testset/tags.fields | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/testset/fields/debian/changelog b/testset/fields/debian/changelog
index c544115..fa99d96 100644
--- a/testset/fields/debian/changelog
+++ b/testset/fields/debian/changelog
@@ -3,5 +3,6 @@ fields (1.5-.3) unstable; urgency=low
* This package adds tests for the following tags:
- debian-revision-not-well-formed
- depends-on-python-minimal
+ - essential-no-not-needed
-- Tobias Quathamer <toddy@debian.org> Wed, 30 Jul 2008 12:35:09 +0200
diff --git a/testset/fields/debian/control b/testset/fields/debian/control
index 747d4b8..6738f1e 100644
--- a/testset/fields/debian/control
+++ b/testset/fields/debian/control
@@ -5,6 +5,7 @@ Maintainer: Lintian Maintainers <lintian-maint@debian.org>
Standards-Version: 3.8.0
Package: fields
+Essential: no
Architecture: all
Depends: python-minimal
Description: Generate some errors
diff --git a/testset/tags.fields b/testset/tags.fields
index 8324b13..19f112a 100644
--- a/testset/tags.fields
+++ b/testset/tags.fields
@@ -1,6 +1,7 @@
E: fields source: package-uses-debhelper-but-lacks-build-depends
E: fields: debian-changelog-file-missing-or-wrong-name
E: fields: depends-on-python-minimal depends
+E: fields: essential-no-not-needed
E: fields: no-copyright-file
W: fields source: changelog-should-mention-nmu
W: fields source: debian-revision-not-well-formed 1.5-.3
--
1.5.4.3
From 616f22d0c4dc80125f1dd7fe827427aab6402533 Mon Sep 17 00:00:00 2001
From: Tobias Quathamer <toddy@debian.org>
Date: Wed, 30 Jul 2008 13:41:09 +0200
Subject: [PATCH] Add test for new-essential-package
---
testset/fields/debian/changelog | 1 +
testset/fields/debian/control | 5 +++--
testset/tags.fields | 1 +
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/testset/fields/debian/changelog b/testset/fields/debian/changelog
index f008656..5944bbe 100644
--- a/testset/fields/debian/changelog
+++ b/testset/fields/debian/changelog
@@ -5,5 +5,6 @@ fields (1.5-.3) unstable; urgency=low
- depends-on-python-minimal
- essential-no-not-needed
- debian-revision-should-not-be-zero
+ - new-essential-package
-- Tobias Quathamer <toddy@debian.org> Wed, 30 Jul 2008 12:35:09 +0200
diff --git a/testset/fields/debian/control b/testset/fields/debian/control
index bc88ff1..6198251 100644
--- a/testset/fields/debian/control
+++ b/testset/fields/debian/control
@@ -12,8 +12,9 @@ Description: Generate some errors
Field testing is fun!
Package: another-version
+Essential: yes
Section: admin
Architecture: all
-Depends: nothing
Description: Also generate some errors
- This package gets another version number.
+ This package gets another version number and tries to sneak in a new
+ essential package.
diff --git a/testset/tags.fields b/testset/tags.fields
index 9aedaab..a219ab8 100644
--- a/testset/tags.fields
+++ b/testset/tags.fields
@@ -5,6 +5,7 @@ E: fields: depends-on-python-minimal depends
E: fields: essential-no-not-needed
E: fields: no-copyright-file
W: another-version: debian-revision-should-not-be-zero 123.4-0
+W: another-version: new-essential-package
W: fields source: changelog-should-mention-nmu
W: fields source: debian-revision-not-well-formed 1.5-.3
W: fields source: native-package-with-dash-version
--
1.5.4.3
From 4b39782c1469780ba033cd92f5040613fc3c62ec Mon Sep 17 00:00:00 2001
From: Tobias Quathamer <toddy@debian.org>
Date: Wed, 30 Jul 2008 13:26:57 +0200
Subject: [PATCH] Add test for debian-revision-should-not-be-zero
---
testset/fields/debian/changelog | 1 +
testset/fields/debian/control | 7 +++++++
testset/fields/debian/rules | 10 ++++++++--
testset/tags.fields | 2 ++
4 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/testset/fields/debian/changelog b/testset/fields/debian/changelog
index fa99d96..f008656 100644
--- a/testset/fields/debian/changelog
+++ b/testset/fields/debian/changelog
@@ -4,5 +4,6 @@ fields (1.5-.3) unstable; urgency=low
- debian-revision-not-well-formed
- depends-on-python-minimal
- essential-no-not-needed
+ - debian-revision-should-not-be-zero
-- Tobias Quathamer <toddy@debian.org> Wed, 30 Jul 2008 12:35:09 +0200
diff --git a/testset/fields/debian/control b/testset/fields/debian/control
index 6738f1e..bc88ff1 100644
--- a/testset/fields/debian/control
+++ b/testset/fields/debian/control
@@ -10,3 +10,10 @@ Architecture: all
Depends: python-minimal
Description: Generate some errors
Field testing is fun!
+
+Package: another-version
+Section: admin
+Architecture: all
+Depends: nothing
+Description: Also generate some errors
+ This package gets another version number.
diff --git a/testset/fields/debian/rules b/testset/fields/debian/rules
index 9c3abac..eb139f3 100755
--- a/testset/fields/debian/rules
+++ b/testset/fields/debian/rules
@@ -11,8 +11,14 @@ binary-indep:
install -m 644 debian/changelog \
$(tmp)/usr/share/doc/fields/changelog
gzip -9 $(tmp)/usr/share/doc/fields/changelog
- dh_md5sums
- dpkg-gencontrol
+ dh_md5sums -pfields -P$(tmp)
+ dpkg-gencontrol -pfields -P$(tmp)
+ dpkg --build $(tmp) ..
+ rm -rf $(tmp)
+
+ # Create another package with a different version
+ dh_md5sums -panother-version -P$(tmp)
+ dpkg-gencontrol -panother-version -v123.4-0 -P$(tmp)
dpkg --build $(tmp) ..
binary: binary-arch binary-indep
diff --git a/testset/tags.fields b/testset/tags.fields
index 19f112a..9aedaab 100644
--- a/testset/tags.fields
+++ b/testset/tags.fields
@@ -1,8 +1,10 @@
+E: another-version: no-copyright-file
E: fields source: package-uses-debhelper-but-lacks-build-depends
E: fields: debian-changelog-file-missing-or-wrong-name
E: fields: depends-on-python-minimal depends
E: fields: essential-no-not-needed
E: fields: no-copyright-file
+W: another-version: debian-revision-should-not-be-zero 123.4-0
W: fields source: changelog-should-mention-nmu
W: fields source: debian-revision-not-well-formed 1.5-.3
W: fields source: native-package-with-dash-version
--
1.5.4.3
Attachment:
signature.asc
Description: This is a digitally signed message part.