Re: Tags for symbols file checks
On Fri, 2008-06-27 at 09:22 -0700, Russ Allbery wrote:
> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
> > E: pkg-has-symbols-control-file-but-no-actual-shared-libs
>
> Minor nit: dropping "-actual" will make the tag shorter and I don't think
> it changes the meaning.
>
> > E: shlib-missing-in-symbols-control-file
>
> This is the only one that I'd lower to a warning to start, and it's
> possible that we may want to lower it further.
Both agreed.
[...]
> > The final tags indicate a mismatch between the shlibs and symbols
> > control files. I'm tempted to say these should be errors as they're
> > clearly wrong.
> >
> > symbols-declared-but-not-shlib
> > shlib-declared-but-not-symbols
>
> shlib-declared-but-not-symbols may be fine by the same rationale as
> mentioned above. symbols-declared-but-not-shlib is clearly an error.
>
> Isn't shlib-declared-but-not-symbols always going to be redundant with
> shlib-missing-in-symbols-control-file?
Hmmm, yes. Thanks for pointing out what should have been blindingly
obvious. :-)
Adam
Reply to: