[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#485885: zsh: shell-script-fails-syntax-check ./usr/share/zsh/functions/Misc/sticky-note false positive



On Thu, Jun 12, 2008 at 10:50:18AM -0500, Raphael Geissert wrote:
> [no need to CC me, I read the list :)]
> Frank Lichtenheld wrote:
> 
> > On Wed, Jun 11, 2008 at 08:47:49PM -0500, Raphael Geissert wrote:
> >> Attached is a patch that removes zsh from the scripts to check (dash,
> >> ksh, and similar should be safe, as they don't introduce new syntax).
> > 
> > Note that this isn't about syntax additions, the script is executed with
> > zsh after all. It seems though that zsh -n has not quite the same
> > semantics as for all the other shells.
[...]
> [10:30] <Clint> Atomo64: probably #175467
> [10:36] <Atomo64> Clint: but that doesn't clearly explains why there's no
> output while the status code states that there was a problem
> [10:43] <Clint> Atomo64: probably one of the math expressions is returning
> false; what output would you expect from that?
> ..
> 
> So this report should probably be merged with the other one.

Nah, I will block this one by it.

We should decide whether we would prefer to get false-positives or
false-negatives from this, so whether we should remove the check while
we wait for zsh -n to be fixed (which might be a while given the age of
the bug).

Usually we prefer false-negatives over false-positives. So unless there
are any objections I will apply the patch, downgrade this bug to
wishlist and retitle it to something "doesn't check the syntax of zsh
scripts".

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/



Reply to: