[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#485885: zsh: shell-script-fails-syntax-check ./usr/share/zsh/functions/Misc/sticky-note false positive



Package: lintian
Version: 1.24.0
Severity: normal
Tags: patch

$ lintian zsh_4.3.6-4_i386.deb
W: zsh: script-not-executable ./usr/share/zsh/functions/Calendar/calendar_add
E: zsh: 
shell-script-fails-syntax-check ./usr/share/zsh/functions/Misc/run-help
W: zsh: script-not-executable ./usr/share/zsh/functions/Misc/sticky-note
E: zsh: 
shell-script-fails-syntax-check ./usr/share/zsh/functions/Misc/sticky-note
W: zsh: executable-not-elf-or-script ./usr/share/zsh/functions/Misc/mere
W: zsh: executable-not-elf-or-script ./usr/share/zsh/functions/Misc/zed

$ dpkg-query -W --showformat='${Version}\n' zsh
4.3.6-4

$ head -n1 /usr/share/zsh/functions/Misc/{run-help,sticky-note}
==> /usr/share/zsh/functions/Misc/run-help <==
#!/bin/zsh

==> /usr/share/zsh/functions/Misc/sticky-note <==
#!/bin/zsh -fi

Attached is a patch that removes zsh from the scripts to check (dash, ksh, and 
similar should be safe, as they don't introduce new syntax).

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
Index: scripts
===================================================================
--- scripts	(revision 1375)
+++ scripts	(working copy)
@@ -289,7 +289,7 @@
     # Syntax-check most shell scripts, but don't syntax-check scripts that end
     # in .dpatch.  bash -n doesn't stop checking at exit 0 and goes on to blow
     # up on the patch itself.
-    if ($base =~ /^(?:(?:b|d)?a|k|z)?sh$/) {
+    if ($base =~ /^(?:(?:b|d)?a|k)?sh$/) {
 	if (-x "$interpreter" && ! script_is_evil_and_wrong("unpacked/$filename")) {
 	    if ($filename !~ m,\.dpatch$,) {
 		if (check_script_syntax($interpreter, "unpacked/$filename")) {

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: