lintian: r1310 - in trunk: debian lib
Author: djpig
Date: 2008-05-17 00:53:04 +0200 (Sat, 17 May 2008)
New Revision: 1310
Modified:
trunk/debian/changelog
trunk/lib/Util.pm
Log:
* lib/Util.pm:
+ Only require Digest::SHA if the code path is really used.
This makes it unnessesary to install libdigest-sha-perl on
lintian.debian.org for now.
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-05-16 22:47:23 UTC (rev 1309)
+++ trunk/debian/changelog 2008-05-16 22:53:04 UTC (rev 1310)
@@ -21,6 +21,11 @@
during testing and dupload/dput/dak/etc... all will error out
on it anyway. Suggested by martin f krafft. (Closes: #382327)
+ * lib/Util.pm:
+ + [FL] Only require Digest::SHA if the code path is really used.
+ This makes it unnessesary to install libdigest-sha-perl on
+ lintian.debian.org for now.
+
* reporting/html_reports:
+ [FL] Escape $email variable for usage in URI query strings.
Currently it is not used for anything else, so it is most simple
Modified: trunk/lib/Util.pm
===================================================================
--- trunk/lib/Util.pm 2008-05-16 22:47:23 UTC (rev 1309)
+++ trunk/lib/Util.pm 2008-05-16 22:53:04 UTC (rev 1310)
@@ -38,7 +38,6 @@
use FileHandle;
use Pipeline;
use Digest::MD5;
-use Digest::SHA;
# general function to read dpkg control files
# this function can parse output of `dpkg-deb -f', .dsc,
@@ -188,6 +187,7 @@
if ($alg eq 'md5') {
$digest = Digest::MD5->new;
} elsif ($alg =~ /sha(\d+)/) {
+ require Digest::SHA;
$digest = Digest::SHA->new($1);
}
$digest->addfile(*FILE);
Reply to: