lintian: r1047 - in trunk: checks debian testset
Author: rra
Date: 2007-12-05 01:35:25 +0100 (Wed, 05 Dec 2007)
New Revision: 1047
Modified:
trunk/checks/control-file.desc
trunk/checks/fields
trunk/debian/changelog
trunk/testset/tags.binary
trunk/testset/tags.cdbs-test
trunk/testset/tags.debconf
trunk/testset/tags.debug
trunk/testset/tags.dh-test
trunk/testset/tags.diffs
trunk/testset/tags.empty
trunk/testset/tags.etcfiles
trunk/testset/tags.filenames
trunk/testset/tags.foo++
trunk/testset/tags.libbaz
trunk/testset/tags.maintainer-scripts
trunk/testset/tags.manpages
trunk/testset/tags.non-us
trunk/testset/tags.relations
trunk/testset/tags.scripts
Log:
We can't check for a missing Section field in source packages in
checks/fields because that checks the *.dsc file, and Section isn't
one of the fields that is copied into a *.dsc file (see Policy 5.4
and 5.6.5). The Section field of the source stanza of debian/control
is instead used to generate the section information in Files of the
*.changes file.
What Joerg probably really wants is the existing no-section-for-source
tag to be increased to a warning from info. That check is done in
checks/control-file, which checks debian/control in the unpacked source
package instead of the *.dsc file. Do things that way instead.
Modified: trunk/checks/control-file.desc
===================================================================
--- trunk/checks/control-file.desc 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/checks/control-file.desc 2007-12-05 00:35:25 UTC (rev 1047)
@@ -41,16 +41,11 @@
<tt>debian/control</tt> the real file and the other names symlinks to it.
Tag: no-section-field-for-source
-Type: info
+Type: warning
Ref: policy 5.2
Info: The package does not have a "Section:" field in the source package
- section of its control file.
- .
- The Section field is optional for a source package and ignored by the
- Debian archive software, but it's recommended by Policy and not including
- it may cause problems if the package is ever handled by
- archive-processing software that doesn't support pools (private archives,
- for instance).
+ section of its control file. The Section field is required for source
+ packages at the request of the Debian ftp-masters.
Tag: section-category-mismatch
Type: error
Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/checks/fields 2007-12-05 00:35:25 UTC (rev 1047)
@@ -285,7 +285,7 @@
#---- Section
if (not open (FH, '<', "fields/section")) {
- tag "no-section-field", "";
+ tag 'no-section-field' if ($type eq 'binary');
} else {
my $section = <FH>;
close FH;
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/debian/changelog 2007-12-05 00:35:25 UTC (rev 1047)
@@ -17,10 +17,12 @@
the previous entry. Thanks, Thijs Kinkhorst. (Closes: #449257)
* checks/common_data.pm:
+ [RA] Add Dm-Upload-Allowed as a control field. (Closes: #453779)
- * checks/control-file:
+ * checks/control-file{.desc,}:
+ [RA] Diagnose stronger dependencies that imply weaker dependencies,
such as the same dependency in both Depends and Recommends or
Recommends and Suggests. Thanks, Joerg Jaspert. (Closes: #453302)
+ + [RA] Upgrade no-section-field-for-source to warning at the request
+ of Joerg Jaspert.
* checks/control-files:
+ [RA] Add symbols as a known control file for debs and udebs.
* checks/copyright-file:
@@ -46,8 +48,6 @@
'python-package-should-be-section-python',
'perl-package-should-be-section-perl'. Ideas shamelessy
stolen from linda. (Closes: #452839)
- + [HE] Check for Section field in source packages, for which it
- is mandatory. Joerg Jaspert made me do this.
+ [RA] Allow Python dependencies in Build-Depends when using another
variant for calling Python in the clean target. Thanks, Bernd
Zeimetz. (Closes: #444642)
Modified: trunk/testset/tags.binary
===================================================================
--- trunk/testset/tags.binary 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.binary 2007-12-05 00:35:25 UTC (rev 1047)
@@ -44,7 +44,6 @@
W: binary source: debian-rules-uses-pwd line 9
W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1
W: binary source: native-package-with-dash-version
-W: binary source: no-section-field
W: binary source: not-binnmuable-all-depends-any binary-data -> binary
W: binary source: not-binnmuable-any-depends-all binary -> binary-data
W: binary source: substvar-source-version-is-deprecated binary
Modified: trunk/testset/tags.cdbs-test
===================================================================
--- trunk/testset/tags.cdbs-test 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.cdbs-test 2007-12-05 00:35:25 UTC (rev 1047)
@@ -3,5 +3,4 @@
I: cdbs-test source: build-depends-without-arch-dep yada
I: cdbs-test source: package-lacks-versioned-build-depends-on-debhelper 5
W: cdbs-test source: native-package-with-dash-version
-W: cdbs-test source: no-section-field
W: cdbs-test source: package-has-a-duplicate-build-relation cdbs, cdbs
Modified: trunk/testset/tags.debconf
===================================================================
--- trunk/testset/tags.debconf 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.debconf 2007-12-05 00:35:25 UTC (rev 1047)
@@ -16,7 +16,6 @@
W: debconf source: maintainer-script-lacks-debhelper-token debian/debconf-test.postinst
W: debconf source: misnamed-po-file debian/po/sample-file.po
W: debconf source: newer-debconf-templates
-W: debconf source: no-section-field
W: debconf source: out-of-date-standards-version 3.7.2 (current is 3.7.3)
W: debconf source: stray-translated-debconf-templates debconf-test.templates.de
W: debconf source: translated-default-field debconf-test.templates: 67
Modified: trunk/testset/tags.debug
===================================================================
--- trunk/testset/tags.debug 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.debug 2007-12-05 00:35:25 UTC (rev 1047)
@@ -8,7 +8,6 @@
I: debug source: non-standard-architecture ppc64
W: debug source: changelog-should-not-mention-nmu
W: debug source: debian-rules-sets-DH_COMPAT line 5
-W: debug source: no-section-field
W: debug source: out-of-date-standards-version 3.7.0 (current is 3.7.3)
W: hello: binary-without-manpage usr/bin/hello
W: hello: binary-without-manpage usr/bin/hello.dbg
Modified: trunk/testset/tags.dh-test
===================================================================
--- trunk/testset/tags.dh-test 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.dh-test 2007-12-05 00:35:25 UTC (rev 1047)
@@ -6,7 +6,6 @@
W: dh-test source: dh_suidregister-is-obsolete
W: dh-test source: dh_testversion-is-deprecated
W: dh-test source: native-package-with-dash-version
-W: dh-test source: no-section-field
W: dh-test source: out-of-date-standards-version 3.6.2 (current is 3.7.3)
W: dh-test source: package-uses-deprecated-debhelper-compat-version 3
W: dh-test: readme-debian-is-debmake-template
Modified: trunk/testset/tags.diffs
===================================================================
--- trunk/testset/tags.diffs 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.diffs 2007-12-05 00:35:25 UTC (rev 1047)
@@ -19,7 +19,6 @@
W: diffs source: diff-contains-bzr-control-dir .bzr
W: diffs source: diff-contains-cvs-conflict-copy .#binary.c.1.34
W: diffs source: diff-contains-substvars debian/substvars
-W: diffs source: no-section-field
W: diffs: binary-without-manpage usr/bin/diffs
W: diffs: possible-missing-colon-in-closes Closes #1239124
W: diffs: possible-missing-colon-in-closes Closes 456712
Modified: trunk/testset/tags.empty
===================================================================
--- trunk/testset/tags.empty 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.empty 2007-12-05 00:35:25 UTC (rev 1047)
@@ -14,10 +14,9 @@
E: pyempty: maintainer-address-missing empty
E: pyempty: no-copyright-file
E: pyempty: package-has-no-description
-I: empty source: no-section-field-for-source
W: empty source: changelog-should-mention-nmu
W: empty source: maintainer-not-full-name empty
-W: empty source: no-section-field
+W: empty source: no-section-field-for-source
W: empty source: source-nmu-has-incorrect-version-number 2
W: empty-docs: doc-package-should-be-section-doc empty-docs
W: empty-docs: maintainer-not-full-name empty
Modified: trunk/testset/tags.etcfiles
===================================================================
--- trunk/testset/tags.etcfiles 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.etcfiles 2007-12-05 00:35:25 UTC (rev 1047)
@@ -7,7 +7,6 @@
E: etcfiles: md5sums-lists-nonexisting-file usr/bin/foo
E: etcfiles: no-copyright-file
W: etcfiles source: ancient-standards-version 3.5.0 (current is 3.7.3)
-W: etcfiles source: no-section-field
W: etcfiles: changelog-file-not-compressed changelog
W: etcfiles: file-missing-in-md5sums etc/improper-link
W: etcfiles: file-missing-in-md5sums usr/share/doc/etcfiles/changelog
Modified: trunk/testset/tags.filenames
===================================================================
--- trunk/testset/tags.filenames 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.filenames 2007-12-05 00:35:25 UTC (rev 1047)
@@ -29,7 +29,6 @@
E: filenames: use-of-compat-symlink usr/bin/X11/testxbin
E: more-filename-games: no-copyright-file
I: filename-games: no-md5sums-control-file
-I: filenames source: no-section-field-for-source
I: filenames: file-in-usr-something-x11-without-pre-depends usr/include/X11/
I: filenames: no-md5sums-control-file
I: filenames: package-contains-empty-perl-directory usr/share/perl5/
@@ -49,7 +48,7 @@
W: filenames source: diff-contains-svn-conflict-file files/Maelstrom Sounce.r121
W: filenames source: diff-contains-svn-conflict-file files/Maelstrom Sound.mine
W: filenames source: diff-contains-svn-control-dir .svn
-W: filenames source: no-section-field
+W: filenames source: no-section-field-for-source
W: filenames: arch-inventory-file-in-package files/.arch-inventory
W: filenames: bad-permissions-for-ali-file usr/lib/ada/adalib/test.ali
W: filenames: binary-without-manpage usr/X11R6/bin/testxbin2
Modified: trunk/testset/tags.foo++
===================================================================
--- trunk/testset/tags.foo++ 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.foo++ 2007-12-05 00:35:25 UTC (rev 1047)
@@ -16,7 +16,6 @@
E: foo++: wrong-debian-qa-address-set-as-maintainer Lintian Maintainer <debian-qa@lists.debian.org>
I: foo++: no-md5sums-control-file
W: foo++ source: ancient-standards-version 3.1.1 (current is 3.7.3)
-W: foo++ source: no-section-field
W: foo++ source: uploader-address-looks-weird Jeroen van Wolffelaar<jeroen@localhost.localdomain>
W: foo++ source: uploader-not-full-name Frank
W: foo++ source: uploader-not-full-name Josip
Modified: trunk/testset/tags.libbaz
===================================================================
--- trunk/testset/tags.libbaz 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.libbaz 2007-12-05 00:35:25 UTC (rev 1047)
@@ -22,7 +22,6 @@
N: libbaz_1.dsc overrode 4 warnings
W: libbaz source: ancient-standards-version 3.2.1 (current is 3.7.3)
W: libbaz source: changelog-should-mention-nmu
-W: libbaz source: no-section-field
W: libbaz source: package-uses-deprecated-debhelper-compat-version 1
W: libbaz source: source-nmu-has-incorrect-version-number 1
W: libbaz source: substvar-source-version-is-deprecated libbaz2-dev
Modified: trunk/testset/tags.maintainer-scripts
===================================================================
--- trunk/testset/tags.maintainer-scripts 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.maintainer-scripts 2007-12-05 00:35:25 UTC (rev 1047)
@@ -29,7 +29,6 @@
I: maintainer-scripts: output-of-updaterc.d-not-redirected-to-dev-null bar postrm
W: maintainer-scripts source: ancient-standards-version 3.1.1 (current is 3.7.3)
W: maintainer-scripts source: changelog-should-mention-qa
-W: maintainer-scripts source: no-section-field
W: maintainer-scripts source: package-uses-deprecated-debhelper-compat-version 1
W: maintainer-scripts source: qa-upload-has-incorrect-version-number 7-0.1
W: maintainer-scripts: config-does-not-load-confmodule
Modified: trunk/testset/tags.manpages
===================================================================
--- trunk/testset/tags.manpages 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.manpages 2007-12-05 00:35:25 UTC (rev 1047)
@@ -37,7 +37,6 @@
W: manpages source: ancient-standards-version 3.2.1 (current is 3.7.3)
W: manpages source: binary-nmu-debian-revision-in-source 4-0.0.1
W: manpages source: changelog-should-mention-nmu
-W: manpages source: no-section-field
W: manpages source: source-nmu-has-incorrect-version-number 4-0.0.1
W: manpages: binary-nmu-uses-old-version-style 4-0.0.1
W: manpages: binary-without-english-manpage usr/bin/binary-without-english-manpage
Modified: trunk/testset/tags.non-us
===================================================================
--- trunk/testset/tags.non-us 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.non-us 2007-12-05 00:35:25 UTC (rev 1047)
@@ -4,10 +4,9 @@
E: non-us source: section-category-mismatch Package nonfree-crypto-app
E: nonfree-crypto-app: no-copyright-file
E: patented-app: no-copyright-file
-I: non-us source: no-section-field-for-source
I: patented-app: no-md5sums-control-file
I: patented-app: non-us-spelling
W: broken-crypto: unknown-section non-US/admin
W: non-us source: ancient-standards-version 3.1.1 (current is 3.7.3)
-W: non-us source: no-section-field
+W: non-us source: no-section-field-for-source
W: patented-app: latest-debian-changelog-entry-without-new-version
Modified: trunk/testset/tags.relations
===================================================================
--- trunk/testset/tags.relations 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.relations 2007-12-05 00:35:25 UTC (rev 1047)
@@ -36,7 +36,6 @@
I: relations: unknown-field-in-control bugs
I: relations: unknown-field-in-control origin
W: relations source: ancient-standards-version 3.1.1 (current is 3.7.3)
-W: relations source: no-section-field
W: relations source: package-has-a-duplicate-build-relation foo (= 3) [!amd64 !i386], foo (<< 4) [!amd64 !i386]
W: relations source: package-has-a-duplicate-build-relation perl, perl (>= 5.0)
W: relations source: redundant-origin-field
Modified: trunk/testset/tags.scripts
===================================================================
--- trunk/testset/tags.scripts 2007-12-04 21:05:42 UTC (rev 1046)
+++ trunk/testset/tags.scripts 2007-12-05 00:35:25 UTC (rev 1047)
@@ -23,7 +23,6 @@
W: scripts source: dpatch-missing-description 02_i_dont_have_a_description.patch
W: scripts source: maintainer-script-lacks-debhelper-token debian/postinst
W: scripts source: maintainer-script-lacks-debhelper-token debian/postrm
-W: scripts source: no-section-field
W: scripts source: package-uses-deprecated-debhelper-compat-version 1
W: scripts source: source-nmu-has-incorrect-version-number 6
W: scripts source: uses-dh-python-with-no-pycompat
Reply to: