Bug#329953: lintian: bogus compat check

["James R. Van Zandt" <jrvz@comcast.net>]

Package: lintian
Version: 1.23.9
Severity: normal


  $ lintian -i ../pspp_0.4.0-1_i386.changes
  E: pspp source: declares-possibly-conflicting-debhelper-compat-versions 4 4
  N:
  N:   The source package declares the debhelper compatibility version both
  N:   in the debian/control file and in the rules file. If these ever get
  N:   out of synchronisation, the package may not build as expected.
  N:   
  N:   Please refer to the debhelper(7) manual page for more information.
  N:
  ...

There are several problems here:

 - The info message only mentions two places for the debhelper compat
   version number, which in this case both have the same number.
 - As of version 4, the DH_COMPAT environment variable is deprecated -
   but the message doesn't mention that.
 - It is now debian/compat and debian/rules that should match.

Please change the info to something like this:

  E: pspp source: declares-possibly-conflicting-debhelper-compat-versions 4 4
  N:   The source package declares the debhelper compatibility version
  N:   both in the debian/compat file and debian/control file. If these
  N:   ever get out of synchronisation, the package may not build as
  N:   expected.  
  N:   
  N:   As of version 4, the DH_COMPAT environment variable is
  N:   deprecated, so any command in debian/rules that sets it should
  N:   be deleted.
  N:   
  N:   Please refer to the debhelper(7) manual page for more information.
  N:

Better yet, separate into two tests with messages like this:

  E: pspp source: declares-possibly-conflicting-debhelper-compat-versions 4 4
  N:   The source package declares the debhelper compatibility version
  N:   both in the debian/compat file and debian/control file. If these
  N:   ever get out of synchronisation, the package may not build as
  N:   expected.  
  N:   
  N:   Please refer to the debhelper(7) manual page for more information.
  N:

  E: pspp source: declares-deprecated-environment-variable-DH_COMPAT
  N:   As of version 4, the DH_COMPAT environment variable is
  N:   deprecated, so any command in debian/rules that sets it should
  N:   be deleted.
  N:   
  N:   Please refer to the debhelper(7) manual page for more information.
  N:

		- Jim Van Zandt



-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'oldstable'), (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.4.29
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages lintian depends on:
ii  binutils                   2.16.1-2      The GNU assembler, linker and bina
ii  diffstat                   1.39-1        produces graph of changes introduc
ii  file                       4.12-1        Determines file type using "magic"
ii  gettext                    0.14.5-2      GNU Internationalization utilities
ii  intltool-debian            0.30+20040213 Help i18n of RFC822 compliant conf
ii  man-db                     2.4.3-1       The on-line manual pager
ii  perl [libdigest-md5-perl]  5.8.7-4       Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information