Bug#308569: marked as done (lintian: warn for update-inetd/adduser in maint script without depends)
Your message dated Sun, 10 Jul 2005 11:32:27 -0400
with message-id <E1Drdn9-000117-00@newraff.debian.org>
and subject line Bug#308569: fixed in lintian 1.23.10
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 11 May 2005 06:40:25 +0000
>From rra@stanford.edu Tue May 10 23:40:25 2005
Return-path: <rra@stanford.edu>
Received: from smtp1.stanford.edu [171.67.16.123]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DVktN-0006pe-00; Tue, 10 May 2005 23:40:25 -0700
Received: from windlord.stanford.edu (windlord.Stanford.EDU [171.64.19.147])
by smtp1.Stanford.EDU (8.12.11/8.12.11) with SMTP id j4B6eO4e008325
for <submit@bugs.debian.org>; Tue, 10 May 2005 23:40:25 -0700
Received: (qmail 12089 invoked by uid 1000); 11 May 2005 06:40:24 -0000
Message-ID: <20050511064024.12088.qmail@windlord.stanford.edu>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Russ Allbery <rra@stanford.edu>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: lintian: warn for update-inetd/adduser in maint script without depends
X-Mailer: reportbug 3.8
Date: Tue, 10 May 2005 23:40:24 -0700
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: lintian
Version: 1.23.8
Severity: wishlist
Tags: patch
The testing being done for the sarge release has revealed that a fair
number of packages use update-inetd in maintainer scripts without a
dependency on netbase or adduser without a dependency on adduser. The
following tested patch adds a check for this.
I'm not sure if more should be said about when this warning may be
ignorable (such as when the invocation is conditional), or if brevity is
the soul of wit.
diff -ru lintian-1.23.8/checks/scripts lintian-1.23.8.new/checks/scripts
--- lintian-1.23.8/checks/scripts 2005-01-14 09:19:55.000000000 -0800
+++ lintian-1.23.8.new/checks/scripts 2005-05-10 23:29:43.000000000 -0700
@@ -396,7 +396,7 @@
open C, "$filename"
or fail("cannot open maintainer script $filename for reading: $!");
- my ($warned_tmp, $warned_killall);
+ my ($warned_tmp, $warned_killall, $warned_netbase, $warned_adduser);
my $cat_string = "";
while (<C>) {
@@ -477,6 +477,20 @@
if (m,\bsuidregister\b,) {
tag "suidregister-used-in-maintainer-script", "$file";
}
+ if (m,\bupdate-inetd\b, && !$warned_netbase) {
+ my $type = $deps{'netbase'};
+ unless ($type and ($type eq 'depends' or $type eq 'pre-depends')) {
+ tag "maintainer-script-needs-depends-on-netbase", "$file";
+ $warned_netbase = 1;
+ }
+ }
+ if (m,\badduser\b, && !$warned_adduser) {
+ my $type = $deps{'adduser'};
+ unless ($type and ($type eq 'depends' or $type eq 'pre-depends')) {
+ tag "maintainer-script-needs-depends-on-adduser", "$file";
+ $warned_adduser = 1;
+ }
+ }
if ($file eq 'postrm') {
if (m,update\-alternatives \-\-remove,) {
tag "update-alternatives-remove-called-in-postrm", "";
diff -ru lintian-1.23.8/checks/scripts.desc lintian-1.23.8.new/checks/scripts.desc
--- lintian-1.23.8/checks/scripts.desc 2005-01-14 13:09:42.000000000 -0800
+++ lintian-1.23.8.new/checks/scripts.desc 2005-05-10 23:19:19.000000000 -0700
@@ -616,6 +616,16 @@
command 'dpkg-statoverride' gives admins more flexibility. Please see
the documentation of suidmanager and dpkg-statoverride for details.
+Tag: maintainer-script-needs-depends-on-netbase
+Type: warning
+Info: This script calls update-inetd, but the package does not depend or
+ pre-depend on netbase, which provides it.
+
+Tag: maintainer-script-needs-depends-on-adduser
+Type: warning
+Info: This script calls adduser, but the package does not depend or
+ pre-depend on the adduser package.
+
Tag: update-alternatives-remove-called-in-postrm
Type: warning
Info: 'update-alternatives --remove <alternative> foo' is called in the
-- System Information:
Debian Release: 3.1
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.30
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Versions of packages lintian depends on:
ii binutils 2.15-5 The GNU assembler, linker and bina
ii diffstat 1.39-1 produces graph of changes introduc
ii file 4.12-1 Determines file type using "magic"
ii gettext 0.14.1-10 GNU Internationalization utilities
ii intltool-debian 0.30+20040213 Help i18n of RFC822 compliant conf
ii man-db 2.4.2-21 The on-line manual pager
ii perl [libdigest-md5-perl] 5.8.4-8 Larry Wall's Practical Extraction
-- no debconf information
---------------------------------------
Received: (at 308569-close) by bugs.debian.org; 10 Jul 2005 15:39:39 +0000
>From katie@ftp-master.debian.org Sun Jul 10 08:39:39 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Drdu7-00089d-00; Sun, 10 Jul 2005 08:39:39 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1Drdn9-000117-00; Sun, 10 Jul 2005 11:32:27 -0400
From: Marc 'HE' Brockschmidt <he@debian.org>
To: 308569-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#308569: fixed in lintian 1.23.10
Message-Id: <E1Drdn9-000117-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 10 Jul 2005 11:32:27 -0400
Delivered-To: 308569-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 3
Source: lintian
Source-Version: 1.23.10
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:
lintian_1.23.10.dsc
to pool/main/l/lintian/lintian_1.23.10.dsc
lintian_1.23.10.tar.gz
to pool/main/l/lintian/lintian_1.23.10.tar.gz
lintian_1.23.10_all.deb
to pool/main/l/lintian/lintian_1.23.10_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 308569@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Marc 'HE' Brockschmidt <he@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 10 Jul 2005 16:20:42 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.10
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Marc 'HE' Brockschmidt <he@debian.org>
Description:
lintian - Debian package checker
Closes: 88340 253405 294894 295093 299792 307639 308569 309203 309220 311471 317049
Changes:
lintian (1.23.10) unstable; urgency=low
.
* The "Ah, it's LinuxTag and I still have free time!" release
.
* debian/control:
+ [HE] Updated description to say that we're calibrated for Policy
version 3.6.2. As the changes between 3.6.{1,2} aren't stuff we
(can) check, this is actually true! (Closes: #317049)
.
* testset/runtests:
+ [HE] Fix symlinking of original tarballs to allow run directories
outside the lintian source tree.
.
* checks/control-file
+ [HE] Check for duplicated fields. (Closes: #299792)
.
* checks/fields:
+ [HE] Change unknown-architecture a bit: We don't complain about
"known" non-standard archs (like amd64, ppc64, *bsd-i386) and only
print out an info message for those. (Closes: #253405, #311471)
.
* checks/files:
+ [HE] Allow backupninja configuration files in /etc/backup.d/ to be
0600. (Closes: #307639)
.
* checks/scripts:
+ [HE] Allow Scripts in /etc/Xsession.d/ to be not executable, as they're
not directly called, but only sourced. (Closes: #309203)
+ [HE] Check for use of adduser and update-inetd and warn if the package
has no (pre-)dependency on adduser/netbase. Patch by Russ Allbery,
thanks for the work. (Closes: #308569)
+ [HE] Check for use of "." as a deprecated separator between user and
group names in chown call. (Closes: #88340)
+ [HE] Fix to work $interpreter-script-but-no-$pkg-dep with more than one
dependency if needed. First use case is depending on build-essential
to provide /usr/bin/make. (Closes: #294894)
+ [HE] Add lefty as a valid interpreter and check for a correct dependency
on graphviz. (Closes: #295093)
.
* checks/shared-libs:
+ [HE] Don't allow non-PIC shared libraries. This conforms to the new
etch release policy. Thanks for the report and patch to Kurt Roeckx
<kurt@roeckx.be>. (Closes: #309220)
Files:
8f474879521b2c86c26f8f8e781a45cb 780 devel optional lintian_1.23.10.dsc
3d9a59329a9d11dde13b3cb861426c9f 257919 devel optional lintian_1.23.10.tar.gz
24609039d9928f3bfe669ae726e7762b 226022 devel optional lintian_1.23.10_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iEYEARECAAYFAkLROX0ACgkQmO5zOp3h7rHeNQCfTlc4MqCLmaGk/266WDfC+Pwv
1IEAn1Pup/ADIiIeghQYeMe+LKtNpufg
=VVoz
-----END PGP SIGNATURE-----
Reply to: