[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Patch incomplete



Hi Colin and others,

The patch for UTF-8 in changelog is not working alright all the times.

First, somewhere there are dependencies missing, as lintian installs
fine on my woody system, but the test fails ungracefully.

[jeroen@richard]~/public_html/sw/debian/EXPERIMENTAL/dists/sid/lintian$ lintian lintian_1.22.9-0.1*.deb
Unknown open() mode '<:utf8' at /usr/share/lintian/checks/changelog-file line 192.
internal error: cannot run changelog-file check on package lintian
N: Skipping check of binary package lintian
[jeroen@richard]~/public_html/sw/debian/EXPERIMENTAL/dists/sid/lintian$

Second, not both source and binary packages are checked.

Third, it doesn't indicate the line which has the wrong character, which
would be a neat feature.

Fourth, perl barks out errors on stderr about failed conversions, which
should be intercepted. I don't know how to do that.

What about using iconv -f UTF-8? By counting lines of it, you know which
line failed, and iconv with UTF-8 support is in libc6, for at least woody and
up (probably older).

If you could change the patch so that it works correctly on woody (or
have the correct dependencies, although having lintian easy installable
also on older systems is something that should be tried to maintain),
and doesn't give cruft to stderr, please do so. Otherwise, I think I'll
either rewrite it to use iconv, or back it out temporarily, so that
lintian can be uploaded.

--Jeroen

-- 
Jeroen van Wolffelaar
Jeroen@wolffelaar.nl (also for Jabber & MSN; ICQ: 33944357)
http://Jeroen.A-Eskwadraat.nl



Reply to: