[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

upstream license patched in debian package



Package: sl-modem-source
Version: 2.9.9d+e-pre2-2
|Severity: grave

+sl-modem (2.9.9d+e-pre2-1) unstable; urgency=low
+
+  * New upstream pre-release (closes: #327588)
+  * added sv.po from Daniel Nylander (closes: #330436)
+  * slmodemd.1 manpage from Erik Schanze (closes: #335369)
+  * defining URB_ASYNC_UNLINK if not set, needed by recent kernels
+  * applied patch for class/simple_class transition from Gentoo lists with
+    some fixes (closes: #325799)
+  * changed the MODULE_LICENSE string to "Dual BSD/GPL" since the license
+    is actually a BSD license clone (closes: #327545)
+ * not including the old hotplug script, merged its code into the init script
+    and added an udev rules file to run it. Needs real testing with a
+    Smartlink USB modem which I do not have (closes: #338740)
+  * disabled the "PCI device grabbing warning" code which caused
+    OOpses on 2.6.15
+
+ -- Eduard Bloch <blade@debian.org>  Sun, 15 Jan 2006 14:49:45 +0100

I believe that modification of upstream license is terribly wrong.

+--- sl-modem-2.9.9d+e-pre2.orig/drivers/amrmo_init.c
++++ sl-modem-2.9.9d+e-pre2/drivers/amrmo_init.c
+@@ -692,7 +704,8 @@
+ + MODULE_AUTHOR("Smart Link Ltd."); + MODULE_DESCRIPTION("SmartLink HAMR5600,SmartPCI56/561 based modem driver");
+-MODULE_LICENSE("Smart Link Ltd.");
++//MODULE_LICENSE("Smart Link Ltd.");
++MODULE_LICENSE("Dual BSD/GPL");
+
How can you justify this change?

I believe it is offensive to the linux kernel developers to circumvent the license exportation of the smartlink module in this manner.

drivers/amrlibs.o and modem/dsplibs.o are binary blobs. drivers/st7554.c (ST7554 USB Smart Link Soft Modem driver) depends on these binary blobs.

In recent linux kernel code, some advanced functions require a GPL compatible license, drivers/base/class.c:-

|****EXPORT_SYMBOL_GPL(class_create_file);
EXPORT_SYMBOL_GPL(class_remove_file);
EXPORT_SYMBOL_GPL(class_register);
EXPORT_SYMBOL_GPL(class_unregister);
EXPORT_SYMBOL_GPL(class_get);
EXPORT_SYMBOL_GPL(class_put);
EXPORT_SYMBOL_GPL(class_create);
EXPORT_SYMBOL_GPL(class_destroy);

EXPORT_SYMBOL_GPL(class_device_register);
EXPORT_SYMBOL_GPL(class_device_unregister);
EXPORT_SYMBOL_GPL(class_device_initialize);
EXPORT_SYMBOL_GPL(class_device_add);
EXPORT_SYMBOL_GPL(class_device_del);
EXPORT_SYMBOL_GPL(class_device_get);
EXPORT_SYMBOL_GPL(class_device_put);
EXPORT_SYMBOL_GPL(class_device_create);
EXPORT_SYMBOL_GPL(class_device_destroy);
EXPORT_SYMBOL_GPL(class_device_create_file);
EXPORT_SYMBOL_GPL(class_device_remove_file);
EXPORT_SYMBOL_GPL(class_device_create_bin_file);
EXPORT_SYMBOL_GPL(class_device_remove_bin_file);

EXPORT_SYMBOL_GPL(class_interface_register);
EXPORT_SYMBOL_GPL(class_interface_unregister);

The above mentioned modification of the Smartlink license circumvents this requirement.
**|
Thanks, Kel.
|



Reply to: