[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: review new debconf template pkg-mysql/mariadb-10.0



On 2016-09-01 00:08, Justin B Rye wrote:
> Dieter Adriaenssens wrote:
>> A new debconf template (mariadb-server-10.0/feedback_plugin) will be
>> added to package mariadb-server-10.0 (the full template can be found
>> here [0]) :
>>
>> _Description: Enable the feedback plugin?
> 
> Is it the feedback plugin or the Feedback plugin?  Oh, actually the
> MariaDB website calls it the User Feedback plugin.  Maybe it should be
> "User Feedback" within the long description and just "Feedback" here
> in the synopsis.
> 
>>  The Feedback plugin is designed to collect and, optionally,
>>  upload configuration and usage information to Mariadb.org,
>>  or to any other configured URL.
> 
> No need for the convoluted phrasing; it doesn't collect stuff to a URL
> and optionally upload it, it collects stuff and optionally uploads it
> to a URL.
> 
> The organisation is "the MariaDB Foundation"; the URL (or at least its
> domain name part) is "mariadb.org".
> 
>    The User Feedback plugin is designed to collect configuration and usage
>    information and optionally upload it to mariadb.org, or to any other
>    configured URL.
> 
>>  .
>>  The collected data will be used to steer engineering and community development
>>  of MariaDB in the right directions. It is used to continuously improve the product.
> 
> (Can you steer in more than one direction?  Over time, I suppose... or
> maybe it's a very elastic catamaran.)
> 
> The repeated use of "used to" might be worth avoiding.
> 
>    The collected data will be used to steer engineering and community
>    development of MariaDB in the right directions, in order to continuously
>    improve the product.
> 
>>  The plugin gathers only non-sensitive information, no personal data or
>>  anything that would enable tracking of the user will be sent.
> 
> That's a run-on sentence; fix it by just upgrading the comma to a
> semicolon.
> 
>>  .
>>  See https://mariadb.org/about/statistics/
>>  for more information on how to configure the Feedback plugin and
>>  collected MariaDB usage statistics.
> 
> I first interpreted this as "information on how to configure [...]
> collected statistics".  Probably all that's needed to avoid that is:
> 
>    See https://mariadb.org/about/statistics/ for more information on how to
>    configure the User Feedback plugin, as well as collected MariaDB usage
>    statistics.
> 
> Or to be quite sure:
> 
>    See https://mariadb.org/about/statistics/ for collected MariaDB usage
>    statistics, and more information on how to configure the User Feedback
>    plugin.
> 
> But I'll stick with the first version in my patch.
> 

Hi Justin,

Thanks for reviewing the User Feedback Plugin template description.

Your changes are added in commit
https://anonscm.debian.org/git/pkg-mysql/mariadb-10.0.git/commit/?h=bug_808419_feedback_plugin&id=4d3257196ef263ac50e463dc93a1fce60eae3801

Kind regards,
Dieter

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: