[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://postsrsd/{postsrsd.templates}



Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
>  Template: postsrsd/domain
>  Type: string
>  _Description: Local domain name to use as origin:

I suppose that could be "local" in a slightly scarequotesy sense, but
it's probably best not to bring this up.

> - Addresses of forwarded mail are rewritten to originate from this domain
> - name. This domain should have an SPF policy that allows mail to be send
> - from this mailserver.
> + Please enter the domain name to use in rewritten addresses of
> + forwarded mail. This domain's SPF policy should allow this mail server to send mail.
>   .
> - Without a configured local domain name, postsrsd will not start.
> \ No newline at end of file
> + Without a configured local domain name, postsrsd will not start.
> 
> The long text should avoid referencing the synopsis in debconf
> templates, hence the proposed rewrite.

(That is, the first line can't refer back to "this domain".  Also,
s/be send/be sent/.)
 
> I'm not entirely happy with my proposal because it probably doesn't
> make clear that the policy allowing mail sending with rewritten
> addresses is a "remote" policy and that "this mail server" is the
> current machine.
> 
> Still, I don't find a good way to make this clear without ending up
> with a clumsy text.

How about just:

    Please enter the domain name to use in rewritten addresses of
    forwarded mail. The SPF policy for that domain should allow this
    mail server to send mail.

In the control file:
> Package: postsrsd
> Architecture: any
> Depends: ${shlibs:Depends}, ${misc:Depends}, debconf
> Description: Sender Rewriting Scheme (SRS) lookup table for Postfix
>  PostSRSd provides Sender Rewriting Scheme (SRS) support for Postfix via
>  TCP-based lookup tables. SRS is needed if your mail server acts as a forwarder,
>  and the mail originates from a server with Sender Policy Framework (SPF)
>  enabled.

Well, there's a somewhat useless use of "-based", but nothing worth
changing.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru postsrsd-1.2.pristine/debian/postsrsd.templates postsrsd-1.2/debian/postsrsd.templates
--- postsrsd-1.2.pristine/debian/postsrsd.templates	2015-08-25 00:07:53.000000000 +0100
+++ postsrsd-1.2/debian/postsrsd.templates	2015-09-11 13:09:00.044253292 +0100
@@ -1,8 +1,8 @@
 Template: postsrsd/domain
 Type: string
 _Description: Local domain name to use as origin:
- Addresses of forwarded mail are rewritten to originate from this domain
- name. This domain should have an SPF policy that allows mail to be send
- from this mailserver.
+ Please enter the domain name to use in rewritten addresses of
+ forwarded mail. The SPF policy for that domain should allow this
+ mail server to send mail.
  .
- Without a configured local domain name, postsrsd will not start.
\ No newline at end of file
+ Without a configured local domain name, postsrsd will not start.
Template: postsrsd/domain
Type: string
_Description: Local domain name to use as origin:
 Please enter the domain name to use in rewritten addresses of
 forwarded mail. The SPF policy for that domain should allow this
 mail server to send mail.
 .
 Without a configured local domain name, postsrsd will not start.
Source: postsrsd
Section: mail
Priority: optional
Maintainer: Oxan van Leeuwen <oxan@oxanvanleeuwen.nl>
Build-Depends: debhelper (>= 9), cmake, dh-systemd, dh-apparmor, po-debconf
Standards-Version: 3.9.6
Homepage: https://github.com/roehling/postsrsd
Vcs-Git: git://anonscm.debian.org/collab-maint/postsrsd.git
Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/postsrsd.git

Package: postsrsd
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf
Description: Sender Rewriting Scheme (SRS) lookup table for Postfix
 PostSRSd provides Sender Rewriting Scheme (SRS) support for Postfix via
 TCP-based lookup tables. SRS is needed if your mail server acts as a forwarder,
 and the mail originates from a server with Sender Policy Framework (SPF)
 enabled.

Reply to: