Please find, for review, the debconf templates and packages descriptions for the postsrsd source package. This review will last from Friday, September 11, 2015 to Monday, September 21, 2015. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, a summary will be sent to the review bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- postsrsd.old/debian/postsrsd.templates 2015-09-03 07:13:31.994161616 +0200 +++ postsrsd/debian/postsrsd.templates 2015-09-11 07:17:15.005356791 +0200 @@ -1,8 +1,7 @@ Template: postsrsd/domain Type: string _Description: Local domain name to use as origin: - Addresses of forwarded mail are rewritten to originate from this domain - name. This domain should have an SPF policy that allows mail to be send - from this mailserver. + Please enter the domain name to use in rewritten addresses of + forwarded mail. This domain's SPF policy should allow this mail server to send mail. . - Without a configured local domain name, postsrsd will not start. \ No newline at end of file + Without a configured local domain name, postsrsd will not start. The long text should avoid referencing the synopsis in debconf templates, hence the proposed rewrite. I'm not entirely happy with my proposal because it probably doesn't make clear that the policy allowing mail sending with rewritten addresses is a "remote" policy and that "this mail server" is the current machine. Still, I don't find a good way to make this clear without ending up with a clumsy text. --
Template: postsrsd/domain Type: string _Description: Local domain name to use as origin: Please enter the domain name to use in rewritten addresses of forwarded mail. This domain's SPF policy should allow this mail server to send mail. . Without a configured local domain name, postsrsd will not start.
--- postsrsd.old/debian/postsrsd.templates 2015-09-03 07:13:31.994161616 +0200 +++ postsrsd/debian/postsrsd.templates 2015-09-11 07:17:15.005356791 +0200 @@ -1,8 +1,7 @@ Template: postsrsd/domain Type: string _Description: Local domain name to use as origin: - Addresses of forwarded mail are rewritten to originate from this domain - name. This domain should have an SPF policy that allows mail to be send - from this mailserver. + Please enter the domain name to use in rewritten addresses of + forwarded mail. This domain's SPF policy should allow this mail server to send mail. . - Without a configured local domain name, postsrsd will not start. \ No newline at end of file + Without a configured local domain name, postsrsd will not start.
Source: postsrsd
Section: mail
Priority: optional
Maintainer: Oxan van Leeuwen <oxan@oxanvanleeuwen.nl>
Build-Depends: debhelper (>= 9), cmake, dh-systemd, dh-apparmor, po-debconf
Standards-Version: 3.9.6
Homepage: https://github.com/roehling/postsrsd
Vcs-Git: git://anonscm.debian.org/collab-maint/postsrsd.git
Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/postsrsd.git
Package: postsrsd
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf
Description: Sender Rewriting Scheme (SRS) lookup table for Postfix
PostSRSd provides Sender Rewriting Scheme (SRS) support for Postfix via
TCP-based lookup tables. SRS is needed if your mail server acts as a forwarder,
and the mail originates from a server with Sender Policy Framework (SPF)
enabled.
Attachment:
signature.asc
Description: Digital signature