Re: Review of new lintian tag
On Sat, Jul 5, 2014 at 8:50 PM, victory <victory.deb@gmail.com> wrote:
> On Sat, 05 Jul 2014 19:47:43 +0000
> bastien ROUCARIES wrote:
>
>> diff --git a/checks/deb-format.desc b/checks/deb-format.desc
>> index 8a4f214..d090707 100644
>> --- a/checks/deb-format.desc
>> +++ b/checks/deb-format.desc
>> @@ -56,3 +56,15 @@ Info: The data tarball of this udeb package is
>> +Tag: uses-deprecated-compression-for-data-tarball
>> +Severity: important
>> +Certainty: certain
>> +Info: The data portion of this binary package uses a deprecated compression
>> + format. Creating such binary packages is supported by dpkg-deb for now,
>> + although a warning is emitted for lzma since dpkg 1.16.4 and for bzip2
>> + since dpkg 1.17.7, but will eventually be disallowed, although extraction
>> + will keep being supported for the foreseeable future.
>
> this was too complicated for me.
>
> read 3 times and thought it is
> Creating such binary ... although ...
> and
> but will eventually ... although ...
>
> can the latter be divided?
Do not know I am not a native speaker so it is up to you. Yes it could
be divised but I do not know where.
>> diff --git a/checks/files.desc b/checks/files.desc
>> index e515259..dd9a9ee 100644
>> --- a/checks/files.desc
>> +++ b/checks/files.desc
>> @@ -1497,6 +1499,19 @@ Info: The arch all pkg-config file contains a reference to a multi-arch path.
>> Another likely cause is using debhelper 9 or newer (thus enabling
>> multi-arch paths by default) on a package without multi-arch support.
>> The usual cure in this case is to update it for multi-arch.
>> + .
>> + Last but not least, this file could contains a reference to a cross
>
> contain
Done
>> +Tag: pkg-config-bad-directive
>> +Severity: serious
>> +Certainty: possible
>> +Info: The pkg-config file contains a wrong directive.
>> + .
>> + The following file include a wrong directive. This could lead to
>
> files or includes
includes
Done
>> diff --git a/checks/init.d.desc b/checks/init.d.desc
>> index 84a8c7a..29dbbf4 100644
>> --- a/checks/init.d.desc
>> +++ b/checks/init.d.desc
>> +Tag: init.d-script-depends-on-all-virtual-facility
>> +Severity: serious
>> +Certainty: possible
>> +Info: The given init script declares a dependency on $all
>> + virtual facility.
>> + .
>> + This virtual facility is reserved to local script.
>> + .
>> + Moreover using $all in more than one init.d script is
>> + totally broken.
>> +Ref: http://wiki.debian.org/LSBInitScripts
>
> wiki should use https?
Done
>
> --
> victory
> no need to CC me :-)
> http://userscripts.org/scripts/show/102724 0.0.1.4
> http://userscripts.org/scripts/show/163846 0.0.1
> http://userscripts.org/scripts/show/163848 0.0.1
Reply to: