Please find, for review, the debconf templates and packages descriptions for the dovecot source package. This review will last from Tuesday, October 15, 2013 to Friday, October 25, 2013. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, a summary will be sent to the review bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- dovecot.old/debian/dovecot-core.templates 2013-10-06 08:22:06.491851895 +0200 +++ dovecot/debian/dovecot-core.templates 2013-10-15 08:04:53.037656342 +0200 @@ -1,23 +1,25 @@ Template: dovecot-core/ssl-cert-exists -Type: note -_Description: SSL certificate in the wrong location - You already have SSL certs for dovecot. However you should move them out of - /etc/ssl and into /etc/dovecot and update the configuration in - /etc/dovecot/conf.d/10-ssl.conf accordingly. +Type: error +_Description: Wrong location for SSL certificates + This machine uses SSL certificates for Dovecot. These certificates + should be moved from /etc/ssl to /etc/dovecot and Dovecots's + configuration file (/etc/dovecot/conf.d/10-ssl.conf) should be updated + accordingly. . - See /usr/share/doc/dovecot-core/README.Debian.gz for details." + Please read /usr/share/doc/dovecot-core/README.Debian.gz for details. Make this template an "error". Anyway, debconf notes are Evil..:) Also avoid personnalization ("You have"). Template: dovecot-core/create-ssl-cert Type: boolean Default: true _Description: Create a self-signed SSL certificate? - In order to use IMAP or POP3 over SSL/TLS you will need a certificate. It - looks like you don't have one. If this is incorrect, answer false to this - question. Make sure you have the proper configuration for your certificate - set up in /etc/dovecot/conf.d/10-ssl.conf. + An SSL certificate is needed in order to use IMAP or POP3 over SSL/TLS. + No such certificate was found. . - Answer true if you would like dovecot to create a self-signed certificate for - you. + Please choose whether you want to create one now. This will then be a + self-signed certificate. + . + If you choose not to create a certificate, please adapt Dovecot's + configuration file (/etc/dovecot/conf.d/10-ssl.conf). I partly rephrased this template to avoid making reference to debconf widgets (true/false, which might be "Yes" or "No" or "Oui" or "Non" or acheckbow, etc.). Also split into paragraphs to make it clearer. Template: dovecot-core/ssl-cert-name Type: string @@ -25,4 +27,4 @@ _Description: Host name: Please enter the host name to use in the SSL certificate. . - It will become the 'commonName' field of the generated SSL certificate. + It will become the "commonName" field of the generated SSL certificate. Just use double quotes as we do everywhere else. --- dovecot.old/debian/control 2013-10-06 08:22:06.491851895 +0200 +++ dovecot/debian/control 2013-10-15 08:10:12.338572494 +0200 @@ -16,7 +16,7 @@ Provides: dovecot-common Replaces: dovecot-common (<< 1:2.0.14-2~), mailavenger (<< 0.8.1-4) Breaks: dovecot-common (<< 1:2.0.14-2~), mailavenger (<< 0.8.1-4) -Description: secure mail server that supports mbox, maildir, dbox and mdbox mailboxes +Description: secure mail server with mbox/maildir/dbox/mdbox - core files Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be I just changed the synopsis everywhere to use a common part and a variable part (recommended practice). I'm balanced about keeping the "with mbox/maildir/dbox/mdbox". It makes the synopsis fairly long. How abou tjust "secure mail server" (which is not completly true as Dovecot is not a full server from the end user POV, not including an SMTP server)
Template: dovecot-core/ssl-cert-exists Type: error _Description: Wrong location for SSL certificates This machine uses SSL certificates for Dovecot. These certificates should be moved from /etc/ssl to /etc/dovecot and Dovecots's configuration file (/etc/dovecot/conf.d/10-ssl.conf) should be updated accordingly. . Please read /usr/share/doc/dovecot-core/README.Debian.gz for details. Template: dovecot-core/create-ssl-cert Type: boolean Default: true _Description: Create a self-signed SSL certificate? An SSL certificate is needed in order to use IMAP or POP3 over SSL/TLS. No such certificate was found. . Please choose whether you want to create one now. This will then be a self-signed certificate. . If you choose not to create a certificate, please adapt Dovecot's configuration file (/etc/dovecot/conf.d/10-ssl.conf). Template: dovecot-core/ssl-cert-name Type: string Default: localhost _Description: Host name: Please enter the host name to use in the SSL certificate. . It will become the "commonName" field of the generated SSL certificate.
--- dovecot.old/debian/dovecot-core.templates 2013-10-06 08:22:06.491851895 +0200 +++ dovecot/debian/dovecot-core.templates 2013-10-15 08:13:08.751498642 +0200 @@ -1,23 +1,25 @@ Template: dovecot-core/ssl-cert-exists -Type: note -_Description: SSL certificate in the wrong location - You already have SSL certs for dovecot. However you should move them out of - /etc/ssl and into /etc/dovecot and update the configuration in - /etc/dovecot/conf.d/10-ssl.conf accordingly. +Type: error +_Description: Wrong location for SSL certificates + This machine uses SSL certificates for Dovecot. These certificates + should be moved from /etc/ssl to /etc/dovecot and Dovecots's + configuration file (/etc/dovecot/conf.d/10-ssl.conf) should be updated + accordingly. . - See /usr/share/doc/dovecot-core/README.Debian.gz for details." + Please read /usr/share/doc/dovecot-core/README.Debian.gz for details. Template: dovecot-core/create-ssl-cert Type: boolean Default: true _Description: Create a self-signed SSL certificate? - In order to use IMAP or POP3 over SSL/TLS you will need a certificate. It - looks like you don't have one. If this is incorrect, answer false to this - question. Make sure you have the proper configuration for your certificate - set up in /etc/dovecot/conf.d/10-ssl.conf. + An SSL certificate is needed in order to use IMAP or POP3 over SSL/TLS. + No such certificate was found. . - Answer true if you would like dovecot to create a self-signed certificate for - you. + Please choose whether you want to create one now. This will then be a + self-signed certificate. + . + If you choose not to create a certificate, please adapt Dovecot's + configuration file (/etc/dovecot/conf.d/10-ssl.conf). Template: dovecot-core/ssl-cert-name Type: string @@ -25,4 +27,4 @@ _Description: Host name: Please enter the host name to use in the SSL certificate. . - It will become the 'commonName' field of the generated SSL certificate. + It will become the "commonName" field of the generated SSL certificate. --- dovecot.old/debian/control 2013-10-06 08:22:06.491851895 +0200 +++ dovecot/debian/control 2013-10-15 08:10:12.338572494 +0200 @@ -16,7 +16,7 @@ Provides: dovecot-common Replaces: dovecot-common (<< 1:2.0.14-2~), mailavenger (<< 0.8.1-4) Breaks: dovecot-common (<< 1:2.0.14-2~), mailavenger (<< 0.8.1-4) -Description: secure mail server that supports mbox, maildir, dbox and mdbox mailboxes +Description: secure mail server with mbox/maildir/dbox/mdbox - core files Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -29,7 +29,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Replaces: dovecot-common (<< 1:2.0.14-2~) Breaks: dovecot-common (<< 1:2.0.14-2~) -Description: header files for the dovecot mail server +Description: secure mail server with mbox/maildir/dbox/mdbox - header files Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -42,7 +42,7 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Provides: imap-server -Description: secure IMAP server that supports mbox, maildir, dbox and mdbox mailboxes +Description: secure mail server with mbox/maildir/dbox/mdbox - IMAP daemon Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -54,7 +54,7 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Provides: pop3-server -Description: secure POP3 server that supports mbox, maildir, dbox and mdbox mailboxes +Description: secure mail server with mbox/maildir/dbox/mdbox - POP3 daemon Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -67,7 +67,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Replaces: dovecot-common (<< 1:2.0.14-2~) Breaks: dovecot-common (<< 1:2.0.14-2~) -Description: secure LMTP server for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - LMTP server Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -80,7 +80,7 @@ Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), dovecot-sieve (= ${binary:Version}), ucf (>= 2.0020) Replaces: dovecot-common (<< 1:2.0.14-2~) Breaks: dovecot-common (<< 1:2.0.14-2~) -Description: secure ManageSieve server for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - ManageSieve server Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -91,7 +91,7 @@ Package: dovecot-pgsql Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) -Description: PostgreSQL support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - PostgreSQL support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -102,7 +102,7 @@ Package: dovecot-mysql Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) -Description: MySQL support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - MySQL support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -113,7 +113,7 @@ Package: dovecot-sqlite Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) -Description: SQLite support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - SQLite support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -124,7 +124,7 @@ Package: dovecot-ldap Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) -Description: LDAP support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - LDAP support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -135,7 +135,7 @@ Package: dovecot-gssapi Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) -Description: GSSAPI authentication support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - GSSAPI support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -146,7 +146,7 @@ Package: dovecot-sieve Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) -Description: sieve filters support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - Sieve filters support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -157,7 +157,7 @@ Package: dovecot-solr Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) -Description: Solr full text search support for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - Solr support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be @@ -170,7 +170,7 @@ Priority: extra Architecture: any Depends: ${misc:Depends}, dovecot-core (= ${binary:Version}) -Description: debug symbols for Dovecot +Description: secure mail server with mbox/maildir/dbox/mdbox - debug symbols Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be --- dovecot.old/debian/changelog 2013-10-06 08:22:06.487851799 +0200 +++ dovecot/debian/changelog 2013-10-07 07:08:22.617616805 +0200 @@ -1,3 +1,11 @@ +dovecot (1:2.2.5-2) UNRELEASED; urgency=low + + * Debconf templates and debian/control reviewed by the debian-l10n- + english team as part of the Smith review project. Closes: #725615 + * [Debconf translation updates] + + -- Christian Perrier <bubulle@debian.org> Mon, 07 Oct 2013 07:08:22 +0200 + dovecot (1:2.2.5-1) experimental; urgency=low [ Micah Anderson ] * [a0035bf] New upstream version 2.2.5
Source: dovecot Section: mail Priority: optional Maintainer: Dovecot Maintainers <jaldhar-dovecot@debian.org> Uploaders: Jaldhar H. Vyas <jaldhar@debian.org>, Fabio Tranchitella <kobold@debian.org>, Joel Johnson <mrjoel@lixil.net>, Marco Nenciarini <mnencia@debian.org> Build-Depends: debhelper (>= 7.2.3~), dpkg-dev (>= 1.16.1), pkg-config, libssl-dev, libpam0g-dev, libldap2-dev, libpq-dev, libmysqlclient-dev, libsqlite3-dev, libsasl2-dev, zlib1g-dev, libkrb5-dev, drac-dev (>= 1.12-5), libbz2-dev, libdb-dev, libcurl4-gnutls-dev, libexpat-dev, libwrap0-dev, dh-systemd, po-debconf, lsb-release Standards-Version: 3.9.4 Homepage: http://dovecot.org/ Vcs-Git: git://git.debian.org/git/collab-maint/dovecot.git Vcs-Browser: http://git.debian.org/?p=collab-maint/dovecot.git Package: dovecot-core Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, libpam-runtime (>= 0.76-13.1), openssl, adduser, ucf (>= 2.0020) Suggests: ntp, dovecot-gssapi, dovecot-sieve, dovecot-pgsql, dovecot-mysql, dovecot-sqlite, dovecot-ldap, dovecot-imapd, dovecot-pop3d, dovecot-lmtpd, dovecot-managesieved, dovecot-solr Provides: dovecot-common Replaces: dovecot-common (<< 1:2.0.14-2~), mailavenger (<< 0.8.1-4) Breaks: dovecot-common (<< 1:2.0.14-2~), mailavenger (<< 0.8.1-4) Description: secure mail server with mbox/maildir/dbox/mdbox - core files Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains the dovecot main server and its command line utility. Package: dovecot-dev Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Replaces: dovecot-common (<< 1:2.0.14-2~) Breaks: dovecot-common (<< 1:2.0.14-2~) Description: secure mail server with mbox/maildir/dbox/mdbox - header files Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains header files needed to compile plugins for the dovecot mail server. Package: dovecot-imapd Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Provides: imap-server Description: secure mail server with mbox/maildir/dbox/mdbox - IMAP daemon Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains the dovecot IMAP server. Package: dovecot-pop3d Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Provides: pop3-server Description: secure mail server with mbox/maildir/dbox/mdbox - POP3 daemon Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains the dovecot POP3 server. Package: dovecot-lmtpd Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Replaces: dovecot-common (<< 1:2.0.14-2~) Breaks: dovecot-common (<< 1:2.0.14-2~) Description: secure mail server with mbox/maildir/dbox/mdbox - LMTP server Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains the dovecot LMTP server. Package: dovecot-managesieved Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), dovecot-sieve (= ${binary:Version}), ucf (>= 2.0020) Replaces: dovecot-common (<< 1:2.0.14-2~) Breaks: dovecot-common (<< 1:2.0.14-2~) Description: secure mail server with mbox/maildir/dbox/mdbox - ManageSieve server Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains the dovecot ManageSieve server. Package: dovecot-pgsql Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Description: secure mail server with mbox/maildir/dbox/mdbox - PostgreSQL support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides PostgreSQL support for Dovecot. Package: dovecot-mysql Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Description: secure mail server with mbox/maildir/dbox/mdbox - MySQL support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides MySQL support for Dovecot. Package: dovecot-sqlite Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Description: secure mail server with mbox/maildir/dbox/mdbox - SQLite support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides SQLite support for Dovecot. Package: dovecot-ldap Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Description: secure mail server with mbox/maildir/dbox/mdbox - LDAP support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides LDAP support for Dovecot. Package: dovecot-gssapi Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Description: secure mail server with mbox/maildir/dbox/mdbox - GSSAPI support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides GSSAPI authentication support for Dovecot. Package: dovecot-sieve Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}), ucf (>= 2.0020) Description: secure mail server with mbox/maildir/dbox/mdbox - Sieve filters support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides sieve filters support for Dovecot. Package: dovecot-solr Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, dovecot-core (= ${binary:Version}) Description: secure mail server with mbox/maildir/dbox/mdbox - Solr support Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package provides Solr full text search support for Dovecot. Package: dovecot-dbg Section: debug Priority: extra Architecture: any Depends: ${misc:Depends}, dovecot-core (= ${binary:Version}) Description: secure mail server with mbox/maildir/dbox/mdbox - debug symbols Dovecot is a mail server whose major goals are security and extreme reliability. It tries very hard to handle all error conditions and verify that all data is valid, making it nearly impossible to crash. It should also be pretty fast, extensible, and portable. . This package contains debug symbols for Dovecot.
Attachment:
signature.asc
Description: Digital signature