[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://tt-rss/{templates}



Justin B Rye wrote:
> Christian PERRIER wrote:
>> Your review should be sent as an answer to this mail.
> [...]
>>  Default: http://yourserver/tt-rss/
> 
> It seems to me we should have some explicit policy rule against
> defaults like this: http://[CENSORED].com really exists.  If you need
> a dummy hostname that's guaranteed not to have a webserver, what's
> wrong with example.org?  Or we could even make the default localhost,
> so that it'll work for testing before you set it live.  But none of
> this is in my patch.

Indeed, while it reached d-l-e as
https://lists.debian.org/debian-l10n-english/2013/05/msg00040.html
just mentioning yourserver dot com seems to have got my mail
rejected by the BTS spam-filters, so probably we ought to fix it.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru old/control new/control
--- old/control	2013-05-04 19:06:38.925090442 +0100
+++ new/control	2013-05-12 11:49:33.020217580 +0100
@@ -36,13 +36,12 @@
  feeling as close to a real desktop application as possible.
  .
  Feature list:
- .
-   - Server-side application, user only needs a web browser
-   - Support for RSS, RDF, Atom feeds
-   - Streamlined interface using AJAX
-   - Authentication for reading protected feeds
-   - OPML import/export
-   - Feed Aggregation
-   - Keyboard Shortcuts
-   - Content Filtering
-   - JSON-based RPC API
+  * server-side application - user only needs a web browser;
+  * support for RSS, RDF, Atom feeds;
+  * streamlined interface using AJAX;
+  * authentication for reading protected feeds;
+  * OPML import/export;
+  * feed aggregation;
+  * keyboard shortcuts;
+  * content filtering;
+  * JSON-based RPC API.
diff -ru old/templates new/templates
--- old/templates	2013-05-04 19:06:37.625125933 +0100
+++ new/templates	2013-05-12 12:09:23.593159926 +0100
@@ -7,10 +7,13 @@
 
 Template: tt-rss/self_url_path
 Type: string
-Default: http://yourserver/tt-rss/
+Default: http://localhost/tt-rss/
 _Description: Full URL of the tt-rss installation:
- Full URL of the tt-rss installation. This should be set to the
- location of tt-rss directory, e.g. http://yourserver/tt-rss/.
- You need to set this option correctly otherwise several features
- including PUSH, bookmarklets and browser integration will not
+ Please enter the URL that should be used to access tt-rss
+ with a web browser.
+ .
+ This should include the location of the tt-rss directory - for
+ instance http://example.org/tt-rss/.
+ If this is not set correctly, several features,
+ including PUSH, bookmarklets, and browser integration, will not
  work properly.
Template: tt-rss/reconfigure-webserver
Type: multiselect
__Choices: apache2, lighttpd
_Description: Web server to reconfigure automatically:
 Please choose the web server that should be automatically configured
 to run Tiny Tiny RSS.

Template: tt-rss/self_url_path
Type: string
Default: http://localhost/tt-rss/
_Description: Full URL of the tt-rss installation:
 Please enter the URL that should be used to access tt-rss
 with a web browser.
 .
 This should include the location of the tt-rss directory - for
 instance http://example.org/tt-rss/.
 If this is not set correctly, several features,
 including PUSH, bookmarklets, and browser integration, will not
 work properly.
Source: tt-rss
Section: web
Priority: optional
Maintainer: Sebastian Reichel <sre@debian.org>
Uploaders: Marcelo Jorge Vieira (metal) <metal@debian.org>
Build-Depends: debhelper (>= 8),
               libjs-prototype (= 1.7.0-2)
Standards-Version: 3.9.4
Homepage: http://tt-rss.org
Vcs-Git: git://git.debian.org/collab-maint/tt-rss.git
Vcs-Browser: http://git.debian.org/?p=collab-maint/tt-rss.git;a=summary

Package: tt-rss
Built-Using: prototypejs (= 1.7.0-2)
Architecture: all
Depends: ${misc:Depends},
         dbconfig-common,
         libjs-dojo-core (>= 1.5.0),
         libjs-dojo-dijit (>= 1.5.0),
         libjs-scriptaculous,
         libphp-phpmailer,
         libphp-simplepie,
         php-gettext,
         libapache2-mod-php5 (>= 5.3.0) | php5-cgi (>= 5.3.0) | php5 (>= 5.3.0),
         php5-cli,
         php5-mysql | php5-pgsql,
         phpqrcode
Recommends: apache2 | lighttpd | httpd,
            php5-gd
Suggests: mysql-server | postgresql,
          mysql-client | postgresql-client,
          sphinxsearch,
          php-apc
Description: web-based news feed (RSS/Atom) aggregator
 Tiny Tiny RSS is designed to allow you to read news from any location, while
 feeling as close to a real desktop application as possible.
 .
 Feature list:
  * server-side application - user only needs a web browser;
  * support for RSS, RDF, Atom feeds;
  * streamlined interface using AJAX;
  * authentication for reading protected feeds;
  * OPML import/export;
  * feed aggregation;
  * keyboard shortcuts;
  * content filtering;
  * JSON-based RPC API.

Reply to: