[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://tt-rss/{templates}



Please find, for review, the debconf templates and packages descriptions for the tt-rss source package.

This review will last from Sunday, May 12, 2013 to Wednesday, May 22, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- tt-rss.old/debian/templates	2013-05-04 19:54:56.221516454 +0200
+++ tt-rss/debian/templates	2013-05-12 11:50:00.462129314 +0200
@@ -9,8 +9,11 @@
 Type: string
 Default: http://yourserver/tt-rss/
 _Description: Full URL of the tt-rss installation:
- Full URL of the tt-rss installation. This should be set to the
- location of tt-rss directory, e.g. http://yourserver/tt-rss/.
- You need to set this option correctly otherwise several features
+ Please enter the URL that should be used to access tt-rss
+ with a web browser.
+ .
+ This should be set to the
+ location of tt-rss directory, for instance http://<yourserver>/tt-rss/.
+ If this is not set correctly, several features,
  including PUSH, bookmarklets and browser integration will not
  work properly.

The first sentence was not a sentence, which is highly discouraged in
long descriptions. Make it separate from the rest and use the writing
style wesuggested to other packages.

I'm not entirely happy with the second paragraph as it is slightly
wrong to say that "it should be set to the location of the directory"
as what's expected is a URL.

--- tt-rss.old/debian/control	2013-05-04 19:54:56.221516454 +0200
+++ tt-rss/debian/control	2013-05-12 11:47:59.098573950 +0200
@@ -36,13 +36,12 @@
  feeling as close to a real desktop application as possible.
  .
  Feature list:
- .
-   - Server-side application, user only needs a web browser
-   - Support for RSS, RDF, Atom feeds
-   - Streamlined interface using AJAX
-   - Authentication for reading protected feeds
-   - OPML import/export
-   - Feed Aggregation
-   - Keyboard Shortcuts
-   - Content Filtering
-   - JSON-based RPC API
+  - Server-side application, user only needs a web browser;
+  - support for RSS, RDF, Atom feeds;
+  - streamlined interface using AJAX;
+  - authentication for reading protected feeds;
+  - OPML import/export;
+  - feed aggregation;
+  - keyboard shortcuts;
+  - content filtering;
+  - JSON-based RPC API.

Standardize the bulleted list with semi-colons and a bit less capitalization.
Template: tt-rss/reconfigure-webserver
Type: multiselect
__Choices: apache2, lighttpd
_Description: Web server to reconfigure automatically:
 Please choose the web server that should be automatically configured
 to run Tiny Tiny RSS.

Template: tt-rss/self_url_path
Type: string
Default: http://yourserver/tt-rss/
_Description: Full URL of the tt-rss installation:
 Please enter the URL that should be used to access tt-rss
 with a web browser.
 .
 This should be set to the
 location of tt-rss directory, for instance http://<yourserver>/tt-rss/.
 If this is not set correctly, several features,
 including PUSH, bookmarklets and browser integration will not
 work properly.
--- tt-rss.old/debian/templates	2013-05-04 19:54:56.221516454 +0200
+++ tt-rss/debian/templates	2013-05-12 12:11:06.866556011 +0200
@@ -9,8 +9,11 @@
 Type: string
 Default: http://yourserver/tt-rss/
 _Description: Full URL of the tt-rss installation:
- Full URL of the tt-rss installation. This should be set to the
- location of tt-rss directory, e.g. http://yourserver/tt-rss/.
- You need to set this option correctly otherwise several features
+ Please enter the URL that should be used to access tt-rss
+ with a web browser.
+ .
+ This should be set to the
+ location of tt-rss directory, for instance http://<yourserver>/tt-rss/.
+ If this is not set correctly, several features,
  including PUSH, bookmarklets and browser integration will not
  work properly.
--- tt-rss.old/debian/control	2013-05-04 19:54:56.221516454 +0200
+++ tt-rss/debian/control	2013-05-12 11:47:59.098573950 +0200
@@ -36,13 +36,12 @@
  feeling as close to a real desktop application as possible.
  .
  Feature list:
- .
-   - Server-side application, user only needs a web browser
-   - Support for RSS, RDF, Atom feeds
-   - Streamlined interface using AJAX
-   - Authentication for reading protected feeds
-   - OPML import/export
-   - Feed Aggregation
-   - Keyboard Shortcuts
-   - Content Filtering
-   - JSON-based RPC API
+  - Server-side application, user only needs a web browser;
+  - support for RSS, RDF, Atom feeds;
+  - streamlined interface using AJAX;
+  - authentication for reading protected feeds;
+  - OPML import/export;
+  - feed aggregation;
+  - keyboard shortcuts;
+  - content filtering;
+  - JSON-based RPC API.
--- tt-rss.old/debian/changelog	2013-05-04 19:54:56.221516454 +0200
+++ tt-rss/debian/changelog	2013-05-04 20:00:54.871987929 +0200
@@ -1,3 +1,11 @@
+tt-rss (1.7.8+dfsg-3) UNRELEASED; urgency=low
+
+  * Debconf templates and debian/control reviewed by the debian-l10n-
+    english team as part of the Smith review project. Closes: #706774
+  * [Debconf translation updates]
+
+ -- Christian Perrier <bubulle@debian.org>  Sat, 04 May 2013 20:00:54 +0200
+
 tt-rss (1.7.8+dfsg-2) unstable; urgency=low
 
   * Fix broken phpqrcode symlink for package upgrades
Source: tt-rss
Section: web
Priority: optional
Maintainer: Sebastian Reichel <sre@debian.org>
Uploaders: Marcelo Jorge Vieira (metal) <metal@debian.org>
Build-Depends: debhelper (>= 8),
               libjs-prototype (= 1.7.0-2)
Standards-Version: 3.9.4
Homepage: http://tt-rss.org
Vcs-Git: git://git.debian.org/collab-maint/tt-rss.git
Vcs-Browser: http://git.debian.org/?p=collab-maint/tt-rss.git;a=summary

Package: tt-rss
Built-Using: prototypejs (= 1.7.0-2)
Architecture: all
Depends: ${misc:Depends},
         dbconfig-common,
         libjs-dojo-core (>= 1.5.0),
         libjs-dojo-dijit (>= 1.5.0),
         libjs-scriptaculous,
         libphp-phpmailer,
         libphp-simplepie,
         php-gettext,
         libapache2-mod-php5 (>= 5.3.0) | php5-cgi (>= 5.3.0) | php5 (>= 5.3.0),
         php5-cli,
         php5-mysql | php5-pgsql,
         phpqrcode
Recommends: apache2 | lighttpd | httpd,
            php5-gd
Suggests: mysql-server | postgresql,
          mysql-client | postgresql-client,
          sphinxsearch,
          php-apc
Description: web-based news feed (RSS/Atom) aggregator
 Tiny Tiny RSS is designed to allow you to read news from any location, while
 feeling as close to a real desktop application as possible.
 .
 Feature list:
  - Server-side application, user only needs a web browser;
  - support for RSS, RDF, Atom feeds;
  - streamlined interface using AJAX;
  - authentication for reading protected feeds;
  - OPML import/export;
  - feed aggregation;
  - keyboard shortcuts;
  - content filtering;
  - JSON-based RPC API.

Attachment: signature.asc
Description: Digital signature


Reply to: