[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://screen/{templates}



Christian PERRIER wrote:
> Before going into details, I'd like to mention that templates seem a
> bit lengthy to me (they certainly don't fit on a 80x25 screen and need
> to be scrolled down which is not always obvious with
> debconf). Shortening them would be nice, but I didn't find any good
> idea for that..:-)

My versions shorter, but I think it's mostly just because I'm not
wrapping at 70 columns.

>  Template: screen/410-upgrade
>  Type: error
> -_Description: Previous screen binary has been copied to /tmp/screen-4.0.3
> +_Description: Warning: upgrading screen with an active session
> 
> OK, this is a little bit against my common habits but I think that
> using "Warning: blah" here is a good idea.
> 
> I prefer the "title" to be something more general about what we're
> talking about and not something that just looks like an informative
> message. We *really* need users to read this.

Yes, looks good.
 
>   GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
>   started by GNU Screen 4.0.3.

Drop "currently", unless we really expect stable-update versions of
Screen 4.1.0 to be backward-compatible.

s/speak/communicate/

If they're sessions started by Screen, they're obviously Screen
sessions, and we don't need all this GNU branding.

    GNU Screen 4.1.0 can't communicate with sessions started by Screen 4.0.3.

>   .
> - On this system there seems to be at least one GNU Screen session
> + On this system, there seems to be at least one GNU Screen session
>   running, possibly the one you run this upgrade in.

s/you run/you are running/.  Could we try smushing together these two
short paragraphs?

    There seems to be at least one GNU Screen session running on this system;
    possibly the one you are running this upgrade in. However, GNU Screen 4.1.0
    can't communicate with sessions started by Screen 4.0.3.

>   To be able to reconnect to your running GNU Screen session after the
>   new screen package has been unpacked, you'll need to call the old
>   screen binary instead of the new one. For that purpose, the old
>   screen binary has been copied to /tmp/screen-4.0.3. You can call it
>   like this: "/tmp/screen-4.0.3 -rd"

Squeezing:

    To reconnect to a running GNU Screen session after the new version has been
    unpacked, you'll need to call the old screen binary instead of the new one,
    so a copy has been made which can be invoked as "/tmp/screen-4.0.3 -rd".

>   In case your /tmp/ is a separate mount point and mounted with the
>   nosuid or noexec options, you may need to copy it to some other place
>   beforehand, e.g. to /root/, before calling it. It's permissions
>   should be 2755 (-rwxr-sr-x) and it should belong to the user root and
>   group utmp.

Squeezing (especially the "before"s) and fixing a rogue apostrophe:

    If your /tmp/ is a separate mount point mounted with the nosuid or noexec
    options, you may need to copy it to somewhere else (such as /root) before
    calling it. Its permissions should be 2755 (-rwxr-sr-x) and it should
    belong to the user root and group utmp.

> @@ -21,11 +21,11 @@
>  
>  Template: screen/403-copy-failed
>  Type: error
> -_Description: Copying current screen binary to /tmp/screen-4.0.3 failed.
> +_Description: Failed copy of screen binary to /tmp/screen-4.0.3
> 
> Following debconf templates writing guidelines and turn this into a "title".
> 
>   GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
>   started by GNU Screen 4.0.3.
>   .
> - On this system there seems to be at least one GNU Screen session
> + On this system, there seems to be at least one GNU Screen session
>   running, possibly the one you run this upgrade in.

Changes as before.

>  .
>  To be able to reconnect to your running GNU Screen session after the
>  new screen package has been unpacked, you'll need to call the old
>  screen binary instead of the new one. For that purpose, it has been
>  tried to copy the old screen binary to /tmp/screen-4.0.3, but
>  unfortunately this failed.

"It has been tried to copy" doesn't work.  Why not just:

   To reconnect to a running GNU Screen session after the new version has been
   unpacked, you'll need to call the old screen binary instead of the new one.
   However, the attempt to copy it to /tmp/screen-4.0.3 has failed.

(Last minute thought: does the second error message ever appear
without being preceded by the first one?)

 * * *

Moving on to the control file: okay, this is a good package
description already, so none of the following is more than wishlist. 

> Description: terminal multiplexor with VT100/ANSI terminal emulation
                                 ^
Google says "Did you mean: multiplexer?"

>  screen is a terminal multiplexor that runs several separate "screens" on a
   ^                             ^
s/screen/GNU Screen/ - an appropriate place for branding, given that
it also saves us from initial lowercase.

>  single physical character-based terminal.  Each virtual terminal emulates a
>  DEC VT100 plus several ANSI X3.64 and ISO 2022 functions.  Screen sessions
>  can be detached and resumed later on a different terminal.

(While I'm here I'm imposing d-l-e "house style" single-spacing.)

>  .
>  Screen also supports a whole slew of other features.  Some of these are:

Just say "including".

>  configurable input and output translation, serial port support, configurable
>  logging, multi-user support, and utf8 charset support.

Failing to support UTF-8 by default has been a bug since at least
Lenny, so drop that one.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Source: screen
Section: misc
Priority: optional
Maintainer: Axel Beckert <abe@debian.org>
Uploaders: Jan Christoph Nordholz <hesso@pool.math.tu-berlin.de>
Standards-Version: 3.9.3
Build-Depends: libncursesw5-dev, texinfo, libpam0g-dev, debhelper (>> 7), dh-autoreconf, dpkg-dev (>= 1.16.1~)
Homepage: http://savannah.gnu.org/projects/screen
Vcs-Git: git://anonscm.debian.org/collab-maint/screen.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/screen.git

Package: screen
Architecture: any
Pre-Depends: debconf
Depends: ${shlibs:Depends}, ${misc:Depends}
Suggests: iselect (>= 1.4.0-1) | screenie | byobu
Description: terminal multiplexer with VT100/ANSI terminal emulation
 GNU Screen is a terminal multiplexer that runs several separate "screens" on
 a single physical character-based terminal. Each virtual terminal emulates a
 DEC VT100 plus several ANSI X3.64 and ISO 2022 functions. Screen sessions
 can be detached and resumed later on a different terminal.
 .
 Screen also supports a whole slew of other features, including configurable
 input and output translation, serial port support, configurable logging,
 and multi-user support.
Template: screen/410-upgrade
Type: error
_Description: Warning: upgrading screen with an active session
 There seems to be at least one GNU Screen session running on this system;
 possibly the one you are running this upgrade in. However, GNU Screen 4.1.0
 can't communicate with sessions started by Screen 4.0.3.
 .
 To reconnect to a running GNU Screen session after the new version has been
 unpacked, you'll need to call the old screen binary instead of the new one,
 so a copy has been made which can be invoked as "/tmp/screen-4.0.3 -rd".
 .
 If your /tmp/ is a separate mount point mounted with the nosuid or noexec
 options, you may need to copy it to somewhere else (such as /root) before
 calling it. Its permissions should be 2755 (-rwxr-sr-x) and it should belong
 to the user root and group utmp.

Template: screen/403-copy-failed
Type: error
_Description: Failed copy of screen binary to /tmp/screen-4.0.3
 There seems to be at least one GNU Screen session running on this system;
 possibly the one you are running this upgrade in. However, GNU Screen 4.1.0
 can't communicate with sessions started by Screen 4.0.3.
 .
 To reconnect to a running GNU Screen session after the new version has been
 unpacked, you'll need to call the old screen binary instead of the new one.
 However, the attempt to copy it to /tmp/screen-4.0.3 has failed.
diff -ru screen-4.1.0~20120320gitdb59704.pristine/debian/control screen-4.1.0~20120320gitdb59704/debian/control
--- screen-4.1.0~20120320gitdb59704.pristine/debian/control	2012-06-10 03:44:04.000000000 +0100
+++ screen-4.1.0~20120320gitdb59704/debian/control	2012-06-13 19:26:28.411392204 +0100
@@ -14,12 +14,12 @@
 Pre-Depends: debconf
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: iselect (>= 1.4.0-1) | screenie | byobu
-Description: terminal multiplexor with VT100/ANSI terminal emulation
- screen is a terminal multiplexor that runs several separate "screens" on a
- single physical character-based terminal.  Each virtual terminal emulates a
- DEC VT100 plus several ANSI X3.64 and ISO 2022 functions.  Screen sessions
+Description: terminal multiplexer with VT100/ANSI terminal emulation
+ GNU Screen is a terminal multiplexer that runs several separate "screens" on
+ a single physical character-based terminal. Each virtual terminal emulates a
+ DEC VT100 plus several ANSI X3.64 and ISO 2022 functions. Screen sessions
  can be detached and resumed later on a different terminal.
  .
- Screen also supports a whole slew of other features.  Some of these are:
- configurable input and output translation, serial port support, configurable
- logging, multi-user support, and utf8 charset support.
+ Screen also supports a whole slew of other features, including configurable
+ input and output translation, serial port support, configurable logging,
+ and multi-user support.
diff -ru screen-4.1.0~20120320gitdb59704.pristine/debian/templates screen-4.1.0~20120320gitdb59704/debian/templates
--- screen-4.1.0~20120320gitdb59704.pristine/debian/templates	2012-06-10 15:38:02.000000000 +0100
+++ screen-4.1.0~20120320gitdb59704/debian/templates	2012-06-13 19:22:53.447392184 +0100
@@ -1,35 +1,26 @@
 Template: screen/410-upgrade
 Type: error
-_Description: Previous screen binary has been copied to /tmp/screen-4.0.3
- GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
- started by GNU Screen 4.0.3.
+_Description: Warning: upgrading screen with an active session
+ There seems to be at least one GNU Screen session running on this system;
+ possibly the one you are running this upgrade in. However, GNU Screen 4.1.0
+ can't communicate with sessions started by Screen 4.0.3.
  .
- On this system there seems to be at least one GNU Screen session
- running, possibly the one you run this upgrade in.
+ To reconnect to a running GNU Screen session after the new version has been
+ unpacked, you'll need to call the old screen binary instead of the new one,
+ so a copy has been made which can be invoked as "/tmp/screen-4.0.3 -rd".
  .
- To be able to reconnect to your running GNU Screen session after the
- new screen package has been unpacked, you'll need to call the old
- screen binary instead of the new one. For that purpose, the old
- screen binary has been copied to /tmp/screen-4.0.3. You can call it
- like this: "/tmp/screen-4.0.3 -rd"
- .
- In case your /tmp/ is a separate mount point and mounted with the
- nosuid or noexec options, you may need to copy it to some other place
- beforehand, e.g. to /root/, before calling it. It's permissions
- should be 2755 (-rwxr-sr-x) and it should belong to the user root and
- group utmp.
+ If your /tmp/ is a separate mount point mounted with the nosuid or noexec
+ options, you may need to copy it to somewhere else (such as /root) before
+ calling it. Its permissions should be 2755 (-rwxr-sr-x) and it should belong
+ to the user root and group utmp.
 
 Template: screen/403-copy-failed
 Type: error
-_Description: Copying current screen binary to /tmp/screen-4.0.3 failed.
- GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
- started by GNU Screen 4.0.3.
- .
- On this system there seems to be at least one GNU Screen session
- running, possibly the one you run this upgrade in.
+_Description: Failed copy of screen binary to /tmp/screen-4.0.3
+ There seems to be at least one GNU Screen session running on this system;
+ possibly the one you are running this upgrade in. However, GNU Screen 4.1.0
+ can't communicate with sessions started by Screen 4.0.3.
  .
- To be able to reconnect to your running GNU Screen session after the
- new screen package has been unpacked, you'll need to call the old
- screen binary instead of the new one. For that purpose, it has been
- tried to copy the old screen binary to /tmp/screen-4.0.3, but
- unfortunately this failed.
+ To reconnect to a running GNU Screen session after the new version has been
+ unpacked, you'll need to call the old screen binary instead of the new one.
+ However, the attempt to copy it to /tmp/screen-4.0.3 has failed.

Reply to: