[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://screen/{templates}



Please find, for review, the debconf templates for the screen source package.

(I didn't work on package descriptions as, being close the the freeze
and release, I prefer focusing on immediately i18n'ed material)

This review will last from Wednesday, June 13, 2012 to Saturday, June 23, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

Before going into details, I'd like to mention that templates seem a
bit lengthy to me (they certainly don't fit on a 80x25 screen and need
to be scrolled down which is not always obvious with
debconf). Shortening them would be nice, but I didn't find any good
idea for that..:-)


--- screen.old/debian/templates	2012-06-13 07:47:30.361159077 +0200
+++ screen/debian/templates	2012-06-13 19:04:59.619623352 +0200
@@ -1,10 +1,10 @@
 Template: screen/410-upgrade
 Type: error
-_Description: Previous screen binary has been copied to /tmp/screen-4.0.3
+_Description: Warning: upgrading screen with an active session

OK, this is a little bit against my common habits but I think that
using "Warning: blah" here is a good idea.

I prefer the "title" to be something more general about what we're
talking about and not something that just looks like an informative
message. We *really* need users to read this.

  GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
  started by GNU Screen 4.0.3.
  .
- On this system there seems to be at least one GNU Screen session
+ On this system, there seems to be at least one GNU Screen session
  running, possibly the one you run this upgrade in.
  .
  To be able to reconnect to your running GNU Screen session after the

Just adding a comma to where it belongs (imho)

@@ -21,11 +21,11 @@
 
 Template: screen/403-copy-failed
 Type: error
-_Description: Copying current screen binary to /tmp/screen-4.0.3 failed.
+_Description: Failed copy of screen binary to /tmp/screen-4.0.3

Following debconf templates writing guidelines and turn this into a "title".

  GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
  started by GNU Screen 4.0.3.
  .
- On this system there seems to be at least one GNU Screen session
+ On this system, there seems to be at least one GNU Screen session
  running, possibly the one you run this upgrade in.
  .
  To be able to reconnect to your running GNU Screen session after the

And same comma..:)

-- 


Template: screen/410-upgrade
Type: error
_Description: Warning: upgrading screen with an active session
 GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
 started by GNU Screen 4.0.3.
 .
 On this system, there seems to be at least one GNU Screen session
 running, possibly the one you run this upgrade in.
 .
 To be able to reconnect to your running GNU Screen session after the
 new screen package has been unpacked, you'll need to call the old
 screen binary instead of the new one. For that purpose, the old
 screen binary has been copied to /tmp/screen-4.0.3. You can call it
 like this: "/tmp/screen-4.0.3 -rd"
 .
 In case your /tmp/ is a separate mount point and mounted with the
 nosuid or noexec options, you may need to copy it to some other place
 beforehand, e.g. to /root/, before calling it. It's permissions
 should be 2755 (-rwxr-sr-x) and it should belong to the user root and
 group utmp.

Template: screen/403-copy-failed
Type: error
_Description: Failed copy of screen binary to /tmp/screen-4.0.3
 GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
 started by GNU Screen 4.0.3.
 .
 On this system, there seems to be at least one GNU Screen session
 running, possibly the one you run this upgrade in.
 .
 To be able to reconnect to your running GNU Screen session after the
 new screen package has been unpacked, you'll need to call the old
 screen binary instead of the new one. For that purpose, it has been
 tried to copy the old screen binary to /tmp/screen-4.0.3, but
 unfortunately this failed.
--- screen.old/debian/templates	2012-06-13 07:47:30.361159077 +0200
+++ screen/debian/templates	2012-06-13 19:04:59.619623352 +0200
@@ -1,10 +1,10 @@
 Template: screen/410-upgrade
 Type: error
-_Description: Previous screen binary has been copied to /tmp/screen-4.0.3
+_Description: Warning: upgrading screen with an active session
  GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
  started by GNU Screen 4.0.3.
  .
- On this system there seems to be at least one GNU Screen session
+ On this system, there seems to be at least one GNU Screen session
  running, possibly the one you run this upgrade in.
  .
  To be able to reconnect to your running GNU Screen session after the
@@ -21,11 +21,11 @@
 
 Template: screen/403-copy-failed
 Type: error
-_Description: Copying current screen binary to /tmp/screen-4.0.3 failed.
+_Description: Failed copy of screen binary to /tmp/screen-4.0.3
  GNU Screen 4.1.0 currently can't speak with GNU Screen sessions
  started by GNU Screen 4.0.3.
  .
- On this system there seems to be at least one GNU Screen session
+ On this system, there seems to be at least one GNU Screen session
  running, possibly the one you run this upgrade in.
  .
  To be able to reconnect to your running GNU Screen session after the
Source: screen
Section: misc
Priority: optional
Maintainer: Axel Beckert <abe@debian.org>
Uploaders: Jan Christoph Nordholz <hesso@pool.math.tu-berlin.de>
Standards-Version: 3.9.3
Build-Depends: libncursesw5-dev, texinfo, libpam0g-dev, debhelper (>> 7), dh-autoreconf, dpkg-dev (>= 1.16.1~)
Homepage: http://savannah.gnu.org/projects/screen
Vcs-Git: git://anonscm.debian.org/collab-maint/screen.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/screen.git

Package: screen
Architecture: any
Pre-Depends: debconf
Depends: ${shlibs:Depends}, ${misc:Depends}
Suggests: iselect (>= 1.4.0-1) | screenie | byobu
Description: terminal multiplexor with VT100/ANSI terminal emulation
 screen is a terminal multiplexor that runs several separate "screens" on a
 single physical character-based terminal.  Each virtual terminal emulates a
 DEC VT100 plus several ANSI X3.64 and ISO 2022 functions.  Screen sessions
 can be detached and resumed later on a different terminal.
 .
 Screen also supports a whole slew of other features.  Some of these are:
 configurable input and output translation, serial port support, configurable
 logging, multi-user support, and utf8 charset support.

Attachment: signature.asc
Description: Digital signature


Reply to: