Re: [RFR] templates://ipvsadm/{ipvsadm.templates}
Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
I agree with all your changes, but found some more things to change in
between.
> ipvsadm can activate the IPVS synchronization daemon. "master" starts this
> daemon in master mode, "backup" in backup mode and "both" uses master and
> backup mode at the same time. "none" disables the daemon.
All these sentences starting with lowercase! Never mind that, though,
there's some slightly irregular verb ellipsis going on there and I'd
also like to add a serial comma and a plural inflection:
ipvsadm can activate the IPVS synchronization daemon. "master" starts this
daemon in master mode, "backup" starts it in backup mode, and "both" uses
master and backup modes at the same time. "none" disables the daemon.
[...]
> Template: ipvsadm/kernel_does_not_support_ipvs
> -Type: note
> +Type: error
> _Description: Kernel does not support IPVS
> ipvsadm requires IPVS support in the kernel. Please use a kernel with IPVS
> modules, otherwise this software is pretty useless.
That's a comma splice (which together with the "pretty useless" is
incongrously colloquial). And who says it needs to be modular rather
than compiled-in? Maybe:
ipvsadm is useless with this kernel, since it has CONFIG_IP_VS=n.
Please use a kernel compiled with IPVS support.
[...]
> Template: ipvsadm/daemon_multicast_interface
> Type: string
> Default: eth0
> +#flag:translate!:3
> _Description: Multicast interface for ipvsadm:
> - Select the multicast interface to be used by synchronization daemon. e.g.
> - eth0, eth1...
> + Please specify the multicast interface to be used by synchronization daemon. e.g.
> + eth0, eth1, etc.
Shouldn't that be "the" synchronization daemon (as in the first
template)?
Why the full stop before the "e.g."? Why does it even need to give an
example beyond the self-explanatory default of eth0?
Meanwhile in the package description...
> Package: ipvsadm
> Architecture: any
> Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
> Conflicts: lvs
> Replaces: lvs
> Suggests: heartbeat, keepalived, ldirectord
> Description: Linux Virtual Server support programs
> The Linux Virtual Server (lvs or IPVS) is a highly scalable and highly
> available server built on a cluster of real servers. The architecture of the
> cluster is transparent to end users, and the users see only a single virtual
> server.
> .
> This package provides some support programs necessary to implement a virtual
> server under Linux. With the addition of the mon and heartbeat packages it is
> possible to implement a complete high-availability solution for Linux.
Oh, that's good! The only thing I can see to improve is:
The architecture of the
cluster is transparent to end users, who see only a single virtual server.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
Template: ipvsadm/daemon_method
Type: select
__Choices: none, master, backup, both
Default: none
_Description: Daemon method:
ipvsadm can activate the IPVS synchronization daemon. "master" starts this
daemon in master mode, "backup" starts it in backup mode, and "both" uses
master and backup modes at the same time. "none" disables the daemon.
.
See the ipvsadm(8) man page for more details.
Template: ipvsadm/kernel_does_not_support_ipvs
Type: error
_Description: Kernel does not support IPVS
ipvsadm is useless with this kernel, since it has CONFIG_IP_VS=n.
Please use a kernel compiled with IPVS support.
Template: ipvsadm/auto_load_rules
Type: boolean
Default: false
_Description: Do you want to automatically load IPVS rules on boot?
If you choose this option, IPVS rules will be loaded from
/etc/ipvsadm.rules automatically on boot.
Template: ipvsadm/daemon_multicast_interface
Type: string
Default: eth0
#flag:translate!:3
_Description: Multicast interface for ipvsadm:
Please specify the multicast interface to be used by the synchronization
daemon.
.
${interface_error}
Source: ipvsadm
Section: net
Priority: extra
Maintainer: Alexander Wirt <formorer@debian.org>
Standards-Version: 3.9.2
Build-Depends: debhelper (>= 7.0.50~), libpopt-dev, po-debconf, libnl-dev, dpatch (>= 2.0.32~)
Package: ipvsadm
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
Conflicts: lvs
Replaces: lvs
Suggests: heartbeat, keepalived, ldirectord
Description: Linux Virtual Server support programs
The Linux Virtual Server (lvs or IPVS) is a highly scalable and highly
available server built on a cluster of real servers. The architecture of the
cluster is transparent to end users, who see only a single virtual server.
.
This package provides some support programs necessary to implement a virtual
server under Linux. With the addition of the mon and heartbeat packages it is
possible to implement a complete high-availability solution for Linux.
diff -ru old/control new/control
--- old/control 2012-08-22 08:31:11.180411294 +0100
+++ new/control 2012-08-22 20:09:03.988411189 +0100
@@ -14,8 +14,7 @@
Description: Linux Virtual Server support programs
The Linux Virtual Server (lvs or IPVS) is a highly scalable and highly
available server built on a cluster of real servers. The architecture of the
- cluster is transparent to end users, and the users see only a single virtual
- server.
+ cluster is transparent to end users, who see only a single virtual server.
.
This package provides some support programs necessary to implement a virtual
server under Linux. With the addition of the mon and heartbeat packages it is
diff -ru old/ipvsadm.templates new/ipvsadm.templates
--- old/ipvsadm.templates 2012-08-22 08:31:10.316411127 +0100
+++ new/ipvsadm.templates 2012-08-22 20:11:12.428411317 +0100
@@ -4,29 +4,30 @@
Default: none
_Description: Daemon method:
ipvsadm can activate the IPVS synchronization daemon. "master" starts this
- daemon in master mode, "backup" in backup mode and "both" uses master and
- backup mode at the same time. "none" disables the daemon.
+ daemon in master mode, "backup" starts it in backup mode, and "both" uses
+ master and backup modes at the same time. "none" disables the daemon.
.
- See the man page for more details, ipvsadm(8).
+ See the ipvsadm(8) man page for more details.
Template: ipvsadm/kernel_does_not_support_ipvs
-Type: note
+Type: error
_Description: Kernel does not support IPVS
- ipvsadm requires IPVS support in the kernel. Please use a kernel with IPVS
- modules, otherwise this software is pretty useless.
+ ipvsadm is useless with this kernel, since it has CONFIG_IP_VS=n.
+ Please use a kernel compiled with IPVS support.
Template: ipvsadm/auto_load_rules
Type: boolean
Default: false
_Description: Do you want to automatically load IPVS rules on boot?
- If you choose this option your IPVS rules will be loaded from
+ If you choose this option, IPVS rules will be loaded from
/etc/ipvsadm.rules automatically on boot.
Template: ipvsadm/daemon_multicast_interface
Type: string
Default: eth0
+#flag:translate!:3
_Description: Multicast interface for ipvsadm:
- Select the multicast interface to be used by synchronization daemon. e.g.
- eth0, eth1...
+ Please specify the multicast interface to be used by the synchronization
+ daemon.
.
${interface_error}
Reply to: