Please find, for review, the debconf templates and packages descriptions for the ipvsadm source package.
This review will last from Wednesday, August 22, 2012 to Saturday, September 01, 2012.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- ipvsadm.old/debian/ipvsadm.templates 2012-08-22 06:49:41.044630607 +0200
+++ ipvsadm/debian/ipvsadm.templates 2012-08-22 19:22:01.308215106 +0200
@@ -7,10 +7,10 @@
daemon in master mode, "backup" in backup mode and "both" uses master and
backup mode at the same time. "none" disables the daemon.
.
- See the man page for more details, ipvsadm(8).
+ See the ipvsadm(8) man page for more details.
More common style....
Template: ipvsadm/kernel_does_not_support_ipvs
-Type: note
+Type: error
_Description: Kernel does not support IPVS
ipvsadm requires IPVS support in the kernel. Please use a kernel with IPVS
modules, otherwise this software is pretty useless.
@@ -19,14 +19,15 @@
Type: boolean
Default: false
_Description: Do you want to automatically load IPVS rules on boot?
- If you choose this option your IPVS rules will be loaded from
+ If you choose this option, IPVS rules will be loaded from
/etc/ipvsadm.rules automatically on boot.
The "error" type seems more appropriate, here.
Unpersonnalization.
Template: ipvsadm/daemon_multicast_interface
Type: string
Default: eth0
+#flag:translate!:3
_Description: Multicast interface for ipvsadm:
- Select the multicast interface to be used by synchronization daemon. e.g.
- eth0, eth1...
+ Please specify the multicast interface to be used by synchronization daemon. e.g.
+ eth0, eth1, etc.
.
${interface_error}
Avoid translating the variable.
Use "etc." instead of an ellipsis/
Also, this is not "choosing" the multicast interface but more
"specifying" it.
--
Template: ipvsadm/daemon_method
Type: select
__Choices: none, master, backup, both
Default: none
_Description: Daemon method:
ipvsadm can activate the IPVS synchronization daemon. "master" starts this
daemon in master mode, "backup" in backup mode and "both" uses master and
backup mode at the same time. "none" disables the daemon.
.
See the ipvsadm(8) man page for more details.
Template: ipvsadm/kernel_does_not_support_ipvs
Type: error
_Description: Kernel does not support IPVS
ipvsadm requires IPVS support in the kernel. Please use a kernel with IPVS
modules, otherwise this software is pretty useless.
Template: ipvsadm/auto_load_rules
Type: boolean
Default: false
_Description: Do you want to automatically load IPVS rules on boot?
If you choose this option, IPVS rules will be loaded from
/etc/ipvsadm.rules automatically on boot.
Template: ipvsadm/daemon_multicast_interface
Type: string
Default: eth0
#flag:translate!:3
_Description: Multicast interface for ipvsadm:
Please specify the multicast interface to be used by synchronization daemon. e.g.
eth0, eth1, etc.
.
${interface_error}
--- ipvsadm.old/debian/ipvsadm.templates 2012-08-22 06:49:41.044630607 +0200
+++ ipvsadm/debian/ipvsadm.templates 2012-08-22 19:22:01.308215106 +0200
@@ -7,10 +7,10 @@
daemon in master mode, "backup" in backup mode and "both" uses master and
backup mode at the same time. "none" disables the daemon.
.
- See the man page for more details, ipvsadm(8).
+ See the ipvsadm(8) man page for more details.
Template: ipvsadm/kernel_does_not_support_ipvs
-Type: note
+Type: error
_Description: Kernel does not support IPVS
ipvsadm requires IPVS support in the kernel. Please use a kernel with IPVS
modules, otherwise this software is pretty useless.
@@ -19,14 +19,15 @@
Type: boolean
Default: false
_Description: Do you want to automatically load IPVS rules on boot?
- If you choose this option your IPVS rules will be loaded from
+ If you choose this option, IPVS rules will be loaded from
/etc/ipvsadm.rules automatically on boot.
Template: ipvsadm/daemon_multicast_interface
Type: string
Default: eth0
+#flag:translate!:3
_Description: Multicast interface for ipvsadm:
- Select the multicast interface to be used by synchronization daemon. e.g.
- eth0, eth1...
+ Please specify the multicast interface to be used by synchronization daemon. e.g.
+ eth0, eth1, etc.
.
${interface_error}
Source: ipvsadm
Section: net
Priority: extra
Maintainer: Alexander Wirt <formorer@debian.org>
Standards-Version: 3.9.2
Build-Depends: debhelper (>= 7.0.50~), libpopt-dev, po-debconf, libnl-dev, dpatch (>= 2.0.32~)
Package: ipvsadm
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
Conflicts: lvs
Replaces: lvs
Suggests: heartbeat, keepalived, ldirectord
Description: Linux Virtual Server support programs
The Linux Virtual Server (lvs or IPVS) is a highly scalable and highly
available server built on a cluster of real servers. The architecture of the
cluster is transparent to end users, and the users see only a single virtual
server.
.
This package provides some support programs necessary to implement a virtual
server under Linux. With the addition of the mon and heartbeat packages it is
possible to implement a complete high-availability solution for Linux.
Attachment:
signature.asc
Description: Digital signature