Please find, for review, the debconf templates and packages descriptions for the guacamole source package.
This review will last from Monday, November 14, 2011 to Thursday, November 24, 2011.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- guacamole.old/debian/guacamole-tomcat.templates 2011-11-10 08:14:54.980853067 +0100
+++ guacamole/debian/guacamole-tomcat.templates 2011-11-14 07:19:28.566238881 +0100
@@ -2,8 +2,9 @@
Type: boolean
Default: false
_Description: Restart Tomcat server?
- Installation of Guacamole under Tomcat requires restarting the Tomcat
+ The installation of Guacamole under Tomcat requires restarting the Tomcat
server, as Tomcat will only read configuration files on startup.
+ .
You can also restart Tomcat manually by running
- invoke-rc.d tomcat6 restart.
+ "invoke-rc.d tomcat6 restart" as root.
Justin, do you confirm that "The" is better here? I may be influenced
by some French roots..:-)
The other change is just adding quotes around the suggested command.
--- guacamole.old/debian/control 2011-11-10 08:14:54.980853067 +0100
+++ guacamole/debian/control 2011-11-14 07:20:59.585434707 +0100
@@ -15,10 +15,10 @@
Recommends: libguac-client-vnc0
Suggests: tomcat6 | jetty
Description: HTML5 web application for accessing remote desktops
- Guacamole is an HTML5 web application that provides access to your desktop
- using remote desktop protocols. A centralized server acts as a tunnel and
- proxy, allowing access to multiple desktops through a web browser; no plugins
- needed. The client requires nothing more than a web browser supporting HTML5
+ Guacamole is an HTML5 web application that provides access to a
+ desktop environment using remote desktop protocols. A centralized server acts as a tunnel and
+ proxy, allowing access to multiple desktops through a web browser. No plugins
+ are needed: the client requires nothing more than a web browser supporting HTML5
and AJAX.
Avoid "your" desktop. It's maybe not mine..:-)
Slight revamping of sentences.
Package: guacamole-tomcat
@@ -26,6 +26,12 @@
Architecture: all
Depends: debconf, guacamole, tomcat6, libguac-client-vnc0, ${misc:Depends}
Description: Tomcat-based Guacamole install with VNC support
+ Guacamole is an HTML5 web application that provides access to a
+ desktop environment using remote desktop protocols. A centralized server acts as a tunnel and
+ proxy, allowing access to multiple desktops through a web browser. No plugins
+ are needed: the client requires nothing more than a web browser supporting HTML5
+ and AJAX.
+ .
This metapackage depends on Tomcat, Guacamole, and the VNC support plugin for
guacamole. Guacamole is automatically installed and configured under
Tomcat.
Adding a boilerplate from the main package. That may help someone
browsing guacamole-tomcat package description without knowing what
Guacamole is (apart from being something very tasty to eat with
tortillas, of course).
--
Template: guacamole-tomcat/restart-server Type: boolean Default: false _Description: Restart Tomcat server? The installation of Guacamole under Tomcat requires restarting the Tomcat server, as Tomcat will only read configuration files on startup. . You can also restart Tomcat manually by running "invoke-rc.d tomcat6 restart" as root.
--- guacamole.old/debian/guacamole-tomcat.templates 2011-11-10 08:14:54.980853067 +0100
+++ guacamole/debian/guacamole-tomcat.templates 2011-11-14 07:19:28.566238881 +0100
@@ -2,8 +2,9 @@
Type: boolean
Default: false
_Description: Restart Tomcat server?
- Installation of Guacamole under Tomcat requires restarting the Tomcat
+ The installation of Guacamole under Tomcat requires restarting the Tomcat
server, as Tomcat will only read configuration files on startup.
+ .
You can also restart Tomcat manually by running
- invoke-rc.d tomcat6 restart.
+ "invoke-rc.d tomcat6 restart" as root.
--- guacamole.old/debian/control 2011-11-10 08:14:54.980853067 +0100
+++ guacamole/debian/control 2011-11-14 07:20:59.585434707 +0100
@@ -15,10 +15,10 @@
Recommends: libguac-client-vnc0
Suggests: tomcat6 | jetty
Description: HTML5 web application for accessing remote desktops
- Guacamole is an HTML5 web application that provides access to your desktop
- using remote desktop protocols. A centralized server acts as a tunnel and
- proxy, allowing access to multiple desktops through a web browser; no plugins
- needed. The client requires nothing more than a web browser supporting HTML5
+ Guacamole is an HTML5 web application that provides access to a
+ desktop environment using remote desktop protocols. A centralized server acts as a tunnel and
+ proxy, allowing access to multiple desktops through a web browser. No plugins
+ are needed: the client requires nothing more than a web browser supporting HTML5
and AJAX.
Package: guacamole-tomcat
@@ -26,6 +26,12 @@
Architecture: all
Depends: debconf, guacamole, tomcat6, libguac-client-vnc0, ${misc:Depends}
Description: Tomcat-based Guacamole install with VNC support
+ Guacamole is an HTML5 web application that provides access to a
+ desktop environment using remote desktop protocols. A centralized server acts as a tunnel and
+ proxy, allowing access to multiple desktops through a web browser. No plugins
+ are needed: the client requires nothing more than a web browser supporting HTML5
+ and AJAX.
+ .
This metapackage depends on Tomcat, Guacamole, and the VNC support plugin for
guacamole. Guacamole is automatically installed and configured under
Tomcat.
Source: guacamole
Priority: extra
Maintainer: Michael Jumper <zhangmaike@users.sourceforge.net>
Build-Depends: po-debconf, debhelper (>= 7.0), cdbs, default-jdk | java6-sdk, maven-debian-helper, libmaven-war-plugin-java, libmaven-assembly-plugin-java, libmaven-plugin-testing-java, libslf4j-java, libservlet2.5-java
Standards-Version: 3.9.2
Section: net
Vcs-Git: git://guacamole.git.sourceforge.net/gitroot/guacamole/guacamole
Vcs-Browser: http://guacamole.git.sourceforge.net/git/gitweb.cgi?p=guacamole/guacamole;a=tree
Homepage: http://guacamole.sourceforge.net/
Package: guacamole
Section: net
Architecture: all
Depends: guacd (>= 0.4), guacd (<< 0.5), ${misc:Depends}
Recommends: libguac-client-vnc0
Suggests: tomcat6 | jetty
Description: HTML5 web application for accessing remote desktops
Guacamole is an HTML5 web application that provides access to a
desktop environment using remote desktop protocols. A centralized server acts as a tunnel and
proxy, allowing access to multiple desktops through a web browser. No plugins
are needed: the client requires nothing more than a web browser supporting HTML5
and AJAX.
Package: guacamole-tomcat
Section: net
Architecture: all
Depends: debconf, guacamole, tomcat6, libguac-client-vnc0, ${misc:Depends}
Description: Tomcat-based Guacamole install with VNC support
Guacamole is an HTML5 web application that provides access to a
desktop environment using remote desktop protocols. A centralized server acts as a tunnel and
proxy, allowing access to multiple desktops through a web browser. No plugins
are needed: the client requires nothing more than a web browser supporting HTML5
and AJAX.
.
This metapackage depends on Tomcat, Guacamole, and the VNC support plugin for
guacamole. Guacamole is automatically installed and configured under
Tomcat.
Attachment:
signature.asc
Description: Digital signature