[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#645850: lxc package debconf templates



retitle 645850 debconf templates and debian/control review
severity 645850 wishlist
tag 645850 - patch
thanks

On 11/14/2011 08:15 AM, Christian PERRIER wrote:
Daniel, was something broken in the review I sent to you?

most of the suggested changes for the debconf templates were not usable as they were completely wrong.

for the records, this is your entire suggested diff for templates:

---snip---
--- lxc.templates.orig»·2011-11-14 08:53:09.867052982 +0100
+++ lxc.templates»······2011-11-14 08:53:41.491205482 +0100
@@ -1,13 +1,13 @@
 Template: lxc/title
 Type: title
-_Description: Linux Container (LXC)
+_Description: Linux Containers (LXC) setup
·
 Template: lxc/auto
 Type: boolean
 Default: true
-_Description: Linux Container: Automatic start and stop
- Linux Containers that have their configuration files copied or symlinked
- to the /etc/lxc/auto directory can be automatically started during system
- boot and shutdown on reboot/halt.
+_Description: Automatically start Linux Containers on boot?
+ Linux Containers can be automatically started during system
+ boot and shut down on reboot or halt.
  .
- If unsure, choose yes (default).
+ If you choose this option, the required symlinks will be created in
+ the /etc/lxc/auto directory.
---snap---

i used '_Description: Linux Containers: LXC setup' which is in sync with what linux-container uses (Linux Containers: Container setup).

for lxc/auto, i used your suggested new short description and the second part of your suggested sentence in the long description, ending up with:

_Description: Automatically start Linux Containers on boot?
 Linux Containers that have their configuration files copied or
 symlinked to the /etc/lxc/auto directory can be automatically started
 during system boot, and shut down on reboot or halt.
 .
 If unsure, choose yes (default).

so i used all there could be used. the rest of your suggested changes are just wrong. the package does not do what you suggested it to say. it does what i described originally.

while i certainly appreciate corrections for style/grammar/typo/wording etc., i prefere if you do not change the meaning unless you actually had a look at what the package does. apparently, maintainers still do understand their packages better than translators.,

for the rest, well, lxc got two new debconf questions and the newly added linux-container package has 11 debconf questions. of course they are untranslated initially.

--
Address:        Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email:          daniel.baumann@progress-technologies.net
Internet:       http://people.progress-technologies.net/~daniel.baumann/


Reply to: