[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://kstars-data-extra-tycho2/{templates}



> Please find, for review, the debconf templates and packages descriptions
> for the kstars-data-extra-tycho2 source package.
[...]
> --- kstars-data-extra-tycho2.old/debian/templates	2011-07-18
> 10:38:15.580539811 +0200 +++
> kstars-data-extra-tycho2/debian/templates	2011-07-19 21:07:40.467272739
> +0200 @@ -1,23 +1,27 @@
>  Template: kstars-data-extra/kstarsrc-title
>  Type: title
> -_Description: kstars global config file
> +_Description: Handling of kstars configuration file
> 
> I have to mention that I'm not entirely fond of the overuse of
> db_title. I think that the default title ("Configuration of <foo>")
> fits its needs.
> 
> Anyway, I'w rewording to avoid the leading lowercase.
> 
I think the word 'global' here is important for two reasons:
a) the file will affect the behaviour of the kstars program, and it is the 
same file I will use in other kstars-data-extra-* packages
b) the file is the system-wide configuration of kstars, there are other 
configurations per-user
> 
[...]
>  Template: kstars-data-extra/disable-downloads-title
>  Type: title
> @@ -27,21 +31,22 @@
>  Type: select
>  __Choices: keep enabled, disable, lock
>  Default: lock
> -_Description: Disable downloads of new data for kstars users?
> - Each user will be able to re-enable downloads for him unless you lock the
> feature. +_Description: Choice for downloads of new data by kstars users:
> + By default, unless the feature is locked, each user will be able
> + to enable data downloads.
> 
> Same "problem" with interrogative form.
> 
> I admit that, here, I don't really understand the difference between
> "disable" and "lock" and so would probably other users.
> 
> Maybe the consequences of each option should be explained.

I will explain here, so you can rephrase them and put in good english. If 
downloads are _disabled_, users CAN re-enable downloads by manually tweaking 
their own .kstarsrc files. If downloads are _locked_, users CAN NOT reenable 
them by any means (besides recompilation ;) )

Why would users re-enable downloads? Because this setting affects all kstars 
downloads, not only those of Tycho2 catalog, disabling them all, while the 
package provides only the Tycho2 catalog datafile. There will be other 
packages in the future providing the remaining datafiles.
> 
[...]
>  Template: kstars-data-extra/kstarsrc-previously-exists
>  Type: select
>  Choices: unset, previously exists, does not exist
>  Default: unset
> -Description: No-show question
> +Description: for internal use
>   Not shown question to hold a data in the database
> 
> Very debatable;.:-)
> 
> First of all, you should use "for internal use" so that you don't get
> a lintian warning about non-translatable template.
> 
> The, this is kind of using the debconf database as a registry and many
> documentations explain this is Bad..:-)
> 
I know, but it is information that only debconf will use, so I just drop it 
there for it to be used in all kstars-data-extra-* packages
> 

Thanks for your work

Noel

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: