Please find, for review, the debconf templates and packages descriptions for the kstars-data-extra-tycho2 source package.
This review will last from Wednesday, July 20, 2011 to Saturday, July 30, 2011.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- kstars-data-extra-tycho2.old/debian/templates 2011-07-18 10:38:15.580539811 +0200
+++ kstars-data-extra-tycho2/debian/templates 2011-07-19 21:07:40.467272739 +0200
@@ -1,23 +1,27 @@
Template: kstars-data-extra/kstarsrc-title
Type: title
-_Description: kstars global config file
+_Description: Handling of kstars configuration file
I have to mention that I'm not entirely fond of the overuse of
db_title. I think that the default title ("Configuration of <foo>")
fits its needs.
Anyway, I'w rewording to avoid the leading lowercase.
Template: kstars-data-extra/kstarsrc-exists
Type: select
__Choices: backup and create new, delete and create new, keep actual file
Default: keep
-_Description: Delete existent /etc/kde4/kstarsrc file?
+_Description: Action for the /etc/kde4/kstarsrc file:
A kstars global config file has been detected as /etc/kde4/kstarsrc .
.
- This script is NOT (yet) able to modify it, but you can now backup it and create a new one now. You will be asked for its options.
+ The package installation process can't modify it, but you can
+ backup it up now and create a new one. You will be prompted for
+ options in this file.
Interrogative form should be avoided in select/multiselect and only
use for boolean. I admit this is tricky in this case, hence my
proposal.
Avoid "this script" as it makes reference to tools that are used,
which we try to avoid.
Then, I made a few wording changes for what I suppose to be better
English (but Justin will improve it, I think..:-))
Template: kstars-data-extra/kstarsrc-does-not-exist
Type: boolean
Default: true
_Description: Create /etc/kde4/kstarsrc file?
- There is no kstars global config file. For disabling the user download feature you will need one, but it will not harm if you have one even if you do not want to disable user downloads. It is possible to create one for you in /etc/kde4/kstarsrc
+ There is no kstars global config file.
.
- This will create it. You will be asked for its options.
+ In order to optionnally disable the user download feature, one
+ is needed. If you choose to create one, you will be prompted for
+ options in this file.
Split in paragraphs for readability.
I simplified the wording. Just try to push the idea that the file is
mandatory if one wants to disable userdownloads.....and that it
doesn't hurt otherwise..:-)
Template: kstars-data-extra/disable-downloads-title
Type: title
@@ -27,21 +31,22 @@
Type: select
__Choices: keep enabled, disable, lock
Default: lock
-_Description: Disable downloads of new data for kstars users?
- Each user will be able to re-enable downloads for him unless you lock the feature.
+_Description: Choice for downloads of new data by kstars users:
+ By default, unless the feature is locked, each user will be able
+ to enable data downloads.
Same "problem" with interrogative form.
I admit that, here, I don't really understand the difference between
"disable" and "lock" and so would probably other users.
Maybe the consequences of each option should be explained.
Template: kstars-data-extra/kstarsrc-saved-title
Type: title
-_Description: old kstarsrc saved
+_Description: Backup of old kstarsrc file
Template: kstars-data-extra/kstarsrc-saved
Type: text
-_Description: The old kstarsrc file has been saved
- The old kstarsrc file has been saved as /etc/kde4/kstarsrc.backup.kstars-data-extra
+_Description: Former kstarsrc file saved
+ The old kstarsrc file has been saved as /etc/kde4/kstarsrc.backup.kstars-data-extra.
This template is debconf abuse, imho. I think there is no real need to
interrupt the process to just display it. Anyway, I made a minor
rewording: the synopsis shouldn't be a sentence as it's mostly meant
to be a title.
Template: kstars-data-extra/kstarsrc-previously-exists
Type: select
Choices: unset, previously exists, does not exist
Default: unset
-Description: No-show question
+Description: for internal use
Not shown question to hold a data in the database
Very debatable;.:-)
First of all, you should use "for internal use" so that you don't get
a lintian warning about non-translatable template.
The, this is kind of using the debconf database as a registry and many
documentations explain this is Bad..:-)
--- kstars-data-extra-tycho2.old/debian/control 2011-07-18 10:38:15.580539811 +0200
+++ kstars-data-extra-tycho2/debian/control 2011-07-19 21:11:07.820838947 +0200
@@ -12,6 +12,7 @@
Description: Tycho2 star catalogue for centralized install of KStars
This package contains the data of the Tycho 2 star catalogue for KStars, the
graphical desktop planetarium for KDE. Without this package, KStars would offer
- each user to download it. Installing this package avoids the need for each user
- to individually download the whole catalog. It is configurable if you want the
- users to be unable to do those downloads.
+ each user to download it.
+ .
+ If this package is installed, users won't need anymore to
+ download the whole catalog themselves.
Rewording the last sentence and separating it from the rest.
--
Template: kstars-data-extra/kstarsrc-title Type: title _Description: Handling of kstars configuration file Template: kstars-data-extra/kstarsrc-exists Type: select __Choices: backup and create new, delete and create new, keep actual file Default: keep _Description: Action for the /etc/kde4/kstarsrc file: A kstars global config file has been detected as /etc/kde4/kstarsrc . . The package installation process can't modify it, but you can backup it up now and create a new one. You will be prompted for options in this file. Template: kstars-data-extra/kstarsrc-does-not-exist Type: boolean Default: true _Description: Create /etc/kde4/kstarsrc file? There is no kstars global config file. . In order to optionnally disable the user download feature, one is needed. If you choose to create one, you will be prompted for options in this file. Template: kstars-data-extra/disable-downloads-title Type: title _Description: Disable or lock data downloads Template: kstars-data-extra/disable-downloads Type: select __Choices: keep enabled, disable, lock Default: lock _Description: Choice for downloads of new data by kstars users: By default, unless the feature is locked, each user will be able to enable data downloads. Template: kstars-data-extra/kstarsrc-saved-title Type: title _Description: Backup of old kstarsrc file Template: kstars-data-extra/kstarsrc-saved Type: text _Description: Former kstarsrc file saved The old kstarsrc file has been saved as /etc/kde4/kstarsrc.backup.kstars-data-extra. Template: kstars-data-extra/kstarsrc-previously-exists Type: select Choices: unset, previously exists, does not exist Default: unset Description: for internal use Not shown question to hold a data in the database
--- kstars-data-extra-tycho2.old/debian/templates 2011-07-18 10:38:15.580539811 +0200 +++ kstars-data-extra-tycho2/debian/templates 2011-07-19 21:07:40.467272739 +0200 @@ -1,23 +1,27 @@ Template: kstars-data-extra/kstarsrc-title Type: title -_Description: kstars global config file +_Description: Handling of kstars configuration file Template: kstars-data-extra/kstarsrc-exists Type: select __Choices: backup and create new, delete and create new, keep actual file Default: keep -_Description: Delete existent /etc/kde4/kstarsrc file? +_Description: Action for the /etc/kde4/kstarsrc file: A kstars global config file has been detected as /etc/kde4/kstarsrc . . - This script is NOT (yet) able to modify it, but you can now backup it and create a new one now. You will be asked for its options. + The package installation process can't modify it, but you can + backup it up now and create a new one. You will be prompted for + options in this file. Template: kstars-data-extra/kstarsrc-does-not-exist Type: boolean Default: true _Description: Create /etc/kde4/kstarsrc file? - There is no kstars global config file. For disabling the user download feature you will need one, but it will not harm if you have one even if you do not want to disable user downloads. It is possible to create one for you in /etc/kde4/kstarsrc + There is no kstars global config file. . - This will create it. You will be asked for its options. + In order to optionnally disable the user download feature, one + is needed. If you choose to create one, you will be prompted for + options in this file. Template: kstars-data-extra/disable-downloads-title Type: title @@ -27,21 +31,22 @@ Type: select __Choices: keep enabled, disable, lock Default: lock -_Description: Disable downloads of new data for kstars users? - Each user will be able to re-enable downloads for him unless you lock the feature. +_Description: Choice for downloads of new data by kstars users: + By default, unless the feature is locked, each user will be able + to enable data downloads. Template: kstars-data-extra/kstarsrc-saved-title Type: title -_Description: old kstarsrc saved +_Description: Backup of old kstarsrc file Template: kstars-data-extra/kstarsrc-saved Type: text -_Description: The old kstarsrc file has been saved - The old kstarsrc file has been saved as /etc/kde4/kstarsrc.backup.kstars-data-extra +_Description: Former kstarsrc file saved + The old kstarsrc file has been saved as /etc/kde4/kstarsrc.backup.kstars-data-extra. Template: kstars-data-extra/kstarsrc-previously-exists Type: select Choices: unset, previously exists, does not exist Default: unset -Description: No-show question +Description: for internal use Not shown question to hold a data in the database --- kstars-data-extra-tycho2.old/debian/control 2011-07-18 10:38:15.580539811 +0200 +++ kstars-data-extra-tycho2/debian/control 2011-07-20 09:15:49.929650551 +0200 @@ -12,6 +12,7 @@ Description: Tycho2 star catalogue for centralized install of KStars This package contains the data of the Tycho 2 star catalogue for KStars, the graphical desktop planetarium for KDE. Without this package, KStars would offer - each user to download it. Installing this package avoids the need for each user - to individually download the whole catalog. It is configurable if you want the - users to be unable to do those downloads. + each user to download it. + . + If this package is installed, users won't need anymore to + download the whole catalog themselves.
Source: kstars-data-extra-tycho2
Section: science
Priority: extra
Maintainer: Noel David Torres Taño <envite@rolamasao.org>
Build-Depends: debhelper (>= 7.0.50~), po-debconf
Standards-Version: 3.9.1
Package: kstars-data-extra-tycho2
Architecture: all
Depends: ${misc:Depends}
Enhances: kstars (>= 1.4)
Description: Tycho2 star catalogue for centralized install of KStars
This package contains the data of the Tycho 2 star catalogue for KStars, the
graphical desktop planetarium for KDE. Without this package, KStars would offer
each user to download it.
.
If this package is installed, users won't need anymore to
download the whole catalog themselves.
Attachment:
signature.asc
Description: Digital signature