[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://matlab-support/{matlab-support.templates}



Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.

> Rationale:
[...]
>  Template: matlab-support/no-matlab-found
>  Type: error
> +_Description: No MATLAB installation found
> + No MATLAB executables were found in directories you mentioned.

Make that:
    No MATLAB executables were found in the directories you specified.

>  Template: matlab-support/rename-libs
[...]
> + If you choose this option, the conflicting libraries will be renamed by appending
>   a ".bak" extension. These libraries are located in the "sys/os/glnx86" or
> + "sys/os/glnxa64" subdirectory of MATLAB installation tree(s).

If it's "tree" you need an article and if it's "trees" they have
"subdirectories" (one each, but still plural).  So make it "a"
(any/every) tree:

    "sys/os/glnxa64" subdirectory of a MATLAB installation tree.

>  Package: matlab-support
[...]
> +Description: integratation of local MATLAB installations into the system
                      (typo)
Without the branding it's not obvious what kind of system it's being
integrated into (the solar system?  The oppressive patriarchal
capitalist system?) - the best solution I can manage is:

   Description: distribution integration for local MATLAB installations

(and this makes me wonder whether MATLAB users might think we're
talking about integrating something with a normal distribution, or
something... compare the package octave-integration.  Say "distro"?)

> + This package does NOT provide MATLAB. It merely helps sysadmins
> + integrate local installations in the system to handle this proprietary
>   software in a more coherent way. Moreover, this package can be used as a

Same problem; this time I'll try
                                          It merely provides an integrated
    framework for local installations to help sysadmins handle this proprietary
    software in a more coherent way.

"Moreover" is wrong too - it's used to add another argument in the
same direction, so "MATLAB is not X, merely Y; moreover..." would need
to be followed by another thing the package isn't useful for!  Just use:

                                     This package can also be used as a

> + runtime dependency for packages that install MATLAB code and, for example,
>   need to compile MEX extensions.
>   .
> + One or more MATLAB installations can be registered with alternatives
                                                           ^the
>   system, and a helper utility to build MEX extensions is provided. All
>   configuration is conveniently done via debconf.
[...]
>  Package: matlab-support-dev
[...]
> - Analogous to Octave a Makefile snippet is provided that configures the
> +Description: helpers for packages building MATLAB toolboxes
> + Analogous to Octave, a Makefile snippet is provided that configures the

That must be a fairly hefty snippet if it's analogous to the whole of
Octave!  Instead I assume it's analogous to octave-pkg-dev's snippet.

    This package provides a Makefile snippet (analogous to the one used for
    Octave) that configures the

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Template: matlab-support/title
Type: title
_description: MATLAB interface configuration


Template: matlab-support/matlab-install-glob
Type: string
_Description: Location of MATLAB installation(s):
 The MATLAB interface needs to know where MATLAB is installed on this
 system. This can be specified as a single directory or, in case of multiple
 MATLAB installations, as a glob expression (any expression supported by bash,
 including extended pattern matching operators).
 .
 If, for example, the MATLAB executable is installed in /opt/matlab76/bin/matlab,
 please enter "/opt/matlab76". If there are multiple MATLAB versions
 installed, you can enter "/opt/matlab*" or a similar expression. Only
 matches that really contain a MATLAB executable will be considered.
 Therefore, a glob expression may match more than
 just MATLAB installation directories without negative side effects.


Template: matlab-support/default-version
Type: select
Choices: ${choices}
_Description: Default MATLAB version:
 The following MATLAB versions were found on this system. Please select which
 one should serve as the default MATLAB on this system.


Template: matlab-support/no-matlab-found
Type: error
_Description: No MATLAB installation found
 No MATLAB executables were found in the directories you specified.
 .
 This package requires at least one local installation of MATLAB.


Template: matlab-support/mexbuild-user
Type: string
_Description: Authorized user for MATLAB:
 If MATLAB can only be launched by a limited set of user accounts, please
 specify the authorized login name. This account will be used by other
 packages to build MEX extensions upon installation.
 .
 You may leave this field empty if you want to allow any user account
 (including root) to launch MATLAB.


Template: matlab-support/rename-libs
Type: boolean
Default: false
_Description: Rename MATLAB's GCC libraries?
 A MATLAB installation is shipped with copies of GCC dynamic loadable
 libraries, which typically come from an old version of GCC.
 .
 These libraries sometimes cause conflicts.
 .
 If you choose this option, the conflicting libraries will be renamed by appending
 a ".bak" extension. These libraries are located in the "sys/os/glnx86" or
 "sys/os/glnxa64" subdirectory of a MATLAB installation tree.
Source: matlab-support
Section: devel
Priority: optional
Maintainer: NeuroDebian Team <team@neuro.debian.net>
Uploaders: Michael Hanke <mih@debian.org>, Yaroslav Halchenko <debian@onerussian.com>
Build-Depends: debhelper (>= 7.0.50~), po-debconf, help2man
Standards-Version: 3.9.1
Vcs-Browser: http://git.debian.org/?p=pkg-exppsy/matlab-support.git
Vcs-Git: git://git.debian.org/git/pkg-exppsy/matlab-support.git
XS-DM-Upload-Allowed: yes


Package: matlab-support
Section: contrib/devel
Architecture: all
Depends: debconf (>=1.3.22) | cdebconf (>= 0.43), ${misc:Depends}, libxp6, sudo
Recommends: libstdc++6-4.4-dev | libstdc++-dev
Conflicts: matlab (<= 0.0.14~)
Replaces: matlab (<= 0.0.14~)
Description: distribution integration for local MATLAB installations
 This package does NOT provide MATLAB. It merely provides an integrated
 framework for local installations to help sysadmins handle this proprietary
 software in a more coherent way. This package can also be used as a
 runtime dependency for packages that install MATLAB code and, for example,
 need to compile MEX extensions.
 .
 One or more MATLAB installations can be registered with the alternatives
 system, and a helper utility to build MEX extensions is provided. All
 configuration is conveniently done via debconf.


Package: matlab-support-dev
Section: devel
Architecture: all
Depends: ${misc:Depends}
Conflicts: matlab-dev (<= 0.0.14~)
Replaces: matlab-dev (<= 0.0.14~)
Description: helpers for packages building MATLAB toolboxes
 This package provides a Makefile snippet (analogous to the one used for
 Octave) that configures the locations for architecture independent M-files,
 binary MEX-extensions, and their corresponding sources. This package can be
 used as a build-dependency by other packages shipping MATLAB toolboxes.
diff -ru matlab-support.old/control matlab-support.new/control
--- matlab-support.old/control	2011-04-23 10:29:32.041258751 +0100
+++ matlab-support.new/control	2011-04-27 10:48:28.337258785 +0100
@@ -17,14 +17,14 @@
 Recommends: libstdc++6-4.4-dev | libstdc++-dev
 Conflicts: matlab (<= 0.0.14~)
 Replaces: matlab (<= 0.0.14~)
-Description: integrate local Matlab installations into the Debian system
- This package does NOT provide Matlab (TM). It merely helps sysadmins
- integrate local installations in the Debian system to handle this proprietary
- software in a more coherent way. Moreover, this package can be used as a
- runtime dependency for packages that install Matlab code and, for example,
+Description: distribution integration for local MATLAB installations
+ This package does NOT provide MATLAB. It merely provides an integrated
+ framework for local installations to help sysadmins handle this proprietary
+ software in a more coherent way. This package can also be used as a
+ runtime dependency for packages that install MATLAB code and, for example,
  need to compile MEX extensions.
  .
- One or more Matlab installations can be registered with Debian's alternatives
+ One or more MATLAB installations can be registered with the alternatives
  system, and a helper utility to build MEX extensions is provided. All
  configuration is conveniently done via debconf.
 
@@ -35,8 +35,8 @@
 Depends: ${misc:Depends}
 Conflicts: matlab-dev (<= 0.0.14~)
 Replaces: matlab-dev (<= 0.0.14~)
-Description: helpers for packages building Matlab toolboxes
- Analogous to Octave a Makefile snippet is provided that configures the
- locations for architecture independent M-files, binary MEX-extensions, and
- there corresponding sources. This package can be used as a build-dependency
- by other packages shipping Matlab toolboxes.
+Description: helpers for packages building MATLAB toolboxes
+ This package provides a Makefile snippet (analogous to the one used for
+ Octave) that configures the locations for architecture independent M-files,
+ binary MEX-extensions, and their corresponding sources. This package can be
+ used as a build-dependency by other packages shipping MATLAB toolboxes.
diff -ru matlab-support.old/matlab-support.templates matlab-support.new/matlab-support.templates
--- matlab-support.old/matlab-support.templates	2011-04-23 10:29:29.521266188 +0100
+++ matlab-support.new/matlab-support.templates	2011-04-27 10:13:52.969258972 +0100
@@ -6,16 +6,16 @@
 Template: matlab-support/matlab-install-glob
 Type: string
 _Description: Location of MATLAB installation(s):
- The Debian MATLAB interface needs to know where MATLAB is installed on this
+ The MATLAB interface needs to know where MATLAB is installed on this
  system. This can be specified as a single directory or, in case of multiple
  MATLAB installations, as a glob expression (any expression supported by bash,
  including extended pattern matching operators).
  .
- If, for example, the MATLAB executable is at '/opt/matlab76/bin/matlab',
- please enter '/opt/matlab76'. If there are multiple MATLAB versions
- installed, it is possible to use '/opt/matlab*' (or something similar). Only
- matches that actually contain a MATLAB executable will be considered,
- everything else is ignored. Therefore a glob expression may match more than
+ If, for example, the MATLAB executable is installed in /opt/matlab76/bin/matlab,
+ please enter "/opt/matlab76". If there are multiple MATLAB versions
+ installed, you can enter "/opt/matlab*" or a similar expression. Only
+ matches that really contain a MATLAB executable will be considered.
+ Therefore, a glob expression may match more than
  just MATLAB installation directories without negative side effects.
 
 
@@ -23,25 +23,27 @@
 Type: select
 Choices: ${choices}
 _Description: Default MATLAB version:
- The following MATLAB versions were found on this system. Any of these versions
- can serve as the default MATLAB on this system.
+ The following MATLAB versions were found on this system. Please select which
+ one should serve as the default MATLAB on this system.
 
 
 Template: matlab-support/no-matlab-found
 Type: error
-_Description: No MATLAB installation found.
+_Description: No MATLAB installation found
+ No MATLAB executables were found in the directories you specified.
+ .
  This package requires at least one local installation of MATLAB.
 
 
 Template: matlab-support/mexbuild-user
 Type: string
-_Description: UNIX user account able to launch MATLAB:
- If MATLAB can only be launched by a limited set of UNIX user accounts, please
- specify the login of such an account. This account will be used by other Debian
+_Description: Authorized user for MATLAB:
+ If MATLAB can only be launched by a limited set of user accounts, please
+ specify the authorized login name. This account will be used by other
  packages to build MEX extensions upon installation.
  .
- If every UNIX user account (including root) is allowed to launch MATLAB,
- please leave this field empty.
+ You may leave this field empty if you want to allow any user account
+ (including root) to launch MATLAB.
 
 
 Template: matlab-support/rename-libs
@@ -53,6 +55,6 @@
  .
  These libraries sometimes cause conflicts.
  .
- If you accept it, the conflicting libraries will be renamed by appending
+ If you choose this option, the conflicting libraries will be renamed by appending
  a ".bak" extension. These libraries are located in the "sys/os/glnx86" or
- "sys/os/glnxa64" subdirectory of your MATLAB installation.
+ "sys/os/glnxa64" subdirectory of a MATLAB installation tree.

Reply to: