Please find, for review, the debconf templates and packages descriptions for the matlab-support source package.
This review will last from Wednesday, April 27, 2011 to Saturday, May 07, 2011.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- matlab-support.old/debian/matlab-support.templates 2011-04-23 11:24:00.863243735 +0200
+++ matlab-support/debian/matlab-support.templates 2011-04-27 06:39:27.713059463 +0200
@@ -6,16 +6,16 @@
Template: matlab-support/matlab-install-glob
Type: string
_Description: Location of MATLAB installation(s):
- The Debian MATLAB interface needs to know where MATLAB is installed on this
+ The MATLAB interface needs to know where MATLAB is installed on this
system. This can be specified as a single directory or, in case of multiple
MATLAB installations, as a glob expression (any expression supported by bash,
including extended pattern matching operators).
.
- If, for example, the MATLAB executable is at '/opt/matlab76/bin/matlab',
- please enter '/opt/matlab76'. If there are multiple MATLAB versions
- installed, it is possible to use '/opt/matlab*' (or something similar). Only
- matches that actually contain a MATLAB executable will be considered,
- everything else is ignored. Therefore a glob expression may match more than
+ If, for example, the MATLAB executable is installed in /opt/matlab76/bin/matlab,
+ please enter "/opt/matlab76". If there are multiple MATLAB versions
+ installed, you can enter "/opt/matlab*" or a similar expression. Only
+ matches that really contain a MATLAB executable will be considered.
+ Therefore, a glob expression may match more than
just MATLAB installation directories without negative side effects.
Unbranding (aka dropping "Debian" so that thestrings are well suited
for derivatives too)
Drop quotes around the directory name and keep them in the example
answer, however using double quotes, which we standardized upon.
I'm balanced about "glob" expression. That's jargonic but the given
example makes it clear what's expected so we can maybe keep this.
Add a comma after "Therefore". Maybe, this is too french, though..:)
@@ -29,19 +29,21 @@
Template: matlab-support/no-matlab-found
Type: error
-_Description: No MATLAB installation found.
+_Description: No MATLAB installation found
+ No MATLAB executables were found in directories you mentioned.
+ .
This package requires at least one local installation of MATLAB.
No final dot in notes synopsis as they're more titles than sentences.
Make the long description self-sufficient.
Template: matlab-support/mexbuild-user
Type: string
-_Description: UNIX user account able to launch MATLAB:
- If MATLAB can only be launched by a limited set of UNIX user accounts, please
- specify the login of such an account. This account will be used by other Debian
+_Description: Authorized user for MATLAB:
+ If MATLAB can only be launched by a limited set of user accounts, please
+ specify the authorized login name. This account will be used by other
packages to build MEX extensions upon installation.
.
- If every UNIX user account (including root) is allowed to launch MATLAB,
- please leave this field empty.
+ You may leave this field empty if you want to allow any user account
+ (including root) to launch MATLAB.
I'm not found of the "UNIX" user account. Just talk about user or
"login".
The template does not make it clear whether entering more than one
user is OK, here.
Template: matlab-support/rename-libs
@@ -53,6 +55,6 @@
.
These libraries sometimes cause conflicts.
.
- If you accept it, the conflicting libraries will be renamed by appending
+ If you choose this option, the conflicting libraries will be renamed by appending
a ".bak" extension. These libraries are located in the "sys/os/glnx86" or
- "sys/os/glnxa64" subdirectory of your MATLAB installation.
+ "sys/os/glnxa64" subdirectory of MATLAB installation tree(s).
"If you choose this option" is out preferred way to write this.
Drop "your" installation...
--- matlab-support.old/debian/control 2011-04-23 11:24:00.863243735 +0200
+++ matlab-support/debian/control 2011-04-27 06:40:55.155233021 +0200
@@ -17,14 +17,14 @@
Recommends: libstdc++6-4.4-dev | libstdc++-dev
Conflicts: matlab (<= 0.0.14~)
Replaces: matlab (<= 0.0.14~)
-Description: integrate local Matlab installations into the Debian system
- This package does NOT provide Matlab (TM). It merely helps sysadmins
- integrate local installations in the Debian system to handle this proprietary
+Description: integratation of local MATLAB installations into the system
+ This package does NOT provide MATLAB. It merely helps sysadmins
+ integrate local installations in the system to handle this proprietary
software in a more coherent way. Moreover, this package can be used as a
- runtime dependency for packages that install Matlab code and, for example,
+ runtime dependency for packages that install MATLAB code and, for example,
need to compile MEX extensions.
.
- One or more Matlab installations can be registered with Debian's alternatives
+ One or more MATLAB installations can be registered with alternatives
system, and a helper utility to build MEX extensions is provided. All
configuration is conveniently done via debconf.
Make the synopsis a noun phrase.
Drop useless and non mandatory "(TM)".
Standardize on "MATLAB" as you did in debconf templates?
Unbranding.
@@ -35,8 +35,8 @@
Depends: ${misc:Depends}
Conflicts: matlab-dev (<= 0.0.14~)
Replaces: matlab-dev (<= 0.0.14~)
-Description: helpers for packages building Matlab toolboxes
- Analogous to Octave a Makefile snippet is provided that configures the
+Description: helpers for packages building MATLAB toolboxes
+ Analogous to Octave, a Makefile snippet is provided that configures the
locations for architecture independent M-files, binary MEX-extensions, and
there corresponding sources. This package can be used as a build-dependency
- by other packages shipping Matlab toolboxes.
+ by other packages shipping MATLAB toolboxes.
Added comma
--
Template: matlab-support/title
Type: title
_description: MATLAB interface configuration
Template: matlab-support/matlab-install-glob
Type: string
_Description: Location of MATLAB installation(s):
The MATLAB interface needs to know where MATLAB is installed on this
system. This can be specified as a single directory or, in case of multiple
MATLAB installations, as a glob expression (any expression supported by bash,
including extended pattern matching operators).
.
If, for example, the MATLAB executable is installed in /opt/matlab76/bin/matlab,
please enter "/opt/matlab76". If there are multiple MATLAB versions
installed, you can enter "/opt/matlab*" or a similar expression. Only
matches that really contain a MATLAB executable will be considered.
Therefore, a glob expression may match more than
just MATLAB installation directories without negative side effects.
Template: matlab-support/default-version
Type: select
Choices: ${choices}
_Description: Default MATLAB version:
The following MATLAB versions were found on this system. Any of these versions
can serve as the default MATLAB on this system.
Template: matlab-support/no-matlab-found
Type: error
_Description: No MATLAB installation found
No MATLAB executables were found in directories you mentioned.
.
This package requires at least one local installation of MATLAB.
Template: matlab-support/mexbuild-user
Type: string
_Description: Authorized user for MATLAB:
If MATLAB can only be launched by a limited set of user accounts, please
specify the authorized login name. This account will be used by other
packages to build MEX extensions upon installation.
.
You may leave this field empty if you want to allow any user account
(including root) to launch MATLAB.
Template: matlab-support/rename-libs
Type: boolean
Default: false
_Description: Rename MATLAB's GCC libraries?
A MATLAB installation is shipped with copies of GCC dynamic loadable
libraries, which typically come from an old version of GCC.
.
These libraries sometimes cause conflicts.
.
If you choose this option, the conflicting libraries will be renamed by appending
a ".bak" extension. These libraries are located in the "sys/os/glnx86" or
"sys/os/glnxa64" subdirectory of MATLAB installation tree(s).
--- matlab-support.old/debian/matlab-support.templates 2011-04-23 11:24:00.863243735 +0200
+++ matlab-support/debian/matlab-support.templates 2011-04-27 06:39:27.713059463 +0200
@@ -6,16 +6,16 @@
Template: matlab-support/matlab-install-glob
Type: string
_Description: Location of MATLAB installation(s):
- The Debian MATLAB interface needs to know where MATLAB is installed on this
+ The MATLAB interface needs to know where MATLAB is installed on this
system. This can be specified as a single directory or, in case of multiple
MATLAB installations, as a glob expression (any expression supported by bash,
including extended pattern matching operators).
.
- If, for example, the MATLAB executable is at '/opt/matlab76/bin/matlab',
- please enter '/opt/matlab76'. If there are multiple MATLAB versions
- installed, it is possible to use '/opt/matlab*' (or something similar). Only
- matches that actually contain a MATLAB executable will be considered,
- everything else is ignored. Therefore a glob expression may match more than
+ If, for example, the MATLAB executable is installed in /opt/matlab76/bin/matlab,
+ please enter "/opt/matlab76". If there are multiple MATLAB versions
+ installed, you can enter "/opt/matlab*" or a similar expression. Only
+ matches that really contain a MATLAB executable will be considered.
+ Therefore, a glob expression may match more than
just MATLAB installation directories without negative side effects.
@@ -29,19 +29,21 @@
Template: matlab-support/no-matlab-found
Type: error
-_Description: No MATLAB installation found.
+_Description: No MATLAB installation found
+ No MATLAB executable were found in directories you mentioned.
+ .
This package requires at least one local installation of MATLAB.
Template: matlab-support/mexbuild-user
Type: string
-_Description: UNIX user account able to launch MATLAB:
- If MATLAB can only be launched by a limited set of UNIX user accounts, please
- specify the login of such an account. This account will be used by other Debian
+_Description: Authorized user for MATLAB:
+ If MATLAB can only be launched by a limited set of user accounts, please
+ specify the authorized login name. This account will be used by other
packages to build MEX extensions upon installation.
.
- If every UNIX user account (including root) is allowed to launch MATLAB,
- please leave this field empty.
+ You may leave this field empty if you want to allow any user account
+ (including root) to launch MATLAB.
Template: matlab-support/rename-libs
@@ -53,6 +55,6 @@
.
These libraries sometimes cause conflicts.
.
- If you accept it, the conflicting libraries will be renamed by appending
+ If you choose this option, the conflicting libraries will be renamed by appending
a ".bak" extension. These libraries are located in the "sys/os/glnx86" or
- "sys/os/glnxa64" subdirectory of your MATLAB installation.
+ "sys/os/glnxa64" subdirectory of MATLAB installation tree(s).
--- matlab-support.old/debian/control 2011-04-23 11:24:00.863243735 +0200
+++ matlab-support/debian/control 2011-04-27 06:40:55.155233021 +0200
@@ -17,14 +17,14 @@
Recommends: libstdc++6-4.4-dev | libstdc++-dev
Conflicts: matlab (<= 0.0.14~)
Replaces: matlab (<= 0.0.14~)
-Description: integrate local Matlab installations into the Debian system
- This package does NOT provide Matlab (TM). It merely helps sysadmins
- integrate local installations in the Debian system to handle this proprietary
+Description: integratation of local MATLAB installations into the system
+ This package does NOT provide MATLAB. It merely helps sysadmins
+ integrate local installations in the system to handle this proprietary
software in a more coherent way. Moreover, this package can be used as a
- runtime dependency for packages that install Matlab code and, for example,
+ runtime dependency for packages that install %MATLAB code and, for example,
need to compile MEX extensions.
.
- One or more Matlab installations can be registered with Debian's alternatives
+ One or more MATLAB installations can be registered with alternatives
system, and a helper utility to build MEX extensions is provided. All
configuration is conveniently done via debconf.
@@ -35,8 +35,8 @@
Depends: ${misc:Depends}
Conflicts: matlab-dev (<= 0.0.14~)
Replaces: matlab-dev (<= 0.0.14~)
-Description: helpers for packages building Matlab toolboxes
- Analogous to Octave a Makefile snippet is provided that configures the
+Description: helpers for packages building MATLAB toolboxes
+ Analogous to Octave, a Makefile snippet is provided that configures the
locations for architecture independent M-files, binary MEX-extensions, and
there corresponding sources. This package can be used as a build-dependency
- by other packages shipping Matlab toolboxes.
+ by other packages shipping MATLAB toolboxes.
Source: matlab-support
Section: devel
Priority: optional
Maintainer: NeuroDebian Team <team@neuro.debian.net>
Uploaders: Michael Hanke <mih@debian.org>, Yaroslav Halchenko <debian@onerussian.com>
Build-Depends: debhelper (>= 7.0.50~), po-debconf, help2man
Standards-Version: 3.9.1
Vcs-Browser: http://git.debian.org/?p=pkg-exppsy/matlab-support.git
Vcs-Git: git://git.debian.org/git/pkg-exppsy/matlab-support.git
XS-DM-Upload-Allowed: yes
Package: matlab-support
Section: contrib/devel
Architecture: all
Depends: debconf (>=1.3.22) | cdebconf (>= 0.43), ${misc:Depends}, libxp6, sudo
Recommends: libstdc++6-4.4-dev | libstdc++-dev
Conflicts: matlab (<= 0.0.14~)
Replaces: matlab (<= 0.0.14~)
Description: integratation of local MATLAB installations into the system
This package does NOT provide MATLAB. It merely helps sysadmins
integrate local installations in the system to handle this proprietary
software in a more coherent way. Moreover, this package can be used as a
runtime dependency for packages that install MATLAB code and, for example,
need to compile MEX extensions.
.
One or more MATLAB installations can be registered with alternatives
system, and a helper utility to build MEX extensions is provided. All
configuration is conveniently done via debconf.
Package: matlab-support-dev
Section: devel
Architecture: all
Depends: ${misc:Depends}
Conflicts: matlab-dev (<= 0.0.14~)
Replaces: matlab-dev (<= 0.0.14~)
Description: helpers for packages building MATLAB toolboxes
Analogous to Octave, a Makefile snippet is provided that configures the
locations for architecture independent M-files, binary MEX-extensions, and
there corresponding sources. This package can be used as a build-dependency
by other packages shipping MATLAB toolboxes.
Attachment:
signature.asc
Description: Digital signature