Re: [RFR] templates://darcsweb/{templates}
Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
> Template: darcsweb/webserver
> Type: select
> -__Choices: Apache, Apache-SSL, Apache2, All, None
> -Default: Apache2
> -_Description: Webserver type:
> - Which kind of web server should be used by darcsweb
> +__Choices: Apache, None
> +Default: Apache>
> +_Description: Webserver to configure:
> + Please choose the web server you want to configure for use with
> + darcsweb.
> .
> - Select "None" if you would like to configure your webserver by hand.
> + If you choose "None", the web server should be configured manually.
> +
>
> apache-ssl and apache no longer exist. So, the only choice is
> "apache2" or nothing.
Indeed, so s/Apache/Apache2/ above. Apparently it works with
lighttpd and thttpd, so maybe it'll become a real choice again.
We're being inconsistent with "web ?server", and I'd prefer to
emphasise that you aren't choosing to configure Apache2, you're
choosing not to have to.
_Description: Web server to configure:
Please choose the web server that should be configured automatically
for use with darcsweb.
In the control file:
> Depends: ${misc:Depends}, python (>= 2.3), darcs
> Recommends: apache2 | httpd-cgi
What, it still works with no web server installed? That's either a
dependency bug or a use case crying out for documentation...
> Description: web interface for browsing darcs repositories
> + This package provides a simple web interface for darcs, inspired by gitweb.
(Indeed the VCS-Browser for this very package uses gitweb, which
seems odd.)
> .
> It supports browsing records and their diffs, extracting diffs
> against the current head, browsing the current tree, annotate,
> + provides an RSS feed and other similar features.
That sentence has some peculiar syntax - it "supports A-ing, B-ing,
C-ing, D, E-s something and so on"? I'm not sure I'm qualified to
fix it (I'm not a VCS user, so I don't follow the distinction
between browsing records and browsing the current tree), but how
about:
It calls darcs to get most of the data, and supports browsing records
and their diffs, extracting diffs against the current head, or browsing
and annotating the current tree. It can also provide an RSS or Atom
feed, among other features.
(I've put back a phrase we dropped from the first sentence, and added
Atom since that's mentioned upstream (and in darcsweb.cgi).
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
Source: darcsweb
Section: web
Priority: optional
Maintainer: Fabian Linzberger <e@lefant.net>
Uploaders: Erik Wenzel <erik@debian.org>
Build-Depends: debhelper (>= 7), po-debconf
Standards-Version: 3.9.1
Vcs-Browser: http://git.lefant.net/cgi-bin/gitweb.cgi/darcsweb.git
Vcs-Git: git://git.lefant.net/darcsweb.git
Homepage: http://blitiri.com.ar/p/darcsweb/
Package: darcsweb
Architecture: all
Depends: ${misc:Depends}, python (>= 2.3), darcs
Recommends: apache2 | httpd-cgi
Description: web interface for browsing darcs repositories
This package provides a simple web interface for darcs, inspired by gitweb.
.
It calls darcs to get most of the data, and supports browsing records
and their diffs, extracting diffs against the current head, or browsing
and annotating the current tree. It can also provide an RSS or Atom
feed, among other features.
Template: darcsweb/webserver
Type: select
__Choices: Apache, None
Default: Apache
_Description: Web server to configure:
Please choose the web server that should be configured automatically
for use with darcsweb.
.
If you choose "None", the web server should be configured manually.
--- ../darcsweb-1.1.pristine/debian/templates 2010-11-21 12:43:35.000000000 +0000
+++ debian/templates 2010-11-25 19:11:49.000000000 +0000
@@ -1,8 +1,9 @@
Template: darcsweb/webserver
Type: select
-__Choices: Apache, Apache-SSL, Apache2, All, None
-Default: Apache2
-_Description: Webserver type:
- Which kind of web server should be used by darcsweb
+__Choices: Apache, None
+Default: Apache
+_Description: Web server to configure:
+ Please choose the web server that should be configured automatically
+ for use with darcsweb.
.
- Select "None" if you would like to configure your webserver by hand.
+ If you choose "None", the web server should be configured manually.
--- ../darcsweb-1.1.pristine/debian/control 2010-11-21 12:43:35.000000000 +0000
+++ debian/control 2010-11-25 19:16:42.000000000 +0000
@@ -14,10 +14,9 @@
Depends: ${misc:Depends}, python (>= 2.3), darcs
Recommends: apache2 | httpd-cgi
Description: web interface for browsing darcs repositories
- This is a simple web interface for darcs, inspired by gitweb. It's
- written in Python and calls darcs to get most of the data.
- .
- It supports browsing records and their diffs, extracting diffs
- against the current head, browsing the current tree, annotate,
- provides an RSS feed and other stuff like that.
+ This package provides a simple web interface for darcs, inspired by gitweb.
.
+ It calls darcs to get most of the data, and supports browsing records
+ and their diffs, extracting diffs against the current head, or browsing
+ and annotating the current tree. It can also provide an RSS or Atom
+ feed, among other features.
Reply to: