Please find, for review, the debconf templates and packages descriptions for the darcsweb source package.
This review will last from Thursday, November 25, 2010 to Sunday, December 05, 2010.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- darcsweb.old/debian/templates 2010-11-24 08:17:19.209906903 +0100
+++ darcsweb/debian/templates 2010-11-25 07:23:50.411017645 +0100
@@ -1,8 +1,10 @@
Template: darcsweb/webserver
Type: select
-__Choices: Apache, Apache-SSL, Apache2, All, None
-Default: Apache2
-_Description: Webserver type:
- Which kind of web server should be used by darcsweb
+__Choices: Apache, None
+Default: Apache
+_Description: Webserver to configure:
+ Please choose the web server you want to configure for use with
+ darcsweb.
.
- Select "None" if you would like to configure your webserver by hand.
+ If you choose "None", the web server should be configured manually.
+
apache-ssl and apache no longer exist. So, the only choice is
"apache2" or nothing.
The rewritten parts use the common wording we use in such cases. A
little bit clumsy as there's only one choice, but I prefer keeping
"please choose the web server" even if there's only one choice....in
case you later add other webserver software.
--- darcsweb.old/debian/control 2010-11-24 08:17:19.205918337 +0100
+++ darcsweb/debian/control 2010-11-25 07:24:42.243005404 +0100
@@ -14,10 +14,8 @@
Depends: ${misc:Depends}, python (>= 2.3), darcs
Recommends: apache2 | httpd-cgi
Description: web interface for browsing darcs repositories
- This is a simple web interface for darcs, inspired by gitweb. It's
- written in Python and calls darcs to get most of the data.
+ This package provides a simple web interface for darcs, inspired by gitweb.
.
It supports browsing records and their diffs, extracting diffs
against the current head, browsing the current tree, annotate,
- provides an RSS feed and other stuff like that.
- .
+ provides an RSS feed and other similar features.
"This is <foo>" is discouraged in package descriptions.
I'm not sure that the fact that it is written in Python is really
relevant for a user to pick the package or not.
And, at the end, a minor wording fix.
--
Template: darcsweb/webserver Type: select __Choices: Apache, None Default: Apache _Description: Webserver to configure: Please choose the web server you want to configure for use with darcsweb. . If you choose "None", the web server should be configured manually.
--- darcsweb.old/debian/templates 2010-11-24 08:17:19.209906903 +0100
+++ darcsweb/debian/templates 2010-11-25 07:23:50.411017645 +0100
@@ -1,8 +1,10 @@
Template: darcsweb/webserver
Type: select
-__Choices: Apache, Apache-SSL, Apache2, All, None
-Default: Apache2
-_Description: Webserver type:
- Which kind of web server should be used by darcsweb
+__Choices: Apache, None
+Default: Apache
+_Description: Webserver to configure:
+ Please choose the web server you want to configure for use with
+ darcsweb.
.
- Select "None" if you would like to configure your webserver by hand.
+ If you choose "None", the web server should be configured manually.
+
--- darcsweb.old/debian/control 2010-11-24 08:17:19.205918337 +0100
+++ darcsweb/debian/control 2010-11-25 07:24:42.243005404 +0100
@@ -14,10 +14,8 @@
Depends: ${misc:Depends}, python (>= 2.3), darcs
Recommends: apache2 | httpd-cgi
Description: web interface for browsing darcs repositories
- This is a simple web interface for darcs, inspired by gitweb. It's
- written in Python and calls darcs to get most of the data.
+ This package provides a simple web interface for darcs, inspired by gitweb.
.
It supports browsing records and their diffs, extracting diffs
against the current head, browsing the current tree, annotate,
- provides an RSS feed and other stuff like that.
- .
+ provides an RSS feed and other similar features.
Source: darcsweb
Section: web
Priority: optional
Maintainer: Fabian Linzberger <e@lefant.net>
Uploaders: Erik Wenzel <erik@debian.org>
Build-Depends: debhelper (>= 7), po-debconf
Standards-Version: 3.9.1
Vcs-Browser: http://git.lefant.net/cgi-bin/gitweb.cgi/darcsweb.git
Vcs-Git: git://git.lefant.net/darcsweb.git
Homepage: http://blitiri.com.ar/p/darcsweb/
Package: darcsweb
Architecture: all
Depends: ${misc:Depends}, python (>= 2.3), darcs
Recommends: apache2 | httpd-cgi
Description: web interface for browsing darcs repositories
This package provides a simple web interface for darcs, inspired by gitweb.
.
It supports browsing records and their diffs, extracting diffs
against the current head, browsing the current tree, annotate,
provides an RSS feed and other similar features.
Attachment:
signature.asc
Description: Digital signature