[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://astk/{astk.templates}



Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]

One general thing I'm changing throughout is that "astk" becomes
"ASTK" where it refers to the software in general rather than the
astk package.  This is particularly important when we're talking
about "the ASTK server".

Skipped at the top of the astk.templates file:

>  Template: astk/platform
>  Type: select
>  Choices: LINUX, P_LINUX, LINUX64, P_LINUX64
>  Default: LINUX64
>  _Description: aster platform:
>  Select aster platform.

If I understood what information this was asking for, I would
rephrase it to make it clearer.  What's the difference between
this and astk/IFDEF below (which doesn't offer the P_* variants)?
A Google search for P_LINUX64 gets one hit, and that's this very
d-l-e thread - so I don't see how admins are expected to be able to
answer this question. 

>  Template: astk/domainname
>  _Type: string
> +_Description: Domain name for the astk server:
> + Please enter the domain name which this astk server should be a member of.

Servers are members of domains, not members of domain names:

    Please enter the name of the domain which this ASTK server should be a
    member of.

But hang on; this template is astk/domainname (configuring the
_client_ package), not astk-server/domainname, so surely it should
be asking:

   _Description: ASTK server domain name:
    Please enter the domain name of the server that this ASTK client
    should connect to.

(And come to that, why not just ask for the server's FQDN as a single
template, then divide the string into hostname and domainname parts?)

>  Template: astk/servername
>  Type: string
> +_Description: Host name for the astk server:
> + Please enter the server host name without domain name.

(If this was configuring astk-server then you'd think it would at
least offer the contents of /etc/hostname as a default...)

   _Description: ASTK server host name:
    Please enter the host name (without domain name) of the server
    that this ASTK client should connect to.
 
>  Template: astk/node
>  Type: string
> +_Description: Published host name:
> + Please enter the name by which this server will be known on the network. It
> + has to be a unique name in the domain.

You definitely mean "client" here.

   _Description: ASTK client node name:
    Please enter the public name by which this client will be known on
    the network. It must be a unique name within the domain.

I'm assuming ASTK nodenames _aren't_ DNS hostnames, since otherwise
it could answer this question just by reading /etc/hostname.  It's
also possible that the "domain" these templates are talking about is
not a DNS domain - if that's true, it needs further clarification.

>  Template: astk/EDITOR
>  Type: select
>  Choices: nedit, gedit --display=@D, kwrite --display @D, xemacs -display @D, emacs -display @D, xedit -display @D, xterm  -display @D -e @E -e vi
>  Default: nedit

This and astk/TERMINAL seem a bad idea.  On a Debian system, you
don't need to ask what the admin's favourite editor is - facts like
that are already recorded in the alternatives system.  It seems to
me that astk should just be automatically using:
   x-terminal-emulator -e editor
   x-terminal-emulator -e @E
...and then offering individual _users_ the opportunity to customise
these commandlines.

This would also eliminate the need to amend this template every time
a Desktop Environment changes its favourites.  After all, kwrite
wasn't in Lenny; who knows what the line-up will be in Squeeze+1?

>  _Description: favorite Editor.
>   Please select the editor to be used.

My own personal favourite editor?  What if I like emacs, but I
haven't installed it because the developers using this machine
are split between xjove and pico?

Until this is fixed to use the alternatives system I'll suggest
(borrowing from yours below):

   _Description: Standard editor:
    Please select the command line that ASTK should use to launch an
    editor.

> Template: astk/TERMINAL
> Type: select
> Choices: /usr/bin/xterm -display @D -e @E, /usr/bin/gnome-terminal --display=@D --command=@E, /usr/bin/konsole --display @D -e @E
> Default: /usr/bin/gnome-terminal --display=@D --command=@E

Except that gnome-terminal supports -e as well, so surely you'd be
safe going through the x-terminal-emulator symlink?  (If not, that's
a bug in gnome-terminal...)

This also implies a separate bug: the package doesn't express a
dependency on anything that provides x-terminal-emulator.

> +_Description: Command line for launching a terminal window:
> + Please choose the command line that should be used when launching a
> + terminal window is requested.

Until this is fixed to use the alternatives system I'll suggest:

   _Description: Standard terminal emulator:
    Please select the command line that ASTK should use to launch a
    terminal window.

>  Template: astk/MPIRUN
>  Type: select
>  Choices: LAM, OPENMPI, MPICH2
>  Default: OPENMPI
>  _Description: MPI implementation:
>  +Please select the MPI implementation to be used in this ASTK
>   server.                                                            

"This" package that we're configuring is the ASTK client end.

   _Description: ASTK server MPI implementation:
    Please select the MPI implementation used by the server that this
    ASTK client should connect to.

>  Template: astk/IFDEF
>  Type: select
>  Choices: LINUX, LINUX64
>  Default: LINUX64
> +_Description: Platform running "aster":
>   Please select the platform running aster.

I'm hoping that instead of "I'm feeling lazy, parse the output of
dpkg-architecture for me" this means:

   _Description: ASTK server platform:
    Please select the bit width of the server that this ASTK
    client should connect to.
 
Now the control file...

>  Package: astk
>  Architecture: all
>  Section: science
>  Depends: tk8.5 | wish, tcl8.5 | tclsh, debconf (>= 1.5.30), ${misc:Depends}
>  Recommends: astk-server
>  Suggests: eficas, gmsh, grace, nedit, ddd

Oh, eficas is a "coming soon" package.  If it's going to be a
dedicated Aster editor, maybe it should be:

   Recommends: astk-server, eficas | nedit | editor, gnome-terminal | x-terminal-emulator

(But my patch is limiting itself to the wording changes.)

> +Description: Code_Aster build/control system and front-end - Tcl client
>   ASTK includes the Python build and control systems and Tcl front end for the
>   Code_Aster finite element PDE solver.
>   .
> + This package contains the ASTK Tcl front-end client. If you want to run
>   astk/aster on the local host, you need to install python-astk-server as well.
                                                      ^^^^^^^
Surely that should be the package (plain-) astk-server, below?

> I haven't been very invasive here.

Which is fair enough, since there's nothing much technically wrong
with it; but it makes me want to rewrite the whole thing to make the
learning curve a bit less vertical.  The upstream homepage doesn't
offer much in the way of explanation, but Wikipedia's more
informative...

   Description: graphical user interface for Code_Aster - client

(Or maybe it should even claim to be a graphical IDE?)

    Code_Aster is the finite element PDE solver used by the French
    nuclear industry. ASTK provides a Tcl front end to its Python build
    and control systems.
    .
    This package contains the ASTK client, which needs to connect to a
    locally or remotely installed server (in the package "astk-server").

I'd also like to put some meaning-of-the-name clues in there, but
first I need to know whether I'm right to suspect that ASTK is the
Aster Server ToolKit.  Nobody seems to know why it's called
Code_Aster, either (though it makes me hope that someday we'll see a
rival finite-element modelling tool called Forkaster).

>  Package: astk-server
>  Section: python

Everyone else says it's Python and Fortran.

>  Depends: ${python:Depends}, python-numpy, debconf (>= 1.5.30), ${misc:Depends}
>  Suggests: emacs, gdb, ddd

So the client (installed on the developer's machine) suggests nedit,
while the server suggests emacs?  Is it Python, Fortran and Lisp?

> +Description: Code_Aster build/control system and front-end - Python server

   Description: graphical user interface for Code_Aster - server
   [...]
   This package contains the ASTK server, which runs Aster code.     

Mind you, it's not clear to me where it gets this aster code when
the package "aster" has got stuck at the RFP level...
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru astk-orig/astk.templates astk/astk.templates
--- astk-orig/astk.templates	2010-05-14 18:22:45.000000000 +0100
+++ astk/astk.templates	2010-05-22 12:15:06.000000000 +0100
@@ -7,46 +7,50 @@
 
 Template: astk/domainname
 _Type: string
-_Description: astk server domain name:
-  This is the domain your astk server is a member of. Typically it is
-  something like "mycompany.com" or "myuniversity.edu".
+_Description: ASTK server domain name:
+ Please enter the domain name of the server that this ASTK client
+ should connect to.
 
 Template: astk/servername
 Type: string
-_Description: astk server unqualified hostname:
- Please enter the server hostname without domain name.
+_Description: ASTK server host name:
+ Please enter the host name (without domain name) of the server
+ that this ASTK client should connect to.
 
 Template: astk/node
 Type: string
-_Description: hostname:
- This is the name by which this computer will be known on the network. It
- has to be a unique name in your domain.
+_Description: ASTK client node name:
+ Please enter the public name by which this client will be known on
+ the network. It must be a unique name within the domain.
 
 Template: astk/EDITOR
 Type: select
 Choices: nedit, gedit --display=@D, kwrite --display @D, xemacs -display @D, emacs -display @D, xedit -display @D, xterm  -display @D -e @E -e vi
 Default: nedit
-_Description: favorite Editor.
- Please select the editor to be used.
+_Description: Standard editor:
+ Please select the command line that ASTK should use to launch an
+ editor.
 
 Template: astk/TERMINAL
 Type: select
 Choices: /usr/bin/xterm -display @D -e @E, /usr/bin/gnome-terminal --display=@D --command=@E, /usr/bin/konsole --display @D -e @E
 Default: /usr/bin/gnome-terminal --display=@D --command=@E
-_Description: favorite Terminal: 
- Please select the terminal to be used.
+_Description: Standard terminal emulator:
+ Please select the command line that ASTK should use to launch a
+ terminal window.
 
 Template: astk/MPIRUN
 Type: select
 Choices: LAM, OPENMPI, MPICH2
 Default: OPENMPI
-_Description: MPI implementation: 
- Please select the MPI implementation to be used.
+_Description: ASTK server MPI implementation:
+ Please select the MPI implementation used by the server that this ASTK
+ client should connect to.
 
 Template: astk/IFDEF
 Type: select
 Choices: LINUX, LINUX64
 Default: LINUX64
-_Description: "aster" platform.
- Please select the platform running aster.
- 
+_Description: ASTK server bit width:
+ Please select the bit width of the server that this ASTK client should
+ connect to.         
diff -ru astk-orig/control astk/control
--- astk-orig/control	2010-05-14 18:22:46.000000000 +0100
+++ astk/control	2010-05-22 12:33:32.000000000 +0100
@@ -9,27 +9,28 @@
 Vcs-Svn: svn://svn.debian.org/svn/debian-science/packages/code-aster/astk/
 Vcs-Browser: http://svn.debian.org/viewsvn/debian-science/packages/code-aster/astk/
 
-
 Package: astk
 Architecture: all
 Section: science
 Depends: tk8.5 | wish, tcl8.5 | tclsh, debconf (>= 1.5.30), ${misc:Depends}
 Recommends: astk-server
 Suggests: eficas, gmsh, grace, nedit, ddd
-Description: Code_Aster build/control system and front-end: Tcl client
- ASTK includes the Python build and control systems and Tcl front end for the
- Code_Aster finite element PDE solver.
+Description: graphical user interface for Code_Aster - client
+ Code_Aster is the finite element PDE solver used by the French
+ nuclear industry. ASTK provides a Tcl front end to its Python build
+ and control systems.
  .
- This package contains the ASTK Tcl front-end client.  If you want to run
- astk/aster on the local host, you need to install python-astk-server as well.
+ This package contains the ASTK client, which needs to connect to a
+ locally or remotely installed server (in the package "astk-server").
 
 Package: astk-server
 Architecture: all
 Section: python
 Depends: ${python:Depends}, python-numpy, debconf (>= 1.5.30), ${misc:Depends}
 Suggests: emacs, gdb, ddd
-Description: Code_Aster build/control system and front-end: Python server
- ASTK includes the Python build and control systems and Tcl front end for the
- Code_Aster finite element PDE solver.
+Description: graphical user interface for Code_Aster - server
+ Code_Aster is the finite element PDE solver used by the French
+ nuclear industry. ASTK provides a Tcl front end to its Python build
+ and control systems.
  .
- This package contains the astk server which runs aster.
+ This package contains the ASTK server, which runs Aster code.
Template: astk/platform
Type: select
Choices: LINUX, P_LINUX, LINUX64, P_LINUX64
Default: LINUX64
_Description: aster platform:
  Select aster platform.

Template: astk/domainname
_Type: string
_Description: ASTK server domain name:
 Please enter the domain name of the server that this ASTK client
 should connect to.

Template: astk/servername
Type: string
_Description: ASTK server host name:
 Please enter the host name (without domain name) of the server
 that this ASTK client should connect to.

Template: astk/node
Type: string
_Description: ASTK client node name:
 Please enter the public name by which this client will be known on
 the network. It must be a unique name within the domain.

Template: astk/EDITOR
Type: select
Choices: nedit, gedit --display=@D, kwrite --display @D, xemacs -display @D, emacs -display @D, xedit -display @D, xterm  -display @D -e @E -e vi
Default: nedit
_Description: Standard editor:
 Please select the command line that ASTK should use to launch an
 editor.

Template: astk/TERMINAL
Type: select
Choices: /usr/bin/xterm -display @D -e @E, /usr/bin/gnome-terminal --display=@D --command=@E, /usr/bin/konsole --display @D -e @E
Default: /usr/bin/gnome-terminal --display=@D --command=@E
_Description: Standard terminal emulator:
 Please select the command line that ASTK should use to launch a
 terminal window.

Template: astk/MPIRUN
Type: select
Choices: LAM, OPENMPI, MPICH2
Default: OPENMPI
_Description: ASTK server MPI implementation:
 Please select the MPI implementation used by the server that this ASTK
 client should connect to.

Template: astk/IFDEF
Type: select
Choices: LINUX, LINUX64
Default: LINUX64
_Description: ASTK server bit width:
 Please select the bit width of the server that this ASTK client should
 connect to.         
Source: astk
Section: science
Priority: extra
Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org>
Uploaders: Christophe Trophime <christophe.trophime@grenoble.cnrs.fr>, "Adam C. Powell, IV" <hazelsct@debian.org>
Standards-Version: 3.8.4
Build-Depends: debhelper (>= 7), cdbs (>= 0.4.49), quilt, python-all (>= 2.5.4-9), python-support (>= 1.0.7), po-debconf
Homepage: http://www.code-aster.org/
Vcs-Svn: svn://svn.debian.org/svn/debian-science/packages/code-aster/astk/
Vcs-Browser: http://svn.debian.org/viewsvn/debian-science/packages/code-aster/astk/

Package: astk
Architecture: all
Section: science
Depends: tk8.5 | wish, tcl8.5 | tclsh, debconf (>= 1.5.30), ${misc:Depends}
Recommends: astk-server
Suggests: eficas, gmsh, grace, nedit, ddd
Description: graphical user interface for Code_Aster - client
 Code_Aster is the finite element PDE solver used by the French
 nuclear industry. ASTK provides a Tcl front end to its Python build
 and control systems.
 .
 This package contains the ASTK client, which needs to connect to a
 locally or remotely installed server (in the package "astk-server").

Package: astk-server
Architecture: all
Section: python
Depends: ${python:Depends}, python-numpy, debconf (>= 1.5.30), ${misc:Depends}
Suggests: emacs, gdb, ddd
Description: graphical user interface for Code_Aster - server
 Code_Aster is the finite element PDE solver used by the French
 nuclear industry. ASTK provides a Tcl front end to its Python build
 and control systems.
 .
 This package contains the ASTK server, which runs Aster code.

Reply to: