Re: [RFR] templates://vidalia/{templates}
Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
> Template: vidalia/info
> Type: select
> Choices-C: no, yes-now, yes-always
> -_Description: Do you want to stop the existing Tor process and let Vidalia start Tor?
> +_Description: Let Vidalia start Tor after stopping existing Tor process:
> __Choices: No, Yes (just for now), Yes (and disable it for every boot)
> This is a tricky one because this template is a "nearly-boolean" one.
How about this:
_Description: Whether to stop Tor and let Vidalia start it:
It fits the required almost-a-question format a bit more
comfortably, but I think I'm trying to be too clever. I'll leave it
out of the patch.
[...]
> Package: vidalia
(Why-the-name note: I gather this GUI for The Onion Router is named
after a brand of onion famous in the USA.)
(My patch also unnecessarily trims a trailing space on Depends:.)
[...]
> Description: controller GUI for the Tor software
What, as opposed to the Tor hardware?
Description: controller GUI for Tor
> + Vidalia offers a graphical user interface to start and stop Tor, view
> + its status at a glance, and monitor its bandwidth usage.
> + .
> + Vidalia also makes it easy to contribute to
> + the Tor network by helping you setup a Tor server.
^
All good so far, except for the "to set up a setup" gotcha.
> + .
> + Tor protects privacy communications around a distributed
^the ^of within?
> + network of relays run by volunteers all around the world: it prevents
> + somebody watching Internet connections from learning what sites
> + are visited, and it prevents the visited sites from learning your
> + physical location. Tor works with many of existing applications,
XX
> + including web browsers, instant messaging clients, remote login, and
> + other applications based on the TCP protocol.
"Remote login" isn't quite parallel to the others, and the list
starts and ends with the same sort of "and many more" item... not
hard to fix, though:
Tor protects privacy in communications via a distributed network of
relays run by volunteers all around the world: it prevents anybody
watching Internet connections from learning what sites you visit,
and it prevents the visited sites from learning your physical
location. Tor works with web browsers, instant messaging programs,
remote login clients, and many other TCP-based applications.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../vidalia-0.2.7.pristine/debian/templates 2010-04-08 06:56:58.000000000 +0100
+++ debian/templates 2010-04-16 20:55:37.000000000 +0100
@@ -1,5 +1,5 @@
Template: vidalia/info
Type: select
Choices-C: no, yes-now, yes-always
-_Description: Do you want to stop the existing Tor process and let Vidalia start Tor?
+_Description: Let Vidalia start Tor after stopping existing Tor process:
__Choices: No, Yes (just for now), Yes (and disable it for every boot)
--- ../vidalia-0.2.7.pristine/debian/control 2010-04-08 06:56:58.000000000 +0100
+++ debian/control 2010-04-16 20:58:01.000000000 +0100
@@ -9,12 +9,19 @@
Package: vidalia
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, debconf (>=1.5.11) | debconf-2.0, ucf
+Depends: ${shlibs:Depends}, ${misc:Depends}, debconf (>=1.5.11) | debconf-2.0, ucf
Recommends: tor
Suggests: iceweasel-torbutton
-Description: controller GUI for the Tor software
- Vidalia allows you to start and stop Tor, view the status of Tor at a glance,
- and monitor Tor's bandwidth usage. Vidalia also makes it easy to contribute to
- the Tor network by helping you setup a Tor server, if you wish. To find more
- information about what Tor is and how to use it, see the Tor homepage:
- https://www.torproject.org/
+Description: controller GUI for Tor
+ Vidalia offers a graphical user interface to start and stop Tor, view
+ its status at a glance, and monitor its bandwidth usage.
+ .
+ Vidalia also makes it easy to contribute to
+ the Tor network by helping you set up a Tor server.
+ .
+ Tor protects privacy in communications via a distributed network of
+ relays run by volunteers all around the world: it prevents anybody
+ watching Internet connections from learning what sites you visit,
+ and it prevents the visited sites from learning your physical
+ location. Tor works with web browsers, instant messaging programs,
+ remote login clients, and many other TCP-based applications.
Template: vidalia/info
Type: select
Choices-C: no, yes-now, yes-always
_Description: Let Vidalia start Tor after stopping existing Tor process:
__Choices: No, Yes (just for now), Yes (and disable it for every boot)
Source: vidalia
Section: net
Priority: extra
Maintainer: Vern Sun <s5unty@gmail.com>
Uploaders: Ulises Vitulli <uvitulli@fi.uba.ar>, Erinn Clark <erinn@torproject.org>
Build-Depends: debhelper (>= 5), autotools-dev, libqt4-dev (>= 4.1.0), po-debconf (>= 1.0), cmake (>= 2.4.8), libssl-dev (>= 0.9.8g), quilt
Standards-Version: 3.8.4
Homepage: http://www.vidalia-project.net
Package: vidalia
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf (>=1.5.11) | debconf-2.0, ucf
Recommends: tor
Suggests: iceweasel-torbutton
Description: controller GUI for Tor
Vidalia offers a graphical user interface to start and stop Tor, view
its status at a glance, and monitor its bandwidth usage.
.
Vidalia also makes it easy to contribute to
the Tor network by helping you set up a Tor server.
.
Tor protects privacy in communications via a distributed network of
relays run by volunteers all around the world: it prevents anybody
watching Internet connections from learning what sites you visit,
and it prevents the visited sites from learning your physical
location. Tor works with web browsers, instant messaging programs,
remote login clients, and many other TCP-based applications.
Reply to: