[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://vidalia/{templates}



Please find, for review, the debconf templates and packages descriptions for the vidalia source package.

This review will last from Friday, April 16, 2010 to Monday, April 26, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- vidalia.old/debian/templates	2010-04-07 08:22:54.470657509 +0200
+++ vidalia/debian/templates	2010-04-16 19:42:02.433388081 +0200
@@ -1,5 +1,5 @@
 Template: vidalia/info
 Type: select
 Choices-C: no, yes-now, yes-always
-_Description: Do you want to stop the existing Tor process and let Vidalia start Tor?
+_Description: Let Vidalia start Tor after stopping existing Tor process:
 __Choices: No, Yes (just for now), Yes (and disable it for every boot)
--- vidalia.old/debian/control	2010-04-07 08:22:54.470657509 +0200
+++ vidalia/debian/control	2010-04-16 19:48:49.841391727 +0200

This is a tricky one because this template is a "nearly-boolean" one.

You made great use of Choices-C and I was very close to leave the
template unchanged, indeed.

Still, I was slightly annoyed by the use of interrogative form with a
Select template so I tried to find another way....Not perfect IMHO, though.

@@ -13,8 +13,16 @@
 Recommends: tor
 Suggests: iceweasel-torbutton
 Description: controller GUI for the Tor software
- Vidalia allows you to start and stop Tor, view the status of Tor at a glance,
- and monitor Tor's bandwidth usage. Vidalia also makes it easy to contribute to
- the Tor network by helping you setup a Tor server, if you wish. To find more
- information about what Tor is and how to use it, see the Tor homepage:
- https://www.torproject.org/
+ Vidalia offers a graphical user interface to start and stop Tor, view
+ its status at a glance, and monitor its bandwidth usage. 
+ .
+ Vidalia also makes it easy to contribute to
+ the Tor network by helping you setup a Tor server.
+ .
+ Tor protects privacy communications around a distributed
+ network of relays run by volunteers all around the world: it prevents
+ somebody watching Internet connections from learning what sites
+ are visited, and it prevents the visited sites from learning your
+ physical location. Tor works with many of existing applications,
+ including web browsers, instant messaging clients, remote login, and
+ other applications based on the TCP protocol.

I splitted the paragraph in two and tried to slightly "unpersonnalize"
things by dropping some of the "you"s.

Here again, this is a broder case as Tor being about privacy
protection, it is more or less by definition  protecting a
"you". Anyway, one can also argue that the Tor server running on my
home server is indeed proctecting my entire family's privacy.

I also added a paragraph about "what is Tor". It is taken from the
project's web site with minor modifications.

Feel free to amend this..:)

And now I should go and setup my own Tor server...

-- 


Template: vidalia/info
Type: select
Choices-C: no, yes-now, yes-always
_Description: Let Vidalia start Tor after stopping existing Tor process:
__Choices: No, Yes (just for now), Yes (and disable it for every boot)
--- vidalia.old/debian/templates	2010-04-07 08:22:54.470657509 +0200
+++ vidalia/debian/templates	2010-04-16 19:42:02.433388081 +0200
@@ -1,5 +1,5 @@
 Template: vidalia/info
 Type: select
 Choices-C: no, yes-now, yes-always
-_Description: Do you want to stop the existing Tor process and let Vidalia start Tor?
+_Description: Let Vidalia start Tor after stopping existing Tor process:
 __Choices: No, Yes (just for now), Yes (and disable it for every boot)
--- vidalia.old/debian/control	2010-04-07 08:22:54.470657509 +0200
+++ vidalia/debian/control	2010-04-16 19:48:49.841391727 +0200
@@ -13,8 +13,16 @@
 Recommends: tor
 Suggests: iceweasel-torbutton
 Description: controller GUI for the Tor software
- Vidalia allows you to start and stop Tor, view the status of Tor at a glance,
- and monitor Tor's bandwidth usage. Vidalia also makes it easy to contribute to
- the Tor network by helping you setup a Tor server, if you wish. To find more
- information about what Tor is and how to use it, see the Tor homepage:
- https://www.torproject.org/
+ Vidalia offers a graphical user interface to start and stop Tor, view
+ its status at a glance, and monitor its bandwidth usage. 
+ .
+ Vidalia also makes it easy to contribute to
+ the Tor network by helping you setup a Tor server.
+ .
+ Tor protects privacy communications around a distributed
+ network of relays run by volunteers all around the world: it prevents
+ somebody watching Internet connections from learning what sites
+ are visited, and it prevents the visited sites from learning your
+ physical location. Tor works with many of existing applications,
+ including web browsers, instant messaging clients, remote login, and
+ other applications based on the TCP protocol.
Source: vidalia
Section: net
Priority: extra
Maintainer: Vern Sun <s5unty@gmail.com>
Uploaders: Ulises Vitulli <uvitulli@fi.uba.ar>, Erinn Clark <erinn@torproject.org>
Build-Depends: debhelper (>= 5), autotools-dev, libqt4-dev (>= 4.1.0), po-debconf (>= 1.0), cmake (>= 2.4.8), libssl-dev (>= 0.9.8g), quilt
Standards-Version: 3.8.4
Homepage: http://www.vidalia-project.net

Package: vidalia
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf (>=1.5.11) | debconf-2.0, ucf 
Recommends: tor
Suggests: iceweasel-torbutton
Description: controller GUI for the Tor software
 Vidalia offers a graphical user interface to start and stop Tor, view
 its status at a glance, and monitor its bandwidth usage. 
 .
 Vidalia also makes it easy to contribute to
 the Tor network by helping you setup a Tor server.
 .
 Tor protects privacy communications around a distributed
 network of relays run by volunteers all around the world: it prevents
 somebody watching Internet connections from learning what sites
 are visited, and it prevents the visited sites from learning your
 physical location. Tor works with many of existing applications,
 including web browsers, instant messaging clients, remote login, and
 other applications based on the TCP protocol.

Attachment: signature.asc
Description: Digital signature


Reply to: