[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://iog/{iog.templates}



Please find, for review, the debconf templates and packages descriptions for the iog source package.

This review will last from Wednesday, February 03, 2010 to Saturday, February 13, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- iog.old/debian/iog.templates	2010-01-25 08:48:52.487674190 +0100
+++ iog/debian/iog.templates	2010-01-30 09:53:25.426839850 +0100
@@ -1,13 +1,15 @@
 Template: iog/migrate
 Type: boolean
 Default: false
-_Description: Migrate old install out of '/var/www/iog/'?
+_Description: Migrate old install out of /var/www/iog/?

We generally don't recommend using quotes for file and directory names.


  It was detected that a previous package release has data installed in the
- directory '/var/www/iog/'. The present IOG package suggests the use of
- '/var/lib/iog/' for the same purpose.
+ /var/www/iog/ directory. Current versions of the IOG package now use
+ /var/lib/iog/ IOG data files.


Ditto.

Avoid using "the present package". Packages don't suggest
anything...they just do things..:-)

  .
- Accepting migration will move all old network data to the new location.
+ If you choose this option, all existing network data will be moved
+ to the new location.

Use our commonly recommended style. Also avoids having a verb being
the subject of a sentence. This is not "accepting the migration" that
migrates the data....but the script..:-)

  .
- By changing the directory pointers to '/var/lib/iog' in the configuration
- '/etc/iog.cfg', and writing an alias declaration for the web server,
- IOG will then serve uninterrupted statistics also after the upgrade.
+ Consequently, directory settings in the IOG configuration file
+ (/etc/iog.cfg) will be changed to /var/lib/iog and a web server
+ alias declaration will be added so that old network statistics
+ are still published.

IOG will not change directory pointers and write an alias. That will
be done by the maintainer scripts.

--- iog.old/debian/control	2010-01-25 08:48:52.483673520 +0100
+++ iog/debian/control	2010-01-30 09:54:51.370812282 +0100
@@ -5,18 +5,17 @@
 Build-Depends: debhelper (>> 3.0.0)
 Build-Depends-Indep: po-debconf
 Standards-Version: 3.5.2
+Homepage: http://www.dynw.com/iog/
 
Use Homepage field.


 Package: iog
 Architecture: all
 Depends: libsnmp-session-perl, ucf, debconf, ${misc:Depends}
 Recommends: snmpd
-Description: Network I/O byte grapher
- IOG is a network I/O byte grapher made to graph cumulative KB/MB/GB
- totals for hours/days and months. It is intended to be simple, fast
+Description: network traffic grapher
+ IOG is a network I/O byte grapher made to graph cumulative network
+ traffic statistics over time. It is intended to be simple, fast
  (support thousands of hosts) and integrate well with MRTG. Data for
  each host is updated hourly and HTML graphs are created. It uses a
  data consolidation algorithm which allows for a small, non-growing
- database file for each host. No external graphing libs or
+ database file for each host. No external graphing libraries or
  executables are required.
- .
- Website: http://www.dynw.com/iog/

uncapitalize the synopsis as recommendend in the Developer's Reference

IOG does not make kilobytes/megabytes....it does network traffic
statistics. And it does it "over time"

s/libs/libraries: small unjargonization

-- 


Template: iog/migrate
Type: boolean
Default: false
_Description: Migrate old install out of /var/www/iog/?
 It was detected that a previous package release has data installed in the
 /var/www/iog/ directory. Current versions of the IOG package now use
 /var/lib/iog/ IOG data files.
 .
 If you choose this option, all existing network data will be moved
 to the new location.
 .
 Consequently, directory settings in the IOG configuration file
 (/etc/iog.cfg) will be changed to /var/lib/iog and a web server
 alias declaration will be added so that old network statistics
 are still published.
--- iog.old/debian/iog.templates	2010-01-25 08:48:52.487674190 +0100
+++ iog/debian/iog.templates	2010-02-03 07:39:51.544995584 +0100
@@ -1,13 +1,15 @@
 Template: iog/migrate
 Type: boolean
 Default: false
-_Description: Migrate old install out of '/var/www/iog/'?
+_Description: Migrate old install out of /var/www/iog/?
  It was detected that a previous package release has data installed in the
- directory '/var/www/iog/'. The present IOG package suggests the use of
- '/var/lib/iog/' for the same purpose.
+ /var/www/iog/ directory. Current versions of the IOG package now use
+ /var/lib/iog/ IOG data files.
  .
- Accepting migration will move all old network data to the new location.
+ If you choose this option, all existing network data will be moved
+ to the new location.
  .
- By changing the directory pointers to '/var/lib/iog' in the configuration
- '/etc/iog.cfg', and writing an alias declaration for the web server,
- IOG will then serve uninterrupted statistics also after the upgrade.
+ Consequently, directory settings in the IOG configuration file
+ (/etc/iog.cfg) will be changed to /var/lib/iog and a web server
+ alias declaration will be added so that old network statistics
+ are still published.
--- iog.old/debian/control	2010-01-25 08:48:52.483673520 +0100
+++ iog/debian/control	2010-01-30 09:54:51.370812282 +0100
@@ -5,18 +5,17 @@
 Build-Depends: debhelper (>> 3.0.0)
 Build-Depends-Indep: po-debconf
 Standards-Version: 3.5.2
+Homepage: http://www.dynw.com/iog/
 
 Package: iog
 Architecture: all
 Depends: libsnmp-session-perl, ucf, debconf, ${misc:Depends}
 Recommends: snmpd
-Description: Network I/O byte grapher
- IOG is a network I/O byte grapher made to graph cumulative KB/MB/GB
- totals for hours/days and months. It is intended to be simple, fast
+Description: network traffic grapher
+ IOG is a network I/O byte grapher made to graph cumulative network
+ traffic statistics over time. It is intended to be simple, fast
  (support thousands of hosts) and integrate well with MRTG. Data for
  each host is updated hourly and HTML graphs are created. It uses a
  data consolidation algorithm which allows for a small, non-growing
- database file for each host. No external graphing libs or
+ database file for each host. No external graphing libraries or
  executables are required.
- .
- Website: http://www.dynw.com/iog/
Source: iog
Section: net
Priority: extra
Maintainer: Mark Purcell <msp@debian.org>
Build-Depends: debhelper (>> 3.0.0)
Build-Depends-Indep: po-debconf
Standards-Version: 3.5.2
Homepage: http://www.dynw.com/iog/

Package: iog
Architecture: all
Depends: libsnmp-session-perl, ucf, debconf, ${misc:Depends}
Recommends: snmpd
Description: network traffic grapher
 IOG is a network I/O byte grapher made to graph cumulative network
 traffic statistics over time. It is intended to be simple, fast
 (support thousands of hosts) and integrate well with MRTG. Data for
 each host is updated hourly and HTML graphs are created. It uses a
 data consolidation algorithm which allows for a small, non-growing
 database file for each host. No external graphing libraries or
 executables are required.

Attachment: signature.asc
Description: Digital signature


Reply to: