[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://netams/{netams.templates,netams-web.templates}



Please find, for review, the debconf templates and packages descriptions for the netams source package.

This review will last from Wednesday, December 30, 2009 to Saturday, January 09, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- netams.old/debian/netams.templates	2009-12-30 14:09:36.967745387 +0100
+++ netams/debian/netams.templates	2009-12-30 19:50:35.612743440 +0100
@@ -3,23 +3,25 @@
 Choices: apache2, lighttpd
 _Description: Web server to reconfigure automatically:
  Please choose the web server that should be automatically configured
- to show NeTAMS statistics.
+ for NeTAMS statistics.

Debatable. The origiinal was IMHO correct and I only prefer my version..:-)
 
 Template: netams/admin-password
 Type: password
 _Description: NeTAMS administrator password:
- Please enter password for "admin" user in NeTAMS database.
+ Please enter the password for the 'admin' user of NeTAMS.

Correct use of articles. Simple quotes (I have a doubt here as we
didn't do reviews for quite a while: did we standardize on single or
double quotes?).

 
 Template: netams/admin-password-again
 Type: password
-_Description: Repeat password for NeTAMS user "admin":
+_Description: NeTAMS administrator password confirmation:
 
Standard prompt for password confirmations.

 Template: netams/password-mismatch
 Type: error
-_Description: Password input error!
- The two passwords you entered were not the same. Please try again.
+_Description: Password mismatch
+ The two passwords you entered were not the same. Please enter a password
+ again.

Avoid exclamation mark.

I actually re-used the similar template we have in Debian Installer.

 
 Template: netams/password-empty
 Type: error
-_Description: Password input error!
- Please enter non-empty password.
+_Description: Empty password
+ You entered an empty password, which is not allowed. Please choose a non-
+ empty password.

Again re-using D-I template.

--- netams.old/debian/netams-web.templates	2009-12-30 14:09:36.971752261 +0100
+++ netams/debian/netams-web.templates	2009-12-30 19:53:50.087745398 +0100
@@ -3,4 +3,4 @@
 Choices: apache2, lighttpd
 _Description: Web server to reconfigure automatically:
  Please choose the web server that should be automatically configured
- to show NeTAMS webinterface.
+ for NeTAMS.

"webinterface" is not wished (more jargonic than correct English). In
general, packages that are doing such prompting use the "configure for
<foo>" style.

--- netams.old/debian/control	2009-12-30 14:09:36.963744870 +0100
+++ netams/debian/control	2009-12-30 19:53:47.440753178 +0100
@@ -13,9 +13,9 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, dbconfig-common, lsb-base, dbconfig-common, lsb-base
 Recommends: netams-web, apache2|lighttpd|httpd
 Suggests: mysql-server|postgresql
-Description: Network Traffic Accounting and Monitoring Software
+Description: network traffic accounting and monitoring

Even though the capitals are a way to relate the package acronym to
its meaning, it is quite ugly in a short description. Also,
"software", here, is discouraged.

Moreover, we explain the acronym later on so we can just drop the capitals.

  NeTAMS stands for Network Traffic Accounting and Monitoring Software.
- It is built for UNIX and works for networks with Cisco routers or PC Unix
+ It works for networks with Cisco routers or Unix-based

We provide the software in a Unix-like environment (Debian) so no need
to explain that the software is for Unix..:-)

The routers are not necessarily PCs. They can be Sun machines, or the
various diskless stuff such as NSLU2....

  routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
  supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
  database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
@@ -24,15 +24,25 @@
  assignmant violations, RADIUS services, create a flexible accounting and
  filtering policies.
  .
- This package contains netams daemon.
+ This package provides the main daemon for NetAMS.

Standard formulation.
 
 Package: netams-dbg
 Architecture: any
 Section: debug
 Priority: extra
 Depends: netams (= ${binary:Version}), ${misc:Depends}
-Description: Debug symbols for the NeTAMS
- This package includes the debugging symbols for NeTAMS.
+Description: debug symbols for NeTAMS

Uncapitalize

+ NeTAMS stands for Network Traffic Accounting and Monitoring Software.
+ It works for networks with Cisco routers or Unix-based
+ routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
+ supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
+ database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
+ visualization, notification etc. It is possible to block traffic based on
+ quotas, web authorization, account balance (billing); manage bandwidth, MAC
+ assignmant violations, RADIUS services, create a flexible accounting and
+ filtering policies.
+ .
+ This package provides NetAMS debugging symbols.

re-use the boilerplate here. Same for the last binary package.
 

Template: netams/reconfigure-webserver
Type: multiselect
Choices: apache2, lighttpd
_Description: Web server to reconfigure automatically:
 Please choose the web server that should be automatically configured
 for NeTAMS statistics.

Template: netams/admin-password
Type: password
_Description: NeTAMS administrator password:
 Please enter the password for the 'admin' user of NeTAMS.

Template: netams/admin-password-again
Type: password
_Description: NeTAMS administrator password confirmation:

Template: netams/password-mismatch
Type: error
_Description: Password mismatch
 The two passwords you entered were not the same. Please enter a password
 again.

Template: netams/password-empty
Type: error
_Description: Empty password
 You entered an empty password, which is not allowed. Please choose a non-
 empty password.
Template: netams-web/reconfigure-webserver
Type: multiselect
Choices: apache2, lighttpd
_Description: Web server to reconfigure automatically:
 Please choose the web server that should be automatically configured
 for NeTAMS.
--- netams.old/debian/netams.templates	2009-12-30 14:09:36.967745387 +0100
+++ netams/debian/netams.templates	2009-12-30 19:55:17.551745044 +0100
@@ -3,23 +3,25 @@
 Choices: apache2, lighttpd
 _Description: Web server to reconfigure automatically:
  Please choose the web server that should be automatically configured
- to show NeTAMS statistics.
+ for NeTAMS statistics.
 
 Template: netams/admin-password
 Type: password
 _Description: NeTAMS administrator password:
- Please enter password for "admin" user in NeTAMS database.
+ Please enter the password for the 'admin' user of NeTAMS.
 
 Template: netams/admin-password-again
 Type: password
-_Description: Repeat password for NeTAMS user "admin":
+_Description: NeTAMS administrator password confirmation:
 
 Template: netams/password-mismatch
 Type: error
-_Description: Password input error!
- The two passwords you entered were not the same. Please try again.
+_Description: Password mismatch
+ The two passwords you entered were not the same. Please enter a password
+ again.
 
 Template: netams/password-empty
 Type: error
-_Description: Password input error!
- Please enter non-empty password.
+_Description: Empty password
+ You entered an empty password, which is not allowed. Please choose a non-
+ empty password.
--- netams.old/debian/netams-web.templates	2009-12-30 14:09:36.971752261 +0100
+++ netams/debian/netams-web.templates	2009-12-30 19:53:50.087745398 +0100
@@ -3,4 +3,4 @@
 Choices: apache2, lighttpd
 _Description: Web server to reconfigure automatically:
  Please choose the web server that should be automatically configured
- to show NeTAMS webinterface.
+ for NeTAMS.
--- netams.old/debian/control	2009-12-30 14:09:36.963744870 +0100
+++ netams/debian/control	2009-12-30 19:53:47.440753178 +0100
@@ -13,9 +13,9 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, dbconfig-common, lsb-base, dbconfig-common, lsb-base
 Recommends: netams-web, apache2|lighttpd|httpd
 Suggests: mysql-server|postgresql
-Description: Network Traffic Accounting and Monitoring Software
+Description: network traffic accounting and monitoring
  NeTAMS stands for Network Traffic Accounting and Monitoring Software.
- It is built for UNIX and works for networks with Cisco routers or PC Unix
+ It works for networks with Cisco routers or Unix-based
  routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
  supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
  database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
@@ -24,15 +24,25 @@
  assignmant violations, RADIUS services, create a flexible accounting and
  filtering policies.
  .
- This package contains netams daemon.
+ This package provides the main daemon for NetAMS.
 
 Package: netams-dbg
 Architecture: any
 Section: debug
 Priority: extra
 Depends: netams (= ${binary:Version}), ${misc:Depends}
-Description: Debug symbols for the NeTAMS
- This package includes the debugging symbols for NeTAMS.
+Description: debug symbols for NeTAMS
+ NeTAMS stands for Network Traffic Accounting and Monitoring Software.
+ It works for networks with Cisco routers or Unix-based
+ routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
+ supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
+ database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
+ visualization, notification etc. It is possible to block traffic based on
+ quotas, web authorization, account balance (billing); manage bandwidth, MAC
+ assignmant violations, RADIUS services, create a flexible accounting and
+ filtering policies.
+ .
+ This package provides NetAMS debugging symbols.
 
 Package: netams-web
 Architecture: all
@@ -41,13 +51,13 @@
 Suggests: netams
 Description: NetAMS's web-interface
  NeTAMS stands for Network Traffic Accounting and Monitoring Software.
- It is built for UNIX and works for networks with Cisco routers or PC
- Unix routers (Linux/FreeBSD/Solaris). Several methods of traffic
- gathering are supported (tee/divert/ip_queue/libpcap/ulog/netflow v5
- and v9/netgraph), database storage (BerkleyDB/MySQL/PostgresSQL/
- Oracle/Radius), aggregation, visualization, notification etc. It is
- possible to block traffic based on quotas, web authorization, account
- balance (billing); manage bandwidth, MAC assignmant violations, RADIUS
- services, create a flexible accounting and filtering policies.
+ It works for networks with Cisco routers or Unix-based
+ routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
+ supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
+ database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
+ visualization, notification etc. It is possible to block traffic based on
+ quotas, web authorization, account balance (billing); manage bandwidth, MAC
+ assignmant violations, RADIUS services, create a flexible accounting and
+ filtering policies.
  .
- This package contain admin and user web-interface for netams server.
+ This package provides a web interface for using and administering the NetAMS server.
Source: netams
Section: net
Priority: optional
Maintainer: Alexander GQ Gerasiov <gq@debian.org>
Build-Depends: debhelper (>= 7.0.0), libmysqlclient15-dev, libnetfilter-queue-dev, libpcap0.8-dev, cdbs, po-debconf, libglib2.0-dev
Standards-Version: 3.8.3
Homepage: http://www.netams.com
Vcs-Git: git://git.gq.net.ru/netams.git
Vcs-Browser: http://git.gq.net.ru/?p=netams.git

Package: netams
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, dbconfig-common, lsb-base, dbconfig-common, lsb-base
Recommends: netams-web, apache2|lighttpd|httpd
Suggests: mysql-server|postgresql
Description: network traffic accounting and monitoring
 NeTAMS stands for Network Traffic Accounting and Monitoring Software.
 It works for networks with Cisco routers or Unix-based
 routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
 supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
 database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
 visualization, notification etc. It is possible to block traffic based on
 quotas, web authorization, account balance (billing); manage bandwidth, MAC
 assignmant violations, RADIUS services, create a flexible accounting and
 filtering policies.
 .
 This package provides the main daemon for NetAMS.

Package: netams-dbg
Architecture: any
Section: debug
Priority: extra
Depends: netams (= ${binary:Version}), ${misc:Depends}
Description: debug symbols for NeTAMS
 NeTAMS stands for Network Traffic Accounting and Monitoring Software.
 It works for networks with Cisco routers or Unix-based
 routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
 supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
 database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
 visualization, notification etc. It is possible to block traffic based on
 quotas, web authorization, account balance (billing); manage bandwidth, MAC
 assignmant violations, RADIUS services, create a flexible accounting and
 filtering policies.
 .
 This package provides NetAMS debugging symbols.

Package: netams-web
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}, apache2|httpd-cgi, libcrypt-generatepassword-perl, libgd-gd2-perl
Recommends: libdbd-mysql-perl|libdbd-pg-perl
Suggests: netams
Description: NetAMS's web-interface
 NeTAMS stands for Network Traffic Accounting and Monitoring Software.
 It works for networks with Cisco routers or Unix-based
 routers (Linux/FreeBSD/Solaris). Several methods of traffic gathering are
 supported (tee/divert/ip_queue/libpcap/ulog/netflow v5 and v9/netgraph),
 database storage (BerkleyDB/MySQL/PostgresSQL/Oracle/Radius), aggregation,
 visualization, notification etc. It is possible to block traffic based on
 quotas, web authorization, account balance (billing); manage bandwidth, MAC
 assignmant violations, RADIUS services, create a flexible accounting and
 filtering policies.
 .
 This package provides a web interface for using and administering the NetAMS server.

Attachment: signature.asc
Description: Digital signature


Reply to: