[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://sinfo/{sinfo.templates}



Please find, for review, the debconf templates of sinfo.

This review will last from Wednesday, October 14, 2009 to Saturday, October 24, 2009.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.


Rationale:

--- ../sinfo.old/debian/sinfo.templates	2009-10-10 21:47:53.000000000 +0300
+++ debian/sinfo.templates	2009-10-14 21:52:15.000000000 +0300
@@ -1,7 +1,7 @@
 Template: sinfo/cgi
 Type: boolean
 Default: false
-_Description: Enable the CGI interface to sinfo?
- Sinfo includes a CGI-script which provides a web-interface
- to sinfo. The CGI-script may publish information about
- your computer you don't want to make available to the public.
+_Description: Enable the sinfo CGI interface?
+ The sinfo package includes a CGI script web interface for sinfo. It is
+ disabled by default as it might publish information the computer not
+ intended to be public.

Simplify sentences and give the explanation as a rationale for the default 
value.

--- ../sinfo.old/debian/control	2009-10-10 21:47:53.000000000 +0300
+++ debian/control	2009-10-14 21:05:07.000000000 +0300
@@ -9,11 +9,11 @@
 Architecture: any
 Depends: debconf, ${shlibs:Depends}, ${misc:Depends}
 Conflicts: slurm-llnl
-Description: Monitoring tool for computer clusters using broadcasts
+Description: tool for monitoring computer clusters using broadcasts

Clarify that it is this tool that uses the broadcasts.

  Sinfo is a monitoring tool that uses network broadcasts to distribute
- information about the status of a cluster node on your local network. It
+ information about the status of cluster nodes on your local network. It
  broadcasts CPU, memory usage, network load, and information about the top
  5 processes of each computer. Sinfo consists of a daemon running on each
- node to distribute the information and an ncurses frontend to monitor the
+ node distributing the information and an ncurses frontend to monitor the
  nodes.
 Homepage: http://www.ant.uni-bremen.de/whomes/rinas/sinfo/

Just some tweaking of the language. Hopefully to more correct. :-)
Template: sinfo/cgi
Type: boolean
Default: false
_Description: Enable the sinfo CGI interface?
 The sinfo package includes a CGI script web interface for sinfo. It is
 disabled by default as it might publish information the computer not
 intended to be public.
--- ../sinfo.old/debian/sinfo.templates	2009-10-10 21:47:53.000000000 +0300
+++ debian/sinfo.templates	2009-10-14 21:52:15.000000000 +0300
@@ -1,7 +1,7 @@
 Template: sinfo/cgi
 Type: boolean
 Default: false
-_Description: Enable the CGI interface to sinfo?
- Sinfo includes a CGI-script which provides a web-interface
- to sinfo. The CGI-script may publish information about
- your computer you don't want to make available to the public.
+_Description: Enable the sinfo CGI interface?
+ The sinfo package includes a CGI script web interface for sinfo. It is
+ disabled by default as it might publish information the computer not
+ intended to be public.
--- ../sinfo.old/debian/control	2009-10-10 21:47:53.000000000 +0300
+++ debian/control	2009-10-14 21:05:07.000000000 +0300
@@ -9,11 +9,11 @@
 Architecture: any
 Depends: debconf, ${shlibs:Depends}, ${misc:Depends}
 Conflicts: slurm-llnl
-Description: Monitoring tool for computer clusters using broadcasts
+Description: tool for monitoring computer clusters using broadcasts
  Sinfo is a monitoring tool that uses network broadcasts to distribute
- information about the status of a cluster node on your local network. It
+ information about the status of cluster nodes on your local network. It
  broadcasts CPU, memory usage, network load, and information about the top
  5 processes of each computer. Sinfo consists of a daemon running on each
- node to distribute the information and an ncurses frontend to monitor the
+ node distributing the information and an ncurses frontend to monitor the
  nodes.
 Homepage: http://www.ant.uni-bremen.de/whomes/rinas/sinfo/
Source: sinfo
Section: net
Priority: optional
Maintainer: Juergen Rinas <jrinas@gmx.de>
Build-Depends: debhelper (>= 7.0.0), libncurses5-dev, libboost-dev, libboost-signals-dev, libboost-regex-dev, libasio-dev, po-debconf
Standards-Version: 3.8.0.0

Package: sinfo
Architecture: any
Depends: debconf, ${shlibs:Depends}, ${misc:Depends}
Conflicts: slurm-llnl
Description: tool for monitoring computer clusters using broadcasts
 Sinfo is a monitoring tool that uses network broadcasts to distribute
 information about the status of cluster nodes on your local network. It
 broadcasts CPU, memory usage, network load, and information about the top
 5 processes of each computer. Sinfo consists of a daemon running on each
 node distributing the information and an ncurses frontend to monitor the
 nodes.
Homepage: http://www.ant.uni-bremen.de/whomes/rinas/sinfo/

Attachment: signature.asc
Description: Digital signature


Reply to: