[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://jack-audio-connection-kit/{jackd.templates}



Jonathan Wiltshire wrote:
> Your review should be sent as an answer to this mail.

This time it's genuine no-hyphen realtime.
 
> --- /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit.old/debian/jackd.templates	2009-07-26 20:15:56.000000000 +0100
> +++ /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit/debian/jackd.templates	2009-09-21 22:30:19.000000000 +0100
> @@ -1,17 +1,12 @@
>  Template: jackd/tweak_rt_limits
[...]
> + To run jackd with realtime priority, the user starting jackd
> + needs realtime permissions. The installer can enable realtime priority
> + for the audio group in /etc/security/limits.d/audio.conf.
>   .
> + Running jackd with realtime priority minimizes latency, but
> + may lead to complete system lock-ups by requesting
>   all the available physical system memory, which is unacceptable in
>   multi-user environments.

I notice you've taken out the references to the fact that a "yes"
will give a limits.d entry saying "@audio -  memlock unlimited".
The reasoning behind this memlock line is a bit controversial (see
bug #507248, and note that even the jackd README.Debian doesn't
recommend changing memlock settings) but this debconf question looks
like a good solution, as long as it's an informed decision:

    To run jackd with realtime priority, the user starting jackd
    needs realtime permissions. Accept this option to create the
    file /etc/security/limits.d/audio.conf, granting realtime
    priority and memlock privileges to the audio group.

I'm also trying not to talk about the installer, since (as the
limits.d file points out) you can revisit it with dpkg-reconfigure.

> --- /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit.old/debian/control	2009-07-26 20:15:56.000000000 +0100
> +++ /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit/debian/control	2009-09-21 22:31:14.000000000 +0100
> @@ -46,8 +46,6 @@

>  Description: JACK Audio Connection Kit (server and example clients) 
>   Low-latency sound server. JACK allows the connection of multiple applications
>   to an audio device, as well as allowing them to share audio between
>   themselves.

That first phrase in the long description probably ought to be a
full sentence.  The obvious fix, with knock-on effects, is:

    JACK is a low-latency sound server, allowing multiple applications to
    connect to one audio device, and to share audio between themselves.

Something's gone wrong with my control file patch... oh, I see, your
version doesn't have the stanza for a "jackd-firewire" package, new
in the latest unstable version.  I'll just apply the same changes.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru jack-audio-connection-kit-0.116.2+svn3592.pristine/debian/jackd.templates jack-audio-connection-kit-0.116.2+svn3592/debian/jackd.templates
--- jack-audio-connection-kit-0.116.2+svn3592.pristine/debian/jackd.templates	2009-09-21 23:09:17.000000000 +0100
+++ jack-audio-connection-kit-0.116.2+svn3592/debian/jackd.templates	2009-09-21 23:35:57.000000000 +0100
@@ -1,17 +1,13 @@
 Template: jackd/tweak_rt_limits
 Type: boolean
 Default: false
-_Description: Do you want to enable realtime priorities in /etc/security/limits.d?
- If you want to run jackd with realtime priorities, the user starting jackd
- needs realtime permissions. This is usually accomplished by tweaking
- rtprio and memlock in /etc/security/limits.conf, either for a specific
- user or for the audio group in general.
+_Description: Enable realtime process priority?
+ To run jackd with realtime priority, the user starting jackd
+ needs realtime permissions. Accept this option to create the         
+ file /etc/security/limits.d/audio.conf, granting realtime         
+ priority and memlock privileges to the audio group.         
  .
- Raising memlock and rtprio limits may lead to complete system lock-ups due
- to highest scheduler priorities or denial of service attacks by requesting
+ Running jackd with realtime priority minimizes latency, but
+ may lead to complete system lock-ups by requesting
  all the available physical system memory, which is unacceptable in
  multi-user environments.
- .
- The Debian default is to DISABLE realtime priorities, however, if you
- intend to run jackd with very low latencies, enable this option in order to
- place the approriate settings in /etc/security/limits.d/audio.conf.
diff -ru jack-audio-connection-kit-0.116.2+svn3592.pristine/debian/control jack-audio-connection-kit-0.116.2+svn3592/debian/control
--- jack-audio-connection-kit-0.116.2+svn3592.pristine/debian/control	2009-09-21 23:09:17.000000000 +0100
+++ jack-audio-connection-kit-0.116.2+svn3592/debian/control	2009-09-21 23:58:19.000000000 +0100
@@ -43,11 +43,8 @@
 	  meterbridge,
 	  libjackasyn0
 Description: JACK Audio Connection Kit (server and example clients)
- Low-latency sound server. JACK allows the connection of multiple applications
- to an audio device, as well as allowing them to share audio between
- themselves.
- .
- See <http://jackaudio.org/> for more info.
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
  .
  This package contains the daemon jackd as well as some example clients.
 
@@ -60,11 +57,8 @@
 	   jackd (<< ${binary:Version})
 Suggests: jackd (= ${binary:Version})
 Description: JACK Audio Connection Kit (libraries)
- Low-latency sound server. JACK allows the connection of multiple applications
- to an audio device, as well as allowing them to share audio between
- themselves.
- .
- See <http://jackaudio.org/> for more info.
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
  .
  This package contains the shared libraries.
 
@@ -74,11 +68,8 @@
 	 ${misc:Depends},
 	 jackd (= ${binary:Version})
 Description: JACK Audio Connection Kit (FFADO and FreeBoB backends)
- Low-latency sound server. JACK allows the connection of multiple applications
- to an audio device, as well as allowing them to share audio between
- themselves.
- .
- See <http://jackaudio.org/> for more info.
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
  .
  This package contains the IEEE1394 (FireWire) backends FFADO and FreeBoB.
 
@@ -92,11 +83,8 @@
 	 ${shlibs:Depends}
 Provides: libjack0.100.0-dev
 Description: JACK Audio Connection Kit (development files)
- Low-latency sound server. JACK allows the connection of multiple applications
- to an audio device, as well as allowing them to share audio between
- themselves.
- .
- See <http://jackaudio.org/> for more info.
+ JACK is a low-latency sound server, allowing multiple applications to
+ connect to one audio device, and to share audio between themselves.
  .
  This package contains files needed for the development of JACK applications
  and an API reference.
Template: jackd/tweak_rt_limits
Type: boolean
Default: false
_Description: Enable realtime process priority?
 To run jackd with realtime priority, the user starting jackd
 needs realtime permissions. Accept this option to create the         
 file /etc/security/limits.d/audio.conf, granting realtime         
 priority and memlock privileges to the audio group.         
 .
 Running jackd with realtime priority minimizes latency, but
 may lead to complete system lock-ups by requesting
 all the available physical system memory, which is unacceptable in
 multi-user environments.
Source: jack-audio-connection-kit
Section: sound
Priority: optional
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Uploaders: Guenter Geiger (Debian/GNU) <geiger@debian.org>,
	   Junichi Uekawa <dancer@debian.org>,
	   Free Ekanayaka <freee@debian.org>,
	   Reinhard Tartler <siretart@tauware.de>,
	   Adrian Knoth <adi@drcomp.erfurt.thur.de>
Build-Depends: cdbs,
	       type-handling,
	       debhelper (>= 7.0.0),
	       patchutils,
	       dh-buildinfo,
	       libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
	       libsndfile1-dev,
	       doxygen,
	       automake,
	       libtool,
	       libreadline5-dev,
	       libraw1394-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
	       libfreebob0-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
	       libsamplerate-dev,
	       po-debconf,
	       libcelt-dev,
	       libffado-dev [amd64 i386 powerpc]
Standards-Version: 3.8.2
Homepage: http://jackaudio.org/
Vcs-Git: git://git.debian.org/git/pkg-multimedia/jack-audio-connection-kit.git
Vcs-Browser: http://git.debian.org/?p=pkg-multimedia/jack-audio-connection-kit.git;a=summary

Package: jackd
Architecture: any
Depends: ${shlibs:Depends},
	 ${misc:Depends},
	 coreutils (>= 4.0),
	 debconf | debconf-2.0,
	 libjack0 (= ${binary:Version})
Recommends: qjackctl,
	    libpam-modules,
	    jackd-firewire [amd64 i386 powerpc]
Suggests: jack-tools,
	  meterbridge,
	  libjackasyn0
Description: JACK Audio Connection Kit (server and example clients)
 JACK is a low-latency sound server, allowing multiple applications to
 connect to one audio device, and to share audio between themselves.
 .
 This package contains the daemon jackd as well as some example clients.

Package: libjack0
Architecture: any
Section: libs
Depends: ${shlibs:Depends},
	 ${misc:Depends}
Conflicts: jackd (>> ${binary:Version}),
	   jackd (<< ${binary:Version})
Suggests: jackd (= ${binary:Version})
Description: JACK Audio Connection Kit (libraries)
 JACK is a low-latency sound server, allowing multiple applications to
 connect to one audio device, and to share audio between themselves.
 .
 This package contains the shared libraries.

Package: jackd-firewire
Architecture: amd64 i386 powerpc
Depends: ${shlibs:Depends},
	 ${misc:Depends},
	 jackd (= ${binary:Version})
Description: JACK Audio Connection Kit (FFADO and FreeBoB backends)
 JACK is a low-latency sound server, allowing multiple applications to
 connect to one audio device, and to share audio between themselves.
 .
 This package contains the IEEE1394 (FireWire) backends FFADO and FreeBoB.

Package: libjack-dev
Architecture: any
Section: libdevel
Depends: libjack0 (= ${binary:Version}),
	 ${asound:Depends},
	 pkg-config,
	 ${misc:Depends},
	 ${shlibs:Depends}
Provides: libjack0.100.0-dev
Description: JACK Audio Connection Kit (development files)
 JACK is a low-latency sound server, allowing multiple applications to
 connect to one audio device, and to share audio between themselves.
 .
 This package contains files needed for the development of JACK applications
 and an API reference.

Reply to: