Re: [RFR] templates://glide/{libglide2.templates,libglide3.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
As usual I've spotted something that belongs as a bugreport
(assuming I haven't misunderstood). There are references throughout
the debian/ directory to a package "glide3-bin", but I can find no
evidence it has ever been built. Simply adding a glide3-bin stanza
to the control file and rebuilding isn't enough to give an extra
output .deb...
Is this intentional? Or if it isn't but nobody has noticed in all
the years since 3dfx Interactive existed, is there any point fixing
it now?
> Template: libglide2/no_card
[...]
> + If the graphical card in this computer does not use one of these
> + chipsets, and you are not compiling programs against glide,
> + this package will be useless.
> + .
> + If the graphical card is based on one of these chipsets, you
> + should report a bug against this package, including the output from the
> + "lspci -vm" command.
"Graphics card", or "video card", or "graphics accelerator card", or
"display adapter", but never "graphical card". Oddly, while
"graphic" as an adjective can mean "intensely pictorial", the word
"graphical" tends to mean "of or pertaining to writing", which in
user interface terms is almost the opposite!
> Template: libglide2/card
> Type: select
> Choices: ${choices}
> +_Description: Card to use for 3D acceleration:
> + More than one 3Dfx-based cards were detected that use one of the
> + following 3Dfx chipsets: Voodoo 2, Voodoo Banshee, and Voodoo 3.
It's "than one card", singular; but then although the phrase "more
than one" is obviously plural in meaning, I'd expect it to take
singular agreement - "was detected"! Maybe I can spare non-native
speakers the pain of reading something this illogical by rephrasing:
Multiple 3Dfx-based cards were detected based on one of the
> Template: libglide3/card
I notice this one checks for "the following 3Dfx chipsets: Voodoo 2,
Voodoo Banshee, Voodoo 3, Voodoo 4, and Voodoo 5". Should the first
three be on that list?
> Package: libglide2
[...]
> + Additionnally, the original Voodoo Graphics chipset
> is no longer supported.
AdditioNally. But this whole paragraph might as well be tacked onto
the previous sentence on the same topic:
This package is not useful with Voodoo Banshee, Voodoo 3,
Voodoo 4, or Voodoo 5 cards, and the original Voodoo Graphics chipset
is no longer supported.
> + You'll need the /dev/3dfx kernel driver to use this library.
/dev/3dfx is a device; the driver is 3dfx(.ko)
> Package: libglide3
[...]
> This package allows you to use the 3D functions of cards based on
> 3dfx Interactive, Inc's Voodoo Banshee, Voodoo 3, Voodoo 4, and
> Voodoo 5, chipsets.
^
Excess comma. There should a word for that.
> - NB: This package does NOT need device3dfx, as it is using DRI instead.
> + This package does not need device3dfx, as it is using DRI instead.
This looks like some sort of search-and-replace error for /dev/3dfx;
fix as above. Also, "s/is using/uses/".
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../glide-2002.04.10ds1.pristine/debian/libglide2.templates 2009-03-24 10:05:02.000000000 +0000
+++ debian/libglide2.templates 2009-03-30 18:32:52.000000000 +0100
@@ -1,43 +1,40 @@
Template: libglide2/no_card
Type: boolean
Default: false
-_Description: No 3Dfx card supported by glide2 found! Manually select driver?
- ERROR: No 3Dfx card supported by glide2 found!
- .
- This package is for cards based on the following 3Dfx chipsets: Voodoo 2,
+_Description: Manually select driver for 3Dfx card?
+ No 3Dfx card that is supported by glide2 was found. This package
+ supports cards based on the following 3Dfx chipsets: Voodoo 2,
Voodoo Banshee, and Voodoo 3.
.
- If you do not have a card based on one of the listed chipsets, and you are
- not compiling programs against glide, you should not have this package
- installed.
- .
- If you do have a card based on one of the listed chipsets please file a
- bug on this package, including the output from the command 'lspci -vm' in
- the bug report.
+ If the graphics card in this computer does not use one of these
+ chipsets, and you are not compiling programs against glide,
+ this package will be useless.
+ .
+ If the graphics card is based on one of these chipsets, you
+ should report a bug against this package, including the output from the
+ "lspci -vm" command.
.
- Would you like to manually select the driver to use for now? (If not, a
- default sane value for compiling against will be selected.)
+ Please choose whether you want to manually select the driver to use for now.
Template: libglide2/driver
Type: select
Choices: cvg, h3
Default: ${default}
-_Description: Please select a driver.
- Please select the driver you would like to use.
- .
- cvg - Voodoo 2.
- h3 - Voodoo Banshee and Voodoo 3.
+_Description: Driver for 3D acceleration:
+ Please select the driver you would like to use for 3D acceleration:
+ - cvg: Voodoo 2;
+ - h3 : Voodoo Banshee and Voodoo 3.
Template: libglide2/card
Type: select
Choices: ${choices}
-_Description: Please select a card.
- We have detected more then one video card based on the following 3Dfx
- chipsets: Voodoo 2, Voodoo Banshee, and Voodoo 3.
+_Description: Card to use for 3D acceleration:
+ Multiple 3Dfx-based cards were detected based on one of the
+ following 3Dfx chipsets: Voodoo 2, Voodoo Banshee, and Voodoo 3.
.
Please select the card you would like to use for 3D acceleration.
Template: libglide2/error
Type: note
-_Description: ${e1}
+Description: ${e1}
${e2}
--- ../glide-2002.04.10ds1.pristine/debian/libglide3.templates 2009-03-24 10:05:02.000000000 +0000
+++ debian/libglide3.templates 2009-03-30 18:35:51.000000000 +0100
@@ -1,43 +1,40 @@
Template: libglide3/no_card
Type: boolean
Default: false
-_Description: No 3Dfx card supported by glide3 found! Manually select driver?
- ERROR: No 3Dfx card supported by glide3 found!
- .
- This package is for cards based on the following 3Dfx chipsets: Voodoo
+_Description: Manually select driver for 3Dfx card?
+ No 3Dfx card that is supported by glide3 was found. This package
+ supports cards based on the following 3Dfx chipsets: Voodoo
Banshee, Voodoo 3, Voodoo 4, and Voodoo 5.
.
- If you do not have a card based on one of the listed chipsets, and you are
- not compiling programs against glide, you should not have this package
- installed.
- .
- If you do have a card based on one of the listed chipsets please file a
- bug on this package, including the output from the command 'lspci -vm' in
- the bug report.
+ If the graphics card in this computer does not use one of these
+ chipsets, and you are not compiling programs against glide,
+ this package will be useless.
+ .
+ If the graphics card is based on one of these chipsets, you
+ should report a bug against this package, including the output from the
+ "lspci -vm" command.
.
- Would you like to manually select the driver to use for now? (If not, a
- default sane value for compiling against will be selected.)
+ Please choose whether you want to manually select the driver to use for now.
Template: libglide3/driver
Type: select
Choices: h3, h5
Default: ${default}
-_Description: Please select a driver.
- Please select the driver you would like to use.
- .
- h3 - Voodoo Banshee and Voodoo 3.
- h5 - Voodoo 4 and Voodoo 5.
+_Description: Driver for 3D acceleration:
+ Please select the driver you would like to use for 3D acceleration:
+ - h3: Voodoo Banshee and Voodoo 3;
+ - h5: Voodoo 4 and Voodoo 5.
Template: libglide3/card
Type: select
Choices: ${choices}
-_Description: Please select a card.
- We have detected more then one video card based on the following 3Dfx
- chipsets: Voodoo 2, Voodoo Banshee, Voodoo 3, Voodoo 4, and Voodoo 5.
+_Description: Card to use for 3D acceleration:
+ Multiple 3Dfx-based cards were detected based on one of the
+ following 3Dfx chipsets: Voodoo 2, Voodoo Banshee, Voodoo 3, Voodoo 4, and Voodoo 5.
.
Please select the card you would like to use for 3D acceleration.
Template: libglide3/error
Type: note
-_Description: ${e1}
+Description: ${e1}
${e2}
--- ../glide-2002.04.10ds1.pristine/debian/control 2009-03-24 10:05:02.000000000 +0000
+++ debian/control 2009-03-30 18:38:47.000000000 +0100
@@ -1,46 +1,48 @@
Source: glide
Section: libs
Priority: optional
-Build-Depends: debhelper (>= 7), quilt (>= 0.40), autoconf, automake,
+Build-Depends: dbs (>= 0.25), debhelper (>= 5), autoconf, automake,
libtool (>= 1.5), libx11-dev, libxext-dev, libxxf86dga-dev, libxxf86vm-dev
Build-Conflicts: automake1.4
Maintainer: Guillem Jover <guillem@debian.org>
Homepage: http://glide.sf.net/
Vcs-Browser: http://git.hadrons.org/?p=debian/pkgs/glide.git
Vcs-Git: git://git.hadrons.org/git/debian/pkgs/glide.git
-Standards-Version: 3.8.0
+Standards-Version: 3.7.3
Package: glide2-bin
Section: graphics
Architecture: i386
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${shlibs:Depends}
Suggests: device3dfx-module, device3dfx-source
Description: graphics library for 3Dfx Voodoo based cards - support programs
- This is a support package which should be installed if you have a
+ This is a support package which should be installed if you use a
card based on 3dfx Interactive, Inc's Voodoo chipsets.
Package: libglide2
Section: libs
Architecture: i386
Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
-Suggests: glide2-bin, device3dfx-module, device3dfx-source
+Recommends: glide2-bin
+Suggests: device3dfx-module, device3dfx-source
+Conflicts: libglide2
Description: graphics library for 3Dfx Voodoo based cards - shared libraries
This package allows you to use the 3D functions of cards based on
3dfx Interactive, Inc's Voodoo 2 chipsets. You should install it if
- you have such a card.
- .
- Note, this is NOT the package you want for Voodoo Banshee, Voodoo 3,
- Voodoo 4, or Voodoo 5.
+ you use such a card.
.
- Also note that for the moment the original Voodoo Graphics chipset
+ This package is not useful with Voodoo Banshee, Voodoo 3,
+ Voodoo 4, or Voodoo 5 cards, and the original Voodoo Graphics chipset
is no longer supported.
.
- NOTE: You'll need the /dev/3dfx kernel driver to use this library.
+ You'll need the 3dfx kernel driver to use this library.
Package: libglide2-dev
Section: libdevel
Architecture: i386
-Depends: libglide2, ${misc:Depends}
+Depends: libglide2
+Provides: libglide-dev
+Conflicts: llibglide-dev
Description: graphics library for 3Dfx Voodoo based cards - development files
This package contains the necessary header files, example programs,
and documentation necessary to develop software for cards based on
@@ -50,18 +52,24 @@
Section: libs
Architecture: i386 alpha ia64 amd64
Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
+Provides: libglide3-alpha
+Replaces: libglide3-alpha, libglide3-dev
+Conflicts: libglide3, libglide3-alpha
Description: graphics library for 3Dfx Voodoo based cards - shared libraries
This package allows you to use the 3D functions of cards based on
3dfx Interactive, Inc's Voodoo Banshee, Voodoo 3, Voodoo 4, and
- Voodoo 5, chipsets.
- You should install it if you have such a card.
+ Voodoo 5 chipsets.
+ You should install it if you use such a card.
.
- NB: This package does NOT need device3dfx, as it is using DRI instead.
+ This package does not need 3dfx, as it uses DRI instead.
Package: libglide3-dev
Section: libdevel
Architecture: i386 alpha ia64 amd64
-Depends: libglide3, ${misc:Depends}
+Depends: libglide3
+Provides: libglide-dev, libglide3-alpha-dev
+Replaces: libglide2-dev, libglide3-alpha-dev
+Conflicts: libglide3-alpha-dev
Description: graphics library for 3Dfx Voodoo based cards - development files
This package contains the necessary header files, example programs,
and documentation necessary to develop software for cards based on
Template: libglide2/no_card
Type: boolean
Default: false
_Description: Manually select driver for 3Dfx card?
No 3Dfx card that is supported by glide2 was found. This package
supports cards based on the following 3Dfx chipsets: Voodoo 2,
Voodoo Banshee, and Voodoo 3.
.
If the graphics card in this computer does not use one of these
chipsets, and you are not compiling programs against glide,
this package will be useless.
.
If the graphics card is based on one of these chipsets, you
should report a bug against this package, including the output from the
"lspci -vm" command.
.
Please choose whether you want to manually select the driver to use for now.
Template: libglide2/driver
Type: select
Choices: cvg, h3
Default: ${default}
_Description: Driver for 3D acceleration:
Please select the driver you would like to use for 3D acceleration:
- cvg: Voodoo 2;
- h3 : Voodoo Banshee and Voodoo 3.
Template: libglide2/card
Type: select
Choices: ${choices}
_Description: Card to use for 3D acceleration:
Multiple 3Dfx-based cards were detected based on one of the
following 3Dfx chipsets: Voodoo 2, Voodoo Banshee, and Voodoo 3.
.
Please select the card you would like to use for 3D acceleration.
Template: libglide2/error
Type: note
Description: ${e1}
${e2}
Template: libglide3/no_card
Type: boolean
Default: false
_Description: Manually select driver for 3Dfx card?
No 3Dfx card that is supported by glide3 was found. This package
supports cards based on the following 3Dfx chipsets: Voodoo
Banshee, Voodoo 3, Voodoo 4, and Voodoo 5.
.
If the graphics card in this computer does not use one of these
chipsets, and you are not compiling programs against glide,
this package will be useless.
.
If the graphics card is based on one of these chipsets, you
should report a bug against this package, including the output from the
"lspci -vm" command.
.
Please choose whether you want to manually select the driver to use for now.
Template: libglide3/driver
Type: select
Choices: h3, h5
Default: ${default}
_Description: Driver for 3D acceleration:
Please select the driver you would like to use for 3D acceleration:
- h3: Voodoo Banshee and Voodoo 3;
- h5: Voodoo 4 and Voodoo 5.
Template: libglide3/card
Type: select
Choices: ${choices}
_Description: Card to use for 3D acceleration:
Multiple 3Dfx-based cards were detected based on one of the
following 3Dfx chipsets: Voodoo 2, Voodoo Banshee, Voodoo 3, Voodoo 4, and Voodoo 5.
.
Please select the card you would like to use for 3D acceleration.
Template: libglide3/error
Type: note
Description: ${e1}
${e2}
Source: glide
Section: libs
Priority: optional
Build-Depends: dbs (>= 0.25), debhelper (>= 5), autoconf, automake,
libtool (>= 1.5), libx11-dev, libxext-dev, libxxf86dga-dev, libxxf86vm-dev
Build-Conflicts: automake1.4
Maintainer: Guillem Jover <guillem@debian.org>
Homepage: http://glide.sf.net/
Vcs-Browser: http://git.hadrons.org/?p=debian/pkgs/glide.git
Vcs-Git: git://git.hadrons.org/git/debian/pkgs/glide.git
Standards-Version: 3.7.3
Package: glide2-bin
Section: graphics
Architecture: i386
Depends: ${shlibs:Depends}
Suggests: device3dfx-module, device3dfx-source
Description: graphics library for 3Dfx Voodoo based cards - support programs
This is a support package which should be installed if you use a
card based on 3dfx Interactive, Inc's Voodoo chipsets.
Package: libglide2
Section: libs
Architecture: i386
Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
Recommends: glide2-bin
Suggests: device3dfx-module, device3dfx-source
Conflicts: libglide2
Description: graphics library for 3Dfx Voodoo based cards - shared libraries
This package allows you to use the 3D functions of cards based on
3dfx Interactive, Inc's Voodoo 2 chipsets. You should install it if
you use such a card.
.
This package is not useful with Voodoo Banshee, Voodoo 3,
Voodoo 4, or Voodoo 5 cards, and the original Voodoo Graphics chipset
is no longer supported.
.
You'll need the 3dfx kernel driver to use this library.
Package: libglide2-dev
Section: libdevel
Architecture: i386
Depends: libglide2
Provides: libglide-dev
Conflicts: llibglide-dev
Description: graphics library for 3Dfx Voodoo based cards - development files
This package contains the necessary header files, example programs,
and documentation necessary to develop software for cards based on
3dfx Interactive, Inc's Voodoo chipsets.
Package: libglide3
Section: libs
Architecture: i386 alpha ia64 amd64
Depends: ${shlibs:Depends}, ${misc:Depends}, pciutils
Provides: libglide3-alpha
Replaces: libglide3-alpha, libglide3-dev
Conflicts: libglide3, libglide3-alpha
Description: graphics library for 3Dfx Voodoo based cards - shared libraries
This package allows you to use the 3D functions of cards based on
3dfx Interactive, Inc's Voodoo Banshee, Voodoo 3, Voodoo 4, and
Voodoo 5 chipsets.
You should install it if you use such a card.
.
This package does not need 3dfx, as it uses DRI instead.
Package: libglide3-dev
Section: libdevel
Architecture: i386 alpha ia64 amd64
Depends: libglide3
Provides: libglide-dev, libglide3-alpha-dev
Replaces: libglide2-dev, libglide3-alpha-dev
Conflicts: libglide3-alpha-dev
Description: graphics library for 3Dfx Voodoo based cards - development files
This package contains the necessary header files, example programs,
and documentation necessary to develop software for cards based on
3dfx Interactive, Inc's Voodoo chipsets.
Reply to: