Please find, for review, the debconf templates and packages descriptions for the netselect source package.
This review will last from Thursday, February 05, 2009 to Sunday, February 15, 2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- netselect.old/debian/templates 2009-02-01 13:57:54.291175247 +0100
+++ netselect/debian/templates 2009-02-05 18:36:28.997288701 +0100
@@ -1,11 +1,11 @@
Template: netselect/install-setuid
Type: boolean
Default: false
-_Description: Do you want netselect to be installed setuid root?
+_Description: Should netselect be installed setuid root?
This wording is more often used and slightly more neutral...
Netselect can be installed with the set-user-id bit set, so that it will
- run with the permissions of the 'root' user. Since netselect needs these
- permissions to work properly, ordinary users cannot run it unless it is
+ run with the permissions of the "root" user. Since netselect needs these
+ permissions to work properly, unprivileged users cannot run it unless it is
installed this way.
.
- Enabling this feature may be a security risk, so it is disabled by
- default. If in doubt, it is suggested to leave it disabled.
+ Enabling this feature may be a security risk. If in doubt, it is
+ suggested to leave it disabled.
Use double quotes (the new standard of dle...:-))
s/ordinary/unprivileged users --> Debian users are not ordinary
people..:-)).... More seriously, "unprivileged" is more politically correct.
--- netselect.old/debian/control 2009-02-01 13:57:54.291175247 +0100
+++ netselect/debian/control 2009-02-05 18:45:15.762081179 +0100
@@ -12,18 +12,20 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Suggests: netselect-apt
-Description: Choose the fastest server automatically
- This is netselect, an ultrafast intelligent parallelizing binary-search
- implementation of "ping." You give it a (possibly very long) list of
- servers, and it chooses the fastest/closest one automatically. It's good
- for finding the fastest ftp.debian.org mirror, the least laggy IRC server,
- or the best Squid neighbour.
+Description: network servers speed probing utility
I'm not entirely happy with that pile of words but the original
synopsis is definitely going against all recommendantions (full verb
sentence mostly)
+ This package provides a utility allowing to perform
+ parallelized "ping" tests to distant servers.
+ .
+ It can process a (possibly very long) list of
+ servers, and choose the fastest/closest one automatically.
"This is <foo>" is discouraged as you're basically saying that
"netselect if netselect"....
Drop the buzz advertisments..:-)...just give facts: the utility
performs parallel pings to probe distant servers.... Whether it is
intelligent is an exercise left to the user...
Package: netselect-apt
Architecture: all
Depends: wget, netselect (>= 0.3.ds1-1)
Enhances: apt
-Description: Choose the fastest Debian mirror with netselect
- netselect-apt will choose the fastest Debian mirror by downloading the full
- mirror list and uses netselect to find the best one. netselect-apt writes a
+Description: Debian mirror speed testing utility
I'm not entirely happy here too. Beginning with "Debian" enforces the
use of a capital, which is discouraged. Maybe Justin will find
something better.
+ This package provides a utility allowing to choose the fastest Debian mirror by downloading the full
+ mirror list and using netselect to find the fastest one.
+ .
+ It can output a
sources.list(5) file that can be used with apt(8).
Rewording to avoid startig with a lowercase letter.
"a utility allowing to choose": we probably can do better...:)
--
Template: netselect/install-setuid Type: boolean Default: false _Description: Should netselect be installed setuid root? Netselect can be installed with the set-user-id bit set, so that it will run with the permissions of the "root" user. Since netselect needs these permissions to work properly, unprivileged users cannot run it unless it is installed this way. . Enabling this feature may be a security risk. If in doubt, it is suggested to leave it disabled.
--- netselect.old/debian/templates 2009-02-01 13:57:54.291175247 +0100
+++ netselect/debian/templates 2009-02-05 18:36:28.997288701 +0100
@@ -1,11 +1,11 @@
Template: netselect/install-setuid
Type: boolean
Default: false
-_Description: Do you want netselect to be installed setuid root?
+_Description: Should netselect be installed setuid root?
Netselect can be installed with the set-user-id bit set, so that it will
- run with the permissions of the 'root' user. Since netselect needs these
- permissions to work properly, ordinary users cannot run it unless it is
+ run with the permissions of the "root" user. Since netselect needs these
+ permissions to work properly, unprivileged users cannot run it unless it is
installed this way.
.
- Enabling this feature may be a security risk, so it is disabled by
- default. If in doubt, it is suggested to leave it disabled.
+ Enabling this feature may be a security risk. If in doubt, it is
+ suggested to leave it disabled.
--- netselect.old/debian/control 2009-02-01 13:57:54.291175247 +0100
+++ netselect/debian/control 2009-02-05 18:50:12.050081440 +0100
@@ -12,18 +12,20 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Suggests: netselect-apt
-Description: Choose the fastest server automatically
- This is netselect, an ultrafast intelligent parallelizing binary-search
- implementation of "ping." You give it a (possibly very long) list of
- servers, and it chooses the fastest/closest one automatically. It's good
- for finding the fastest ftp.debian.org mirror, the least laggy IRC server,
- or the best Squid neighbour.
+Description: network servers speed probing utility
+ This package provides a utility allowing to perform
+ parallelized "ping" tests to distant servers.
+ .
+ It can process a (possibly very long) list of
+ servers, and choose the fastest/closest one automatically.
Package: netselect-apt
Architecture: all
Depends: wget, netselect (>= 0.3.ds1-1)
Enhances: apt
-Description: Choose the fastest Debian mirror with netselect
- netselect-apt will choose the fastest Debian mirror by downloading the full
- mirror list and uses netselect to find the best one. netselect-apt writes a
+Description: Debian mirror speed testing utility
+ This package provides a utility allowing to choose the fastest Debian mirror by downloading the full
+ mirror list and using netselect to find the fastest one.
+ .
+ It can output a
sources.list(5) file that can be used with apt(8).
Source: netselect
Section: net
Priority: optional
Maintainer: Filippo Giunchedi <filippo@debian.org>
Standards-Version: 3.7.3
Build-Depends: debhelper (>= 5), po-debconf
VCS-Svn: svn://svn.debian.org/svn/collab-maint/deb-maint/netselect/trunk
VCS-Browser: http://svn.debian.org/wsvn/collab-maint/deb-maint/netselect/trunk
Homepage: http://alumnit.ca/~apenwarr/netselect/
Package: netselect
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Suggests: netselect-apt
Description: network servers speed probing utility
This package provides a utility allowing to perform
parallelized "ping" tests to distant servers.
.
It can process a (possibly very long) list of
servers, and choose the fastest/closest one automatically.
Package: netselect-apt
Architecture: all
Depends: wget, netselect (>= 0.3.ds1-1)
Enhances: apt
Description: Debian mirror speed testing utility
This package provides a utility allowing to choose the fastest Debian mirror by downloading the full
mirror list and using netselect to find the fastest one.
.
It can output a
sources.list(5) file that can be used with apt(8).
Attachment:
signature.asc
Description: Digital signature