[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://sysstat/{sysstat.templates}



Justin B Rye wrote:
> Christian Perrier wrote:
>> Your review should be sent as an answer to this mail.

You may have noticed my final sentence trailed off:

> Oh, and s/concern/deal with/ in 
                                  ...the final paragraph.

But more importantly I didn't look at the long description of isag:
 
> Package: isag
> Architecture: all
> Depends: sysstat (>= ${source:Version}), tk8.5|wish, gnuplot-x11, ${misc:Depends}
> Suggests: rcs
> Description: Interactive System Activity Grapher for sysstat
>  This package includes the isag command, which graphically displays the 
>  system activity data stored in a binary data produced by a sar command
>  from a sysstat package.

None of those indefinite articles should be there.

   This package provides the command isag, which graphically displays the
   system activity data stored in the binary logs produced by sar (in the
   package sysstat).

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../sysstat.old/debian/sysstat.templates	2009-01-15 19:37:01.000000000 +0000
+++ debian/sysstat.templates	2009-01-17 21:53:32.000000000 +0000
@@ -1,26 +1,25 @@
 Template: sysstat/remove_files
 Type: boolean
 Default: true
-_Description: Do you want post-installation script to remove these data files?
- Format of daily data statistics files has changed in version ${s_version}
- of sysstat and is *not* compatible with the previous one!
+_Description: Remove old format statistics data files?
+ The format of daily data statistics files has changed in version ${s_version}
+ of sysstat and is not compatible with the previous one.
  .
- If you activate this option, any existing data files in /var/log/sysstat/
+ If you choose this option, all existing data files in the /var/log/sysstat/
  directory will be deleted.
  .
- If you don't want to remove them automatically, please remove them by hand later,
- in order for the sar command to work properly.
+ If you don't choose this option, the sar(1) command will not work properly
+ until you remove the files manually.
 
 Template: sysstat/enable
 Type: boolean
 Default: false
-_Description: Do you want to activate sysstat's cron job?
- If this option is enabled the sysstat package will collect (using the cron
- daemon and init.d script) binary data concerning system activities and store
- them in log files within /var/log/sysstat/ directory.
+_Description: Activate sysstat's cron job?
+ If this option is enabled the sysstat package will monitor system
+ activities and store the data in log files within /var/log/sysstat/.
  .
- With this data the sar(1) command will be able to display day-long system
- statistics.
+ This data allows the sar(1) command to display system statistics for the
+ whole day.
  .
- If you don't enable this option, the sar(1) command will show only the
+ If you don't enable this option, the sar(1) command will only show the
  current statistics.
--- ../sysstat.old/debian/control	2009-01-15 19:37:01.000000000 +0000
+++ debian/control	2009-01-18 23:58:13.000000000 +0000
@@ -11,15 +11,15 @@
 Recommends: cron
 Suggests: isag
 Conflicts: atsar (<< 1.5-3)
-Description: sar, iostat and mpstat - system performance tools for Linux
+Description: system performance tools for Linux
  The sysstat package contains the following system performance tools:
-  * sar - collects and reports system activity information;
-  * iostat - reports CPU utilization and I/O statistics for disks;
-  * mpstat - reports global and per-processor statistics;
-  * pidstat - reports statistics for Linux tasks (processes);
-  * sadf - displays data collected by sar in various formats.
+  - sar: collects and reports system activity information;
+  - iostat: reports CPU utilization and disk I/O statistics;
+  - mpstat: reports global and per-processor statistics;
+  - pidstat: reports statistics for Linux tasks (processes);
+  - sadf: displays data collected by sar in various formats.
  .
- The statistics reported by sar concern I/O transfer rates,
+ The statistics reported by sar deal with I/O transfer rates,
  paging activity, process-related activities, interrupts,
  network activity, memory and swap space utilization, CPU
  utilization, kernel activities and TTY statistics, among
@@ -31,7 +31,7 @@
 Depends: sysstat (>= ${source:Version}), tk8.5|wish, gnuplot-x11, ${misc:Depends}
 Suggests: rcs
 Description: Interactive System Activity Grapher for sysstat
- This package includes the isag command, which graphically displays the 
- system activity data stored in a binary data produced by a sar command
- from a sysstat package.
+ This package provides the command isag, which graphically displays the
+ system activity data stored in the binary logs produced by sar (in the
+ package sysstat).
 Homepage: http://pagesperso-orange.fr/sebastien.godard/
Template: sysstat/remove_files
Type: boolean
Default: true
_Description: Remove old format statistics data files?
 The format of daily data statistics files has changed in version ${s_version}
 of sysstat and is not compatible with the previous one.
 .
 If you choose this option, all existing data files in the /var/log/sysstat/
 directory will be deleted.
 .
 If you don't choose this option, the sar(1) command will not work properly
 until you remove the files manually.

Template: sysstat/enable
Type: boolean
Default: false
_Description: Activate sysstat's cron job?
 If this option is enabled the sysstat package will monitor system
 activities and store the data in log files within /var/log/sysstat/.
 .
 This data allows the sar(1) command to display system statistics for the
 whole day.
 .
 If you don't enable this option, the sar(1) command will only show the
 current statistics.
Source: sysstat
Section: admin
Priority: optional
Maintainer: Robert Luberda <robert@debian.org>
Build-Depends: debhelper (>= 6), gettext
Standards-Version: 3.8.0

Package: sysstat
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, ucf (>= 2.003), lsb-base (>= 3.0-6), bzip2
Recommends: cron
Suggests: isag
Conflicts: atsar (<< 1.5-3)
Description: system performance tools for Linux
 The sysstat package contains the following system performance tools:
  - sar: collects and reports system activity information;
  - iostat: reports CPU utilization and disk I/O statistics;
  - mpstat: reports global and per-processor statistics;
  - pidstat: reports statistics for Linux tasks (processes);
  - sadf: displays data collected by sar in various formats.
 .
 The statistics reported by sar deal with I/O transfer rates,
 paging activity, process-related activities, interrupts,
 network activity, memory and swap space utilization, CPU
 utilization, kernel activities and TTY statistics, among
 others. Both UP and SMP machines are fully supported.
Homepage: http://pagesperso-orange.fr/sebastien.godard/

Package: isag
Architecture: all
Depends: sysstat (>= ${source:Version}), tk8.5|wish, gnuplot-x11, ${misc:Depends}
Suggests: rcs
Description: Interactive System Activity Grapher for sysstat
 This package provides the command isag, which graphically displays the
 system activity data stored in the binary logs produced by sar (in the
 package sysstat).
Homepage: http://pagesperso-orange.fr/sebastien.godard/

Reply to: