[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://sysstat/{sysstat.templates}



Please find, for review, the debconf templates and packages descriptions for the sysstat source package.

This review will last from Saturday, January 17, 2009 to Tuesday, January 27, 2009.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- sysstat-8.1.7.old/debian/sysstat.templates	2009-01-14 06:14:29.597809668 +0100
+++ sysstat-8.1.7/debian/sysstat.templates	2009-01-16 08:18:35.677977043 +0100
@@ -1,26 +1,25 @@
 Template: sysstat/remove_files
 Type: boolean
 Default: true
-_Description: Do you want post-installation script to remove these data files?
- Format of daily data statistics files has changed in version ${s_version}
- of sysstat and is *not* compatible with the previous one!
+_Description: Remove old format statistics data files?
+ The format of daily data statistics files has changed in version ${s_version}
+ of sysstat and is not compatible with the previous one.

One cannot use "these" which might look weird when the long
description comes *after* the short one (which may happen in some
interfaces).

Therefore, I suggest simplificating things alightly.

"Format" --> "The format", in the hope this is not too French

Drop the exclamation mark and just remain factual.

  .
- If you activate this option, any existing data files in /var/log/sysstat/
+ If you choose this option, all existing data files in /var/log/sysstat/
  directory will be deleted.

I think the option is not "activated" here but rather chosen (this is a
one-shot question).

any->all (personal taste...still undure, though).

  .
- If you don't want to remove them automatically, please remove them by hand later,
- in order for the sar command to work properly.
+ If you don't choose this option, the sar(1) command will not work properly
+ until you remove the files manually.
 
Again use "choose this option".

 Template: sysstat/enable
 Type: boolean
 Default: false
 _Description: Do you want to activate sysstat's cron job?
- If this option is enabled the sysstat package will collect (using the cron
- daemon and init.d script) binary data concerning system activities and store
- them in log files within /var/log/sysstat/ directory.
+ The sysstat package can collect, through a cron
+ job and a daemon launched during system's initialization, binary data concerning system activities. This data is then stored
+ in log files located in the /var/log/sysstat/ directory.
  .
- With this data the sar(1) command will be able to display day-long system
- statistics.
+ This data allows displaying long term system statistics with the sar(1) command.

Rewrite, mostly for personal taste.



  .
- If you don't enable this option, the sar(1) command will show only the
+ If you don't enable this option, the sar(1) command will only show the
  current statistics.
--- sysstat-8.1.7.old/debian/control	2009-01-14 06:14:29.597809668 +0100
+++ sysstat-8.1.7/debian/control	2009-01-17 19:11:52.013147129 +0100
@@ -11,13 +11,13 @@
 Recommends: cron
 Suggests: isag
 Conflicts: atsar (<< 1.5-3)
-Description: sar, iostat and mpstat - system performance tools for Linux
+Description: system performance tools for Linux

Enumerating the provided commands needs doing a choice of which to
mention. Better stay description, imho.

  The sysstat package contains the following system performance tools:
-  * sar - collects and reports system activity information;
-  * iostat - reports CPU utilization and I/O statistics for disks;
-  * mpstat - reports global and per-processor statistics;
-  * pidstat - reports statistics for Linux tasks (processes);
-  * sadf - displays data collected by sar in various formats.
+  - sar: collects and reports system activity information;
+  - iostat: reports CPU utilization and I/O statistics for disks;
+  - mpstat: reports global and per-processor statistics;
+  - pidstat: reports statistics for Linux tasks (processes);
+  - sadf: displays data collected by sar in various formats.

Standard enumeration method.

  .
  The statistics reported by sar concern I/O transfer rates,
  paging activity, process-related activities, interrupts,

-- 


Template: sysstat/remove_files
Type: boolean
Default: true
_Description: Remove old format statistics data files?
 The format of daily data statistics files has changed in version ${s_version}
 of sysstat and is not compatible with the previous one.
 .
 If you choose this option, all existing data files in /var/log/sysstat/
 directory will be deleted.
 .
 If you don't choose this option, the sar(1) command will not work properly
 until you remove the files manually.

Template: sysstat/enable
Type: boolean
Default: false
_Description: Do you want to activate sysstat's cron job?
 The sysstat package can collect, through a cron
 job and a daemon launched during system's initialization, binary data concerning system activities. This data is then stored
 in log files located in the /var/log/sysstat/ directory.
 .
 This data allows displaying long term system statistics with the sar(1) command.
 .
 If you don't enable this option, the sar(1) command will only show the
 current statistics.
Source: sysstat
Section: admin
Priority: optional
Maintainer: Robert Luberda <robert@debian.org>
Build-Depends: debhelper (>= 6), gettext
Standards-Version: 3.8.0

Package: sysstat
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, ucf (>= 2.003), lsb-base (>= 3.0-6), bzip2
Recommends: cron
Suggests: isag
Conflicts: atsar (<< 1.5-3)
Description: system performance tools for Linux
 The sysstat package contains the following system performance tools:
  - sar: collects and reports system activity information;
  - iostat: reports CPU utilization and I/O statistics for disks;
  - mpstat: reports global and per-processor statistics;
  - pidstat: reports statistics for Linux tasks (processes);
  - sadf: displays data collected by sar in various formats.
 .
 The statistics reported by sar concern I/O transfer rates,
 paging activity, process-related activities, interrupts,
 network activity, memory and swap space utilization, CPU
 utilization, kernel activities and TTY statistics, among
 others. Both UP and SMP machines are fully supported.
Homepage: http://pagesperso-orange.fr/sebastien.godard/

Package: isag
Architecture: all
Depends: sysstat (>= ${source:Version}), tk8.5|wish, gnuplot-x11, ${misc:Depends}
Suggests: rcs
Description: Interactive System Activity Grapher for sysstat
 This package includes the isag command, which graphically displays the 
 system activity data stored in a binary data produced by a sar command
 from a sysstat package.
Homepage: http://pagesperso-orange.fr/sebastien.godard/

Attachment: signature.asc
Description: Digital signature


Reply to: