[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://unattended-upgrades/{templates}



Christian Perrier wrote:
> -Description: Install security upgrades automatically 
> - This package will download and install security upgrades automatically
> - and unattended. It will take care to only install packages from the 
> +Description: automatic installation of security upgrades
> + This package will optionnally download and install security upgrades automatically
> + and unattended. It can take care to only install packages from the 
>   configured origin and will check for conffile prompts.
>   . 
>   This script is the backend for the APT::Periodic::Unattended-Upgrade 
> 
> I tried to address the concern in #473082....

I don't see which concern you're talking about.  If the version in
Etch didn't have a cronscript(!?), it clearly didn't deserve this
description, but newer versions do, so the only change this implies
to me is that maybe it should suggest anacron.

However, given that it has a debconf "off switch" (which seems
strange until I realise the package can be pulled in accidentally by
a dependency chain), it does make sense to modify the "will".

Also, "from the configured origin" sounds as if you might be pulling
security upgrades from a nonstandard host.  If it's talking about
the difference between
 deb http://security.debian.org/ lenny/updates main
and
 deb http://security.debian.org stable/updates main contrib
then, well, is "from the configured APT source" better?

> Add "optionnally" and replace "will" by "can".

s/optionnally/optionally/, but I'd say it as:

  This package can download and install security upgrades automatically
  and unattended, taking care to only install packages from the configured
  APT source, and checking for conffile prompts.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -u ../unattended-upgrades.old/debian/control debian/control
--- ../unattended-upgrades.old/debian/control	2008-11-27 14:03:46.000000000 +0000
+++ debian/control	2008-11-27 14:07:18.000000000 +0000
@@ -10,10 +10,10 @@
 Architecture: all
 Depends: python, ${shlibs:Depends}, python-apt (>= 0.7), apt-utils (>= 0.7), apt (>= 0.7), ucf
 Suggests: mailx
-Description: Install security upgrades automatically 
- This package will download and install security upgrades automatically
- and unattended. It will take care to only install packages from the 
- configured origin and will check for conffile prompts.
- . 
+Description: automatic installation of security upgrades
+ This package can download and install security upgrades automatically
+ and unattended, taking care to only install packages from the configured
+ APT source, and checking for conffile prompts.
+ .
  This script is the backend for the APT::Periodic::Unattended-Upgrade 
  option.
diff -u ../unattended-upgrades.old/debian/templates debian/templates
--- ../unattended-upgrades.old/debian/templates	2008-11-27 14:03:44.000000000 +0000
+++ debian/templates	2008-11-27 14:04:26.000000000 +0000
@@ -1,8 +1,8 @@
 Template: unattended-upgrades/enable_auto_updates
 Type: boolean
 Default: false
-_Description: Should this system automatically download and install stable updates?
- Applying updates on a frequent basis is an important part of keeping your
- system secure. By default, updates need to be applied manually using package 
+_Description: Automatically download and install stable updates?
+ Applying updates on a frequent basis is an important part of keeping
+ systems secure. By default, updates need to be applied manually using package 
  management tools. Alternatively, you can choose to have this system 
  automatically download and install security updates.
Template: unattended-upgrades/enable_auto_updates
Type: boolean
Default: false
_Description: Automatically download and install stable updates?
 Applying updates on a frequent basis is an important part of keeping
 systems secure. By default, updates need to be applied manually using package 
 management tools. Alternatively, you can choose to have this system 
 automatically download and install security updates.
Source: unattended-upgrades
Section: admin
Priority: optional
Maintainer: Michael Vogt <mvo@debian.org>
Build-Depends: debhelper (>= 5.0.37.2), po-debconf
Build-Depends-Indep: python, python-dev, python-distutils-extra
Standards-Version: 3.7.2

Package: unattended-upgrades
Architecture: all
Depends: python, ${shlibs:Depends}, python-apt (>= 0.7), apt-utils (>= 0.7), apt (>= 0.7), ucf
Suggests: mailx
Description: automatic installation of security upgrades
 This package can download and install security upgrades automatically
 and unattended, taking care to only install packages from the configured
 APT source, and checking for conffile prompts.
 .
 This script is the backend for the APT::Periodic::Unattended-Upgrade 
 option.

Reply to: