[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://unattended-upgrades/{templates}



Please find, for review, the debconf templates and packages descriptions for the unattended-upgrades source package.

This review will last from Thursday, November 27, 2008 to Sunday, November 30, 2008.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../unattended-upgrades.old/debian/templates	2008-11-27 12:42:56.218454493 +0100
+++ debian/templates	2008-11-27 12:52:26.518456032 +0100
@@ -1,8 +1,8 @@
 Template: unattended-upgrades/enable_auto_updates
 Type: boolean
 Default: false
-_Description: Should this system automatically download and install stable updates?
- Applying updates on a frequent basis is an important part of keeping your
- system secure. By default, updates need to be applied manually using package 
+_Description: Automatically download and install stable updates?
+ Applying updates on a frequent basis is an important part of keeping
+ systems secure. By default, updates need to be applied manually using package 
  management tools. Alternatively, you can choose to have this system 
  automatically download and install security updates.

Shorten the short description so that it remains short..:-)

The trick of using the infinitive form in such case is fairly common

Unpersonnalize the template: the system is not necessarily "mine"


--- ../unattended-upgrades.old/debian/control	2008-11-27 12:42:56.218454493 +0100
+++ debian/control	2008-11-27 12:53:46.814455118 +0100
@@ -10,9 +10,9 @@
 Architecture: all
 Depends: python, ${shlibs:Depends}, python-apt (>= 0.7), apt-utils (>= 0.7), apt (>= 0.7), ucf
 Suggests: mailx
-Description: Install security upgrades automatically 
- This package will download and install security upgrades automatically
- and unattended. It will take care to only install packages from the 
+Description: automatic installation of security upgrades
+ This package will optionnally download and install security upgrades automatically
+ and unattended. It can take care to only install packages from the 
  configured origin and will check for conffile prompts.
  . 
  This script is the backend for the APT::Periodic::Unattended-Upgrade 

I tried to address the concern in #473082....Add "optionnally" and
replace "will" by "can".

Drop leading capital in the synopsis (see DevRef)


-- 


Template: unattended-upgrades/enable_auto_updates
Type: boolean
Default: false
_Description: Automatically download and install stable updates?
 Applying updates on a frequent basis is an important part of keeping
 systems secure. By default, updates need to be applied manually using package 
 management tools. Alternatively, you can choose to have this system 
 automatically download and install security updates.
--- ../unattended-upgrades.old/debian/templates	2008-11-27 12:42:56.218454493 +0100
+++ debian/templates	2008-11-27 12:52:26.518456032 +0100
@@ -1,8 +1,8 @@
 Template: unattended-upgrades/enable_auto_updates
 Type: boolean
 Default: false
-_Description: Should this system automatically download and install stable updates?
- Applying updates on a frequent basis is an important part of keeping your
- system secure. By default, updates need to be applied manually using package 
+_Description: Automatically download and install stable updates?
+ Applying updates on a frequent basis is an important part of keeping
+ systems secure. By default, updates need to be applied manually using package 
  management tools. Alternatively, you can choose to have this system 
  automatically download and install security updates.
--- ../unattended-upgrades.old/debian/control	2008-11-27 12:42:56.218454493 +0100
+++ debian/control	2008-11-27 12:53:46.814455118 +0100
@@ -10,9 +10,9 @@
 Architecture: all
 Depends: python, ${shlibs:Depends}, python-apt (>= 0.7), apt-utils (>= 0.7), apt (>= 0.7), ucf
 Suggests: mailx
-Description: Install security upgrades automatically 
- This package will download and install security upgrades automatically
- and unattended. It will take care to only install packages from the 
+Description: automatic installation of security upgrades
+ This package will optionnally download and install security upgrades automatically
+ and unattended. It can take care to only install packages from the 
  configured origin and will check for conffile prompts.
  . 
  This script is the backend for the APT::Periodic::Unattended-Upgrade 
Source: unattended-upgrades
Section: admin
Priority: optional
Maintainer: Michael Vogt <mvo@debian.org>
Build-Depends: debhelper (>= 5.0.37.2), po-debconf
Build-Depends-Indep: python, python-dev, python-distutils-extra
Standards-Version: 3.7.2

Package: unattended-upgrades
Architecture: all
Depends: python, ${shlibs:Depends}, python-apt (>= 0.7), apt-utils (>= 0.7), apt (>= 0.7), ucf
Suggests: mailx
Description: automatic installation of security upgrades
 This package will optionnally download and install security upgrades automatically
 and unattended. It can take care to only install packages from the 
 configured origin and will check for conffile prompts.
 . 
 This script is the backend for the APT::Periodic::Unattended-Upgrade 
 option.

Attachment: signature.asc
Description: Digital signature


Reply to: