[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://isight-firmware-tools/{templates}



(I'm a bit rusty on procedure here, but my attached diff is against
the file versions out of isight-firmware-tools 1.2-5, minus template
translations, rather than against the versions attached to the TAF) 

Christian Perrier wrote:
>  _Description: Extract firmware from Apple driver?
> - Ensure you have access to the AppleUSBVideoSupport driver file. If not
> - disable firmware extraction, you can retry it later.
> + If you choose this option, please make sure that you have access to
> + the AppleUSBVideoSupport driver file.
> 
> Make sentences.
> 
> The second sentence is....impossible to understand.

It's grammatical but underpunctuated: "If (you do) not (have access
to the AppleUSBVideoSupport driver file), (then) disable firmware
extraction (by answering no).  You can retry it later."

But agreed, drop this sentence.
 
>  Template: isight-firmware-tools/file_not_exist
>  Type: note
> -_Description: An input file name doesn't exist
> - Finished without extracting firmware.
> +_Description: Apple driver file not found
> + The file you specified does not exist. The firmware extraction is
> + aborted.
> 
> Note title unintelligible.

(Or false: the name exists, it just isn't in use...)

> I propose just giving the facts. The file
> was not found.
> 
> We have not "finished" as the extraction failed....

I'd prefer "Firmware extraction has been aborted."
 
[...]
>  Package: isight-firmware-tools
[...]
> +Description: tools dealing with Apple iSight Firmware

   Description: tools for dealing with Apple iSight firmware
or maybe        tools for handling Apple iSight firmware

> 
> + Apple Built-in iSight requires a firmware that can be extracted from
                                   ^
Wares are non-count nouns.

> + the Mac OS X USBVideo driver. This package provides tools for extracting
>   the firmware from the driver and install udev rules and tools to
                                     installing
>   automatically load the firmware once needed.
                                    when

>   A convenient tool for converting firmware binary to Intel HEX format
                                              binaries
>   is provided as well. This might be useful later for use with a
       also provided. This may be required

(Inflating it to "required" partly on the assumption that in this
context it's more than just useful, partly to avoid over-"use".)

> - generic firmware loader like fxload.
> + generic firmware loader such as fxload.
> 
> s/like/such as (am I right?)

Yes, if it means "any loader (and fxload is an example)".  "Like" is
very widely used in informal English to mean the same thing, but in
a formal style it's "any loader (as long as it resembles fxload)".
There's even a possible implication that fxload itself isn't a valid
choice.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru isight-firmware-tools.orig/debian/control isight-firmware-tools.jbr/debian/control
--- isight-firmware-tools.orig/debian/control	2008-11-05 04:16:46.000000000 +0000
+++ isight-firmware-tools.jbr/debian/control	2008-11-07 08:51:49.000000000 +0000
@@ -1,17 +1,20 @@
-Package: isight-firmware-tools
-Version: 1.2-5
-Architecture: i386
-Maintainer: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
-Installed-Size: 216
-Depends: libc6 (>= 2.7-1), libdbus-1-3 (>= 1.0.2), libgcrypt11 (>= 1.4.0), libglib2.0-0 (>= 2.14.0), libhal1 (>= 0.5.8.1), libusb-0.1-4 (>= 2:0.1.12), debconf (>= 0.5) | debconf-2.0, hal
+Source: isight-firmware-tools
 Section: contrib/graphics
 Priority: extra
-Description: Built-in Apple iSight Firmware Tools
- Apple Built-in iSight require a firmware that can be extracted from
- Mac OS X USBVideo driver. This projet provide tools for extracting
- the firmware from the driver and install udev rules and tools to
- automatically load the firmware once needed.
+Dm-Upload-Allowed: yes
+Maintainer: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
+Build-Depends: debhelper (>= 5), autotools-dev, cdbs, dpatch, po-debconf, intltool, libglib2.0-dev, libgcrypt11-dev, libusb-dev, libhal-dev
+Standards-Version: 3.8.0.1
+
+Package: isight-firmware-tools
+Architecture: i386 amd64
+Depends: ${shlibs:Depends}, ${misc:Depends}, hal
+Description: tools for dealing with Apple iSight firmware
+ Apple Built-in iSight requires firmware that can be extracted from
+ the Mac OS X USBVideo driver. This package provides tools for extracting
+ the firmware from the driver and installing udev rules and tools to
+ automatically load the firmware when needed.
  .
- A convenient tool for converting firmware binary to Intel HEX format
- is provided as well. This might be useful later for use with a
- generic firmware loader like fxload.
+ A convenient tool for converting firmware binaries to Intel HEX format
+ is also provided. This may be required later for use with a
+ generic firmware loader such as fxload.
diff -ru isight-firmware-tools.orig/debian/templates isight-firmware-tools.jbr/debian/templates
--- isight-firmware-tools.orig/debian/templates	2008-11-07 10:55:46.000000000 +0000
+++ isight-firmware-tools.jbr/debian/templates	2008-11-07 08:54:39.000000000 +0000
@@ -1,27 +1,28 @@
 Template: isight-firmware-tools/extract
 Type: boolean
 Default: true
-Description: Extract firmware from Apple driver?
- Ensure you have access to the AppleUSBVideoSupport driver file. If not
- disable firmware extraction, you can retry it later.
+_Description: Extract firmware from Apple driver?
+ If you choose this option, please make sure that you have access to
+ the AppleUSBVideoSupport driver file.
 
 Template: isight-firmware-tools/driver-location
 Type: string
 Default: /MacOSX/System/Library/Extensions/IOUSBFamily.kext/Contents/PlugIns/AppleUSBVideoSupport.kext/Contents/MacOS/AppleUSBVideoSupport
-Description: Apple driver file location:
+_Description: Apple driver file location:
 
 Template: isight-firmware-tools/file_not_exist
 Type: note
-Description: An input file name doesn't exist
- Finished without extracting firmware.
+_Description: Apple driver file not found
+ The file you specified does not exist. The firmware extraction has been
+ aborted.
 
 Template: isight-firmware-tools/extract_success
 Type: text
-Description: Extract success
- Extract success. Enjoy iSigiht!.
+_Description: Firmware extracted successfully
+ The iSight firmware has been extracted successfully.
 
 Template: isight-firmware-tools/extract_fail
 Type: text
-Description: Extract fail
- Extract fail. This firmware does not support
- or the file which you chose is not firmware.
+_Description: Failed to extract firmware
+ The firmware extraction failed. Please check that the file you
+ specified is a valid firmware file.
Template: isight-firmware-tools/extract
Type: boolean
Default: true
_Description: Extract firmware from Apple driver?
 If you choose this option, please make sure that you have access to
 the AppleUSBVideoSupport driver file.

Template: isight-firmware-tools/driver-location
Type: string
Default: /MacOSX/System/Library/Extensions/IOUSBFamily.kext/Contents/PlugIns/AppleUSBVideoSupport.kext/Contents/MacOS/AppleUSBVideoSupport
_Description: Apple driver file location:

Template: isight-firmware-tools/file_not_exist
Type: note
_Description: Apple driver file not found
 The file you specified does not exist. The firmware extraction has been
 aborted.

Template: isight-firmware-tools/extract_success
Type: text
_Description: Firmware extracted successfully
 The iSight firmware has been extracted successfully.

Template: isight-firmware-tools/extract_fail
Type: text
_Description: Failed to extract firmware
 The firmware extraction failed. Please check that the file you
 specified is a valid firmware file.
Source: isight-firmware-tools
Section: contrib/graphics
Priority: extra
Dm-Upload-Allowed: yes
Maintainer: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Build-Depends: debhelper (>= 5), autotools-dev, cdbs, dpatch, po-debconf, intltool, libglib2.0-dev, libgcrypt11-dev, libusb-dev, libhal-dev
Standards-Version: 3.8.0.1

Package: isight-firmware-tools
Architecture: i386 amd64
Depends: ${shlibs:Depends}, ${misc:Depends}, hal
Description: tools for dealing with Apple iSight firmware
 Apple Built-in iSight requires firmware that can be extracted from
 the Mac OS X USBVideo driver. This package provides tools for extracting
 the firmware from the driver and installing udev rules and tools to
 automatically load the firmware when needed.
 .
 A convenient tool for converting firmware binaries to Intel HEX format
 is also provided. This may be required later for use with a
 generic firmware loader such as fxload.

Reply to: