Re: [RFR] templates://hddtemp/{templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
> Template: hddtemp/SUID_bit
[...]
> +_Description: Should /usr/sbin/hddtemp be installed SUID root?
> + You have the option of installing hddtemp with the SUID bit set, allowing
> + it to be run and report the hard drives' temperature to regular users and
> + not only the superuser.
"To be run and report [...] to users" feels awkward, partly because
there seems to be a missing "by". Then since hddtemp may report
multiple different temperatures, "the [plural] hard drives'
[singular] temperature" feels wrong - I'd go for:
You have the option of installing hddtemp with the SUID bit set, allowing
it to be run (reporting hard drive temperatures) by regular users and
not only the superuser.
> Template: hddtemp/daemon
[...]
> You have the option of starting the hddtemp daemon automatically on the
> computer startup. If in doubt, it is suggested to not start it automatically
> + on startup.
Superfluous "the" (or something) in "on the computer startup"; and
starting on startup gets repetitive, so say:
You have the option of starting the hddtemp daemon automatically on system
boot. If in doubt, it is suggested to not start it automatically on boot.
> Package: hddtemp
[...]
> -Description: Utility to monitor the temperature of your hard drive
> +Description: monitor hard drives temperature
That's what it does, not what it is (a verb phrase, not a noun
phrase).
Description: hard drive temperature monitoring utility
("Monitoring utility" does at least avoid the problem that the noun
"monitor" is ambiguous in a hardware context.)
> "modern" is subjective and, moreover, that was probably true in the
> 20th century but, as of now, I guess that all HD support this.
My own hardware's pretty "trailing-edge"; out of the four PATA and
three SCSI drives I've tested, hddtemp only works on the two newest.
Still, you've kept "on drives that support this feature", and that's
enough of a hint.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../hddtemp.old/debian/templates 2008-01-10 08:36:01.000000000 +0000
+++ debian/templates 2008-01-11 19:30:07.000000000 +0000
@@ -1,52 +1,53 @@
Template: hddtemp/SUID_bit
Type: boolean
Default: false
-_Description: Do you want /usr/sbin/hddtemp to be installed SUID root?
- You have the option of installing hddtemp with the SUID bit set.
+_Description: Should /usr/sbin/hddtemp be installed SUID root?
+ You have the option of installing hddtemp with the SUID bit set, allowing
+ it to be run (reporting hard drive temperatures) by regular users and
+ not only the superuser.
.
- If you make hddtemp SUID, unprivileged users of your systems will be able
- to run it. This could, however, potentially allow hddtemp to be used
- during a security attack on your computer. If in doubt, it is suggested
- to install it without SUID. If you later change your mind, you can run:
- 'dpkg-reconfigure hddtemp'.
+ This could potentially allow hddtemp to be used during an attack
+ against the computer's security. If in doubt, do not choose this option.
+ .
+ This setting can be modified later by running 'dpkg-reconfigure hddtemp'.
Template: hddtemp/syslog
Type: string
Default: 0
-_Description: Interval between two checks:
- hddtemp can periodically log the temperature of the hard drive(s) via
- the SYSLOG interface.
+_Description: Interval between hard drive temperature checks:
+ The temperature of the hard drive(s) can be logged by hddtemp via
+ the generic system logging interface.
.
Please enter a value in seconds corresponding to the interval between
- two checks. To disable this feature, simply enter 0.
+ two checks. To disable this feature, enter 0.
Template: hddtemp/daemon
Type: boolean
Default: false
-_Description: Do you want to start the hddtemp daemon on startup?
- hddtemp can be run as a daemon, listening on port 7634 for incoming
- connections. It is used some by software such as gkrellm to get
+_Description: Should the hddtemp daemon be started at boot?
+ The hddtemp program can be run as a daemon, listening on port 7634
+ for incoming connections. It is used some by software such as gkrellm to get
the temperature of the hard drives.
.
- You have the option of starting the hddtemp daemon automatically on the
- computer startup. If in doubt, it is suggested to not start it automatically
- on startup. If you later change your mind, you can run: 'dpkg-reconfigure
- hddtemp'.
+ You have the option of starting the hddtemp daemon automatically on system
+ boot. If in doubt, it is suggested to not start it automatically on boot.
+ .
+ This setting can be modified later by running 'dpkg-reconfigure hddtemp'.
Template: hddtemp/interface
Type: string
Default: 127.0.0.1
_Description: Interface to listen on:
- hddtemp can listen for incoming connections on a specific interface, or on
- all interfaces.
+ The hddtemp program can listen for incoming connections on a specific
+ interface, or on all interfaces.
.
To listen on a specific interface, enter the IP address of that interface
- (127.0.0.1 which is the default value corresponds to the lo interface). To
- listen on all interfaces, simply enter 0.0.0.0.
+ (choosing 127.0.0.1 will accept local connections only). To listen on all interfaces,
+ enter 0.0.0.0.
Template: hddtemp/port
Type: string
Default: 7634
_Description: Port to listen on:
- By default, hddtemp listen for incoming connections on port 7634. However
- if you don't find this port appropriate, you can enter an other one.
+ By default, hddtemp listen for incoming connections on port 7634. This
+ can be changed for another port number.
--- ../hddtemp.old/debian/control 2008-01-10 08:36:01.000000000 +0000
+++ debian/control 2008-01-11 19:30:47.000000000 +0000
@@ -4,17 +4,14 @@
Maintainer: Aurelien Jarno <aurel32@debian.org>
Build-Depends: debhelper (>> 4.1.16), autotools-dev, gettext (>> 0.10.1)
Standards-Version: 3.7.2
+Homepage: http://www.guzu.net/linux/hddtemp.php
Package: hddtemp
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-3)
Suggests: ksensors
Conflicts: ksensors (<< 0.7-8), gkrellm-hddtemp (<< 0.1-9)
-Description: Utility to monitor the temperature of your hard drive
- hddtemp will give you the temperature of your PATA, SATA or SCSI hard
- drive by reading Self-Monitoring Analysis and Reporting Technology
- (S.M.A.R.T.) information (on drives that support this feature). Only
- modern hard drives have a temperature sensor.
- .
- Author: Emmanuel Varagnat <hddtemp@guzu.net>
- Homepage: http://www.guzu.net/linux/hddtemp.php
+Description: hard drive temperature monitoring utility
+ The hddtemp program monitors and reports the temperature of PATA, SATA
+ or SCSI hard drives by reading Self-Monitoring Analysis and Reporting
+ Technology (S.M.A.R.T.) information on drives that support this feature.
Template: hddtemp/SUID_bit
Type: boolean
Default: false
_Description: Should /usr/sbin/hddtemp be installed SUID root?
You have the option of installing hddtemp with the SUID bit set, allowing
it to be run (reporting hard drive temperatures) by regular users and
not only the superuser.
.
This could potentially allow hddtemp to be used during an attack
against the computer's security. If in doubt, do not choose this option.
.
This setting can be modified later by running 'dpkg-reconfigure hddtemp'.
Template: hddtemp/syslog
Type: string
Default: 0
_Description: Interval between hard drive temperature checks:
The temperature of the hard drive(s) can be logged by hddtemp via
the generic system logging interface.
.
Please enter a value in seconds corresponding to the interval between
two checks. To disable this feature, enter 0.
Template: hddtemp/daemon
Type: boolean
Default: false
_Description: Should the hddtemp daemon be started at boot?
The hddtemp program can be run as a daemon, listening on port 7634
for incoming connections. It is used some by software such as gkrellm to get
the temperature of the hard drives.
.
You have the option of starting the hddtemp daemon automatically on system
boot. If in doubt, it is suggested to not start it automatically on boot.
.
This setting can be modified later by running 'dpkg-reconfigure hddtemp'.
Template: hddtemp/interface
Type: string
Default: 127.0.0.1
_Description: Interface to listen on:
The hddtemp program can listen for incoming connections on a specific
interface, or on all interfaces.
.
To listen on a specific interface, enter the IP address of that interface
(choosing 127.0.0.1 will accept local connections only). To listen on all interfaces,
enter 0.0.0.0.
Template: hddtemp/port
Type: string
Default: 7634
_Description: Port to listen on:
By default, hddtemp listen for incoming connections on port 7634. This
can be changed for another port number.
Source: hddtemp
Section: utils
Priority: extra
Maintainer: Aurelien Jarno <aurel32@debian.org>
Build-Depends: debhelper (>> 4.1.16), autotools-dev, gettext (>> 0.10.1)
Standards-Version: 3.7.2
Homepage: http://www.guzu.net/linux/hddtemp.php
Package: hddtemp
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-3)
Suggests: ksensors
Conflicts: ksensors (<< 0.7-8), gkrellm-hddtemp (<< 0.1-9)
Description: hard drive temperature monitoring utility
The hddtemp program monitors and reports the temperature of PATA, SATA
or SCSI hard drives by reading Self-Monitoring Analysis and Reporting
Technology (S.M.A.R.T.) information on drives that support this feature.
Reply to: